extract some inline expressions into variables for cleaner code

Author: hawkrives

source/views/menus/components/filter-menu-toolbar.js

@@ -27,7 +27,9 @@ export function FilterMenuToolbar({date, title, filters, onPress}: PropsType) {
   const appliedFilterCount = filters
     .filter(f => f.type !== 'picker')
     .filter(f => f.enabled).length
+
   const isFiltered = appliedFilterCount > 0
+  const filterWord = appliedFilterCount === 1 ? 'Filter' : 'Filters'
 
   return (
     <Toolbar onPress={onPress}>
@@ -41,11 +43,7 @@ export function FilterMenuToolbar({date, title, filters, onPress}: PropsType) {
       <ToolbarButton
         isActive={isFiltered}
         title={
-          isFiltered
-            ? `${appliedFilterCount} ${appliedFilterCount === 1
-                ? 'Filter'
-                : 'Filters'}`
-            : 'No Filters'
+          isFiltered ? `${appliedFilterCount} ${filterWord}` : 'No Filters'
         }
         iconName={Platform.OS === 'ios' ? 'ios-funnel' : 'md-funnel'}
       />

source/views/transportation/bus/index.js

@@ -46,13 +46,10 @@ export default class BusView extends React.Component {
     const activeBusLine = busLines.find(({line}) => line === this.props.line)
 
     if (!activeBusLine) {
+      const {line} = this.props
+      const lines = busLines.map(({line}) => line).join(', ')
       return (
-        <NoticeView
-          text={`The line "${this.props
-            .line}" was not found among ${busLines
-            .map(({line}) => line)
-            .join(', ')}`}
-        />
+        <NoticeView text={`The line "${line}" was not found among ${lines}`} />
       )
     }
 

source/views/transportation/otherModes.js

@@ -43,14 +43,13 @@ export default function OtherModesView() {
             {data.description}
           </Text>
           <Button
-            onPress={() =>
-              trackedOpenUrl({
+            onPress={() => {
+              const modeName = data.name.replace(' ', '')
+              return trackedOpenUrl({
                 url: data.url,
-                id: `Transportation_OtherModes_${data.name.replace(
-                  ' ',
-                  '',
-                )}View`,
-              })}
+                id: `Transportation_OtherModes_${modeName}View`,
+              })
+            }}
             title="More info"
           />
         </View>}