add config key for showing/hiding recent course search filters

Author: drewvolz

modules/app-config/index.tsx

@@ -5,17 +5,6 @@ import {isDevMode} from '@frogpond/constants'
 
 export type {AppConfigKey, FeatureFlagType} from './types'
 
-// datastore for the __DEV__ feature flags
-export const AppConfig = async (): Promise<FeatureFlagType[]> => {
-	return [
-		{
-			configKey: AppConfigKey.TestDataKey,
-			title: 'Test config key',
-			active: await getFeatureFlag(AppConfigKey.TestDataKey),
-		},
-	]
-}
-
 // helper method to query exported __DEV__ feature flags
 const useFeature = (featureKey: AppConfigKey): boolean => {
 	let {data: featureValue = false} = useQuery({
@@ -29,6 +18,17 @@ const useFeature = (featureKey: AppConfigKey): boolean => {
 	return isDevMode() ? featureValue : false
 }
 
+// datastore for the __DEV__ feature flags
+export const AppConfig = async (): Promise<FeatureFlagType[]> => {
+	return [
+		{
+			title: 'Show the course search recents screen',
+			configKey: AppConfigKey.Courses_ShowRecentSearchScreen,
+			active: await getFeatureFlag(AppConfigKey.Courses_ShowRecentSearchScreen),
+		},
+	]
+}
+
 // exported feature flags
-export const useTestFeature = (): boolean =>
-	useFeature(AppConfigKey.TestDataKey)
+export const useCourseSearchRecentsScreen = (): boolean =>
+	useFeature(AppConfigKey.Courses_ShowRecentSearchScreen)

modules/app-config/types.ts

@@ -4,8 +4,16 @@ export interface FeatureFlagType {
 	active: boolean
 }
 
+/**
+ * __DEV__ app config keys
+ *
+ * Reserved for dev-only flags for internal experimentation, these
+ * will never be A/B flags nor will they return true in production.
+ *
+ * The format is SECTION_KEY where the first underscore will be
+ * split at render time for our view to group by, but the entirety
+ * of the value (section + key) will be stored.
+ */
 export enum AppConfigKey {
-	TestDataKey = 'TestData',
-}
-
+	Courses_ShowRecentSearchScreen = 'Courses_ShowRecentSearchScreen',
 }

source/navigation/types.tsx

@@ -48,7 +48,7 @@ export type RootViewsParamList = {
 	More: undefined
 	PrintJobs: undefined
 	StudentOrgs: undefined
-}
+} & Pick<MiscViewParamList, 'CourseSearchResults'>
 
 export type CafeMenuParamList = {
 	CarletonBurtonMenu: undefined
@@ -76,10 +76,9 @@ export type MiscViewParamList = {
 	DirectoryDetail: {contact: DirectoryItem}
 	Job: undefined
 	JobDetail: {job: JobType}
-	CourseSearchResults: {
-		initialQuery?: string
-		initialFilters?: FilterType<CourseType>[]
-	}
+	CourseSearchResults:
+		| {initialQuery?: string; initialFilters?: FilterType<CourseType>[]}
+		| undefined
 	CourseDetail: {course: CourseType}
 	StudentOrgsDetail: {org: StudentOrgType}
 	BusMapView: {line: UnprocessedBusLine}