Skip to content

Commit 82de4ed

Browse files
committed
fix looking for the wrong extension id when running match
1 parent 5384c11 commit 82de4ed

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

fastlane/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,11 @@ Fetch certs for both the app and any extensions
110110
fastlane ios bootstrap
111111
```
112112
Ensure that everything is set up (must be run manually, as it needs a 2FA code)
113+
### ios generate_certificates
114+
```
115+
fastlane ios generate_certificates
116+
```
117+
Generate certs for the app and for any extensions
113118
### ios generate_pem
114119
```
115120
fastlane ios generate_pem

fastlane/platforms/ios.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@
123123

124124
desc 'Fetch certs for both the app and any extensions'
125125
lane :certificates do |options|
126-
app = 'NFMTHAZVS9.com.drewvolz.stolaf'
127-
push_extension = 'tech.frogpond.allaboutolaf.onesignal.notification-service-extension'
126+
app = lane_context[:APPLE_APP_ID]
127+
push_extension = lane_context[:APPLE_PUSH_EXTENSION_ID]
128128

129129
match(app_identifier: [app, push_extension],
130130
type: options[:type],
@@ -161,7 +161,7 @@
161161
end
162162

163163
desc 'Generate certs for the app and for any extensions'
164-
private_lane :generate_certificates do
164+
lane :generate_certificates do
165165
app = lane_context[:APPLE_APP_ID]
166166
push_extension = lane_context[:APPLE_PUSH_EXTENSION_ID]
167167

0 commit comments

Comments
 (0)