Merge pull request #7096 from StoDevX/drew/fix-building-favorites

fix redux action for favorite building hours

Author: hawkrives

modules/navigation-buttons/styles.ts

@@ -1,4 +1,5 @@
 import {StyleSheet, Platform} from 'react-native'
+import {link} from '@frogpond/colors'
 
 export const commonStyles = StyleSheet.create({
 	button: {
@@ -40,6 +41,7 @@ export const rightButtonStyles = StyleSheet.create({
 		}),
 	},
 	icon: {
+		color: link,
 		...Platform.select({
 			ios: {
 				fontSize: 24,

source/redux/__tests__/buildings.test.ts

@@ -0,0 +1,32 @@
+import {reducer, State, toggleFavoriteBuilding} from '../parts/buildings'
+
+describe('toggle favorite building hours', () => {
+	it('should return the initial state', () => {
+		const {favorites} = reducer(undefined, {type: undefined})
+		expect(favorites).toEqual([])
+	})
+
+	it('should handle a favorite being added to an empty list', () => {
+		const previousState: State = {favorites: []}
+		const {favorites} = reducer(previousState, toggleFavoriteBuilding('a'))
+		expect(favorites).toEqual(['a'])
+	})
+
+	it('should handle a favorite being added to an existing list', () => {
+		const previousState: State = {favorites: ['a', 'b']}
+		const {favorites} = reducer(previousState, toggleFavoriteBuilding('c'))
+		expect(favorites).toEqual(['a', 'b', 'c'])
+	})
+
+	it('should handle a favorite being removed from an existing list', () => {
+		const previousState: State = {favorites: ['a']}
+		const {favorites} = reducer(previousState, toggleFavoriteBuilding('a'))
+		expect(favorites).toEqual([])
+	})
+
+	it('should handle a favorite being removed from an existing list of multiple favorites', () => {
+		const previousState: State = {favorites: ['a', 'b']}
+		const {favorites} = reducer(previousState, toggleFavoriteBuilding('a'))
+		expect(favorites).toEqual(['b'])
+	})
+})

source/redux/parts/buildings.ts

@@ -2,7 +2,7 @@ import {createSlice} from '@reduxjs/toolkit'
 import type {PayloadAction} from '@reduxjs/toolkit'
 import type {RootState} from '../store'
 
-type State = {
+export type State = {
 	favorites: Array<string>
 }
 
@@ -17,7 +17,12 @@ const slice = createSlice({
 	reducers: {
 		toggleFavoriteBuilding(state, action: PayloadAction<string>) {
 			let favoritesSet = new Set(state.favorites)
-			favoritesSet.delete(action.payload)
+
+			if (favoritesSet.has(action.payload)) {
+				favoritesSet.delete(action.payload)
+			} else {
+				favoritesSet.add(action.payload)
+			}
 
 			let newFavorites = Array.from(favoritesSet)