Skip to content

Commit c7de93b

Browse files
committed
circle: Stop repeating Docker image for node builds
Instead, extract it out much as we do elsewhere.
1 parent 6002602 commit c7de93b

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

.circleci/config.yml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
version: 2
33

44
x-config:
5+
x-images:
6+
- &docker-node
7+
- image: 'circleci/node:8'
58
x-caching: # caching instructions
69
- &save-cache-yarn
710
key: 'v3-yarn-dependencies-{{ arch }}-{{ checksum "yarn.lock" }}'
@@ -103,7 +106,7 @@ workflows:
103106

104107
jobs:
105108
cache-yarn-linux:
106-
docker: [{image: 'circleci/node:8'}]
109+
docker: *docker-node
107110
steps:
108111
- checkout
109112
- restore_cache: *restore-cache-yarn
@@ -125,7 +128,7 @@ jobs:
125128
- save_cache: *save-cache-bundler
126129

127130
danger:
128-
docker: [{image: 'circleci/node:8'}]
131+
docker: *docker-node
129132
environment:
130133
task: JS-general
131134
steps:
@@ -134,7 +137,7 @@ jobs:
134137
- run: *run-danger
135138

136139
flow:
137-
docker: [{image: 'circleci/node:8'}]
140+
docker: *docker-node
138141
environment:
139142
task: JS-flow
140143
steps:
@@ -146,7 +149,7 @@ jobs:
146149
- run: *run-danger
147150

148151
jest:
149-
docker: [{image: 'circleci/node:8'}]
152+
docker: *docker-node
150153
environment:
151154
task: JS-jest
152155
JEST_JUNIT_OUTPUT: ./test-results/jest/junit.xml
@@ -171,7 +174,7 @@ jobs:
171174
fi
172175
173176
prettier:
174-
docker: [{image: 'circleci/node:8'}]
177+
docker: *docker-node
175178
environment:
176179
task: JS-prettier
177180
steps:
@@ -189,7 +192,7 @@ jobs:
189192
- run: *run-danger
190193

191194
eslint:
192-
docker: [{image: 'circleci/node:8'}]
195+
docker: *docker-node
193196
environment:
194197
task: JS-lint
195198
steps:
@@ -204,7 +207,7 @@ jobs:
204207
path: ./test-results
205208

206209
data:
207-
docker: [{image: 'circleci/node:8'}]
210+
docker: *docker-node
208211
environment:
209212
task: JS-data
210213
steps:
@@ -260,7 +263,7 @@ jobs:
260263
IS_NIGHTLY: '1'
261264

262265
android-bundle:
263-
docker: [{image: 'circleci/node:8'}]
266+
docker: *docker-node
264267
environment:
265268
task: JS-bundle-android
266269
steps:
@@ -322,7 +325,7 @@ jobs:
322325
IS_NIGHTLY: '1'
323326

324327
ios-bundle:
325-
docker: [{image: 'circleci/node:8'}]
328+
docker: *docker-node
326329
environment:
327330
task: JS-bundle-ios
328331
steps:

0 commit comments

Comments
 (0)