Skip to content

Commit e5e9cc6

Browse files
committed
fastlane: Remove short-circuit for build numbers
Previously we were just calling current_build_number which immediately passed witht he results from build_number. Instead, just call build_number, which doesn't need args[:track]. Signed-off-by: Kristofer Rye <[email protected]>
1 parent 487af03 commit e5e9cc6

File tree

1 file changed

+2
-18
lines changed

1 file changed

+2
-18
lines changed

fastlane/lib/versions.rb

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,3 @@
1-
# Gets the version, be it from Travis, Testflight, or Google Play
2-
def current_build_number(**args)
3-
return build_number if build_number
4-
5-
begin
6-
case lane_context[:PLATFORM_NAME]
7-
when :android
8-
(google_play_track_version_codes(track: args[:track]) + 1).to_s
9-
when :ios
10-
(latest_testflight_build_number + 1).to_s
11-
end
12-
rescue StandardError
13-
'1'
14-
end
15-
end
16-
171
# get the current build number from the environment
182
def build_number
193
travis = ENV['TRAVIS_BUILD_NUMBER']
@@ -36,11 +20,11 @@ def current_bundle_version
3620
end
3721

3822
# Copy the package.json version into the other version locations
39-
def propagate_version(**args)
23+
def propagate_version
4024
return unless ENV.key? 'CI'
4125

4226
version = get_package_key(key: :version)
43-
build = current_build_number(track: args[:track] || nil)
27+
build = build_number
4428

4529
UI.message "Propagating version: #{version}"
4630
UI.message 'into the Info.plist and build.gradle files'

0 commit comments

Comments
 (0)