Skip to content

Localization breaks multiple MM patches due to hardcoded manufacturer checks #14

@tinygrox

Description

@tinygrox

I noticed a patch issue affecting multiple files in OPT_Reconfig (e.g. OPT_01Tweak.cfg and others):

@PART:HAS[#manufacturer[OPT?Aerospace?Division],@MODULE[ModuleRCSFX],@MODULE[TweakScale]]:NEEDS[B9PartSwitch,!RealismOverhaul]
{
FeatureBiasA = #$@OPTMOD/FeatureBiasA$
}

Many patches target parts using the hardcoded manufacturer string:

:HAS[#manufacturer[OPT*Division]]

However, the manufacturer is localized:

#LOC_OPT_manufacturerA = OPT Aerospace Division
#LOC_OPT_manufacturerP = OPT Propulsion Science Division

When the game runs in a non-English language, the manufacturer changes (e.g., Chinese), causing the :HAS[#manufacturer[...]] check to fail.

This breaks a bunch of patches for non-English players.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions