Fix boost

Author: StormBytePP

lib/task/execute/base.cxx

@@ -6,22 +6,27 @@
 #include <cstring>
 #include <fcntl.h>
 #include <vector>
-#include <boost/process/v1/pipe.hpp>
-#include <boost/process/v1/io.hpp>
-#include <boost/process/v1/child.hpp>
+
+#include <boost/process/pipe.hpp>
+#include <boost/process/io.hpp>
+#include <boost/process/child.hpp>
+
 #include <boost/asio.hpp>
 #include <boost/asio/posix/stream_descriptor.hpp>
 
 using namespace StormByte::VideoConvert;
 
-Task::Execute::Base::Base(const Types::path_t& program, const std::string& arguments):Task::Base(), m_executables({ Executable(program, arguments) }) {}
-
-Task::Execute::Base::Base(Types::path_t&& program, std::string&& arguments):Task::Base(), m_executables({ Executable(std::move(program), std::move(arguments)) }) {}
+Task::Execute::Base::Base(const Types::path_t& program, const std::string& arguments)
+	: Task::Base(), m_executables({ Executable(program, arguments) }) {}
 
-Task::Execute::Base::Base(const std::vector<Executable>& execs):Task::Base(), m_executables(execs) {}
+Task::Execute::Base::Base(Types::path_t&& program, std::string&& arguments)
+	: Task::Base(), m_executables({ Executable(std::move(program), std::move(arguments)) }) {}
 
-Task::Execute::Base::Base(std::vector<Executable>&& execs):Task::Base(), m_executables(std::move(execs)) {}
+Task::Execute::Base::Base(const std::vector<Executable>& execs)
+	: Task::Base(), m_executables(execs) {}
 
+Task::Execute::Base::Base(std::vector<Executable>&& execs)
+	: Task::Base(), m_executables(std::move(execs)) {}
 
 Task::STATUS Task::Execute::Base::do_work(std::optional<pid_t>& worker) noexcept {
 	using namespace boost;
@@ -32,21 +37,18 @@ Task::STATUS Task::Execute::Base::do_work(std::optional<pid_t>& worker) noexcept
 		asio::io_context ios;
 
 		try {
-			
 			std::vector<char> vOut(128 << 10);
 			std::vector<char> vErr(128 << 10);
 			auto outBuffer{ asio::buffer(vOut) };
 			auto errBuffer{ asio::buffer(vErr) };
 			auto inBuffer{ asio::buffer(m_stdin) };
 
 			// stdout setup
-            // stdout setup: use a pipe + posix stream_descriptor for async reads
-			boost::process::v1::pipe pipeOut;
-            asio::posix::stream_descriptor sdOut(ios, pipeOut.native_source());
+			process::pipe pipeOut;
+			asio::posix::stream_descriptor sdOut(ios, pipeOut.native_source());
 
-			std::function<void(const system::error_code & ec, std::size_t n)> onStdOut;
-			onStdOut = [&](const system::error_code & ec, size_t n)
-			{
+			std::function<void(const system::error_code&, std::size_t)> onStdOut;
+			onStdOut = [&](const system::error_code& ec, size_t n) {
 				m_stdout.reserve(m_stdout.size() + n);
 				m_stdout.insert(m_stdout.end(), vOut.begin(), vOut.begin() + n);
 				if (!ec) {
@@ -55,49 +57,46 @@ Task::STATUS Task::Execute::Base::do_work(std::optional<pid_t>& worker) noexcept
 			};
 
 			// stderr setup
-			boost::process::v1::pipe pipeErr;
-            asio::posix::stream_descriptor sdErr(ios, pipeErr.native_source());
+			process::pipe pipeErr;
+			asio::posix::stream_descriptor sdErr(ios, pipeErr.native_source());
 
-			std::function<void(const system::error_code & ec, std::size_t n)> onStdErr;
-			onStdErr = [&](const system::error_code & ec, size_t n) {
+			std::function<void(const system::error_code&, std::size_t)> onStdErr;
+			onStdErr = [&](const system::error_code& ec, size_t n) {
 				m_stderr.reserve(m_stderr.size() + n);
 				m_stderr.insert(m_stderr.end(), vErr.begin(), vErr.begin() + n);
-				if (!ec)
-				{
+				if (!ec) {
 					asio::async_read(sdErr, errBuffer, onStdErr);
 				}
 			};
 
 			// stdin setup
-			boost::process::v1::pipe pipeIn;
-            asio::posix::stream_descriptor sdIn(ios, pipeIn.native_sink());
+			process::pipe pipeIn;
+			asio::posix::stream_descriptor sdIn(ios, pipeIn.native_sink());
 
 			if (m_logger)
-				m_logger->message_line(Utils::Logger::LEVEL_DEBUG, "Executing " + m_executables[0].m_program.string() + " " + m_executables[0].m_arguments);
+				m_logger->message_line(Utils::Logger::LEVEL_DEBUG,
+					"Executing " + m_executables[0].m_program.string() + " " + m_executables[0].m_arguments);
 
-			boost::process::v1::child c(
+			process::child c(
 				m_executables[0].m_program.string() + " " + m_executables[0].m_arguments,
-				boost::process::v1::std_out > pipeOut,
-				boost::process::v1::std_err > pipeErr,
-				boost::process::v1::std_in < pipeIn
+				process::std_out > pipeOut,
+				process::std_err > pipeErr,
+				process::std_in < pipeIn
 			);
 
-			
 			asio::async_write(sdIn, inBuffer,
 				[&](const system::error_code&, std::size_t) {
-					// close the parent write end to signal EOF to child
 					boost::system::error_code ec;
 					sdIn.close(ec);
 				});
 
 			asio::async_read(sdOut, outBuffer, onStdOut);
 			asio::async_read(sdErr, errBuffer, onStdErr);
-			
-			// We update worker BEFORE this is run as this is a blocking call
+
 			worker = c.id();
 			ios.run();
 			c.wait();
-			if (c.exit_code() == 0) status = HALT_OK; else status = HALT_ERROR;
+			status = (c.exit_code() == 0) ? HALT_OK : HALT_ERROR;
 		}
 		catch (const std::exception&) {
 			status = HALT_ERROR;