fix: Ignored !important that has insignificant whitespace after it

Signed-off-by: Dmitry Dygalo <[email protected]>

Author: Stranger6667

CHANGELOG.md

@@ -13,9 +13,14 @@
 - Update `selectors` to `0.30`.
 - Update `html5ever` to `0.35`.
 
+### Fixed
+
+- Ignored `!important` that has insignificant whitespace after it.
+
 ### Performance
 
 - Use interned string to compare `style` element name.
+- Only check the value suffix for `!important`.
 
 ## [0.15.0] - 2025-06-17
 

bindings/c/CHANGELOG.md

@@ -8,9 +8,14 @@
 - Update `selectors` to `0.30`.
 - Update `html5ever` to `0.35`.
 
+### Fixed
+
+- Ignored `!important` that has insignificant whitespace after it.
+
 ### Performance
 
 - Use interned string to compare `style` element name.
+- Only check the value suffix for `!important`.
 
 ## [0.15.0] - 2025-06-21
 

bindings/java/CHANGELOG.md

@@ -8,9 +8,14 @@
 - Update `selectors` to `0.30`.
 - Update `html5ever` to `0.35`.
 
+### Fixed
+
+- Ignored `!important` that has insignificant whitespace after it.
+
 ### Performance
 
 - Use interned string to compare `style` element name.
+- Only check the value suffix for `!important`.
 
 ## 0.15.0 - 2025-06-29
 

bindings/javascript/CHANGELOG.md

@@ -11,10 +11,12 @@
 ### Fixed
 
 - Expose `StylesheetCache` interface, `cache` config option, and `version` function.
+- Ignored `!important` that has insignificant whitespace after it.
 
 ### Performance
 
 - Use interned string to compare `style` element name.
+- Only check the value suffix for `!important`.
 
 ## [0.15.0] - 2025-06-24
 

bindings/python/CHANGELOG.md

@@ -11,10 +11,12 @@
 ### Fixed
 
 - Set `3.9` in `requires-python` key in `pyproject.toml`.
+- Ignored `!important` that has insignificant whitespace after it.
 
 ### Performance
 
 - Use interned string to compare `style` element name.
+- Only check the value suffix for `!important`.
 
 ## [0.15.0] - 2025-06-17
 

bindings/ruby/CHANGELOG.md

@@ -7,9 +7,14 @@
 - Update `selectors` to `0.30`.
 - Update `html5ever` to `0.35`.
 
+### Fixed
+
+- Ignored `!important` that has insignificant whitespace after it.
+
 ### Performance
 
 - Use interned string to compare `style` element name.
+- Only check the value suffix for `!important`.
 
 ## [0.15.2] - 2025-06-24
 

css-inline/src/html/serializer.rs

@@ -495,7 +495,7 @@ fn merge_styles<Wr: Write>(
     // New rules will not override old ones unless they are marked as `!important`
     for (property, (_, value)) in new_styles {
         match (
-            value.strip_suffix("!important"),
+            value.trim_end().strip_suffix("!important"),
             declarations_buffer
                 .iter_mut()
                 .take(parsed_declarations_count)

css-inline/src/lib.rs

@@ -462,8 +462,8 @@ impl<'a> CSSInliner<'a> {
                             match element_styles.entry(name.as_ref()) {
                                 indexmap::map::Entry::Occupied(mut entry) => {
                                     match (
-                                        value.ends_with("!important"),
-                                        entry.get().1.ends_with("!important"),
+                                        value.trim_end().ends_with("!important"),
+                                        entry.get().1.trim_end().ends_with("!important"),
                                     ) {
                                         // Equal importance; the higher specificity wins.
                                         (false, false) | (true, true) => {

css-inline/tests/test_inlining.rs

@@ -246,6 +246,15 @@ fn important() {
     )
 }
 
+#[test]
+fn important_with_space_at_the_end() {
+    assert_inlined!(
+        style = "h1 { color: blue !important  ; }",
+        body = r#"<h1 style="color: red;">Big Text</h1>"#,
+        expected = r#"<h1 style="color: blue">Big Text</h1>"#
+    )
+}
+
 #[test]
 fn important_no_rule_exists() {
     // `!important` rules should override existing inline styles