Support HTTPS for https://json-schema.org/*

[Artifizer]

Right now the code supports only the following references:

"https://json-schema.org/draft/2020-12/schema"
"https://json-schema.org/draft/2019-09/schema"
"http://json-schema.org/draft-07/schema"
"http://json-schema.org/draft-06/schema"
"http://json-schema.org/draft-04/schema"

So that the idea is to support additionally:

"https://json-schema.org/draft-07/schema"
"https://json-schema.org/draft-06/schema"
"https://json-schema.org/draft-04/schema"

[Stranger6667]

Sure! I'll be happy to accept a PR for that - right now, unfortunately, I don't have much bandwidth

[Artifizer]

Sure! I'll be happy to accept a PR for that - right now, unfortunately, I don't have much bandwidth

I see that https:// is not a part of the standard for draft-04, draft-06, draft-07.
Would you still accept it?

[Artifizer]

The patch would be trivial though, I can make a PR:

diff --git a/crates/jsonschema-referencing/src/specification/mod.rs b/crates/jsonschema-referencing/src/specification/mod.rs
index bab4308..cda0730 100644
--- a/crates/jsonschema-referencing/src/specification/mod.rs
+++ b/crates/jsonschema-referencing/src/specification/mod.rs
@@ -52,12 +52,19 @@ impl Draft {
             .and_then(|contents| contents.get("$schema"))
             .and_then(|schema| schema.as_str())
         {
-            Ok(match schema.trim_end_matches('#') {
-                "https://json-schema.org/draft/2020-12/schema" => Draft::Draft202012,
-                "https://json-schema.org/draft/2019-09/schema" => Draft::Draft201909,
-                "http://json-schema.org/draft-07/schema" => Draft::Draft7,
-                "http://json-schema.org/draft-06/schema" => Draft::Draft6,
-                "http://json-schema.org/draft-04/schema" => Draft::Draft4,
+            let normalized = schema.trim_end_matches('#');
+            Ok(match normalized {
+                // Accept both HTTPS and HTTP for all known drafts
+                "https://json-schema.org/draft/2020-12/schema"
+                | "http://json-schema.org/draft/2020-12/schema" => Draft::Draft202012,
+                "https://json-schema.org/draft/2019-09/schema"
+                | "http://json-schema.org/draft/2019-09/schema" => Draft::Draft201909,
+                "https://json-schema.org/draft-07/schema"
+                | "http://json-schema.org/draft-07/schema" => Draft::Draft7,
+                "https://json-schema.org/draft-06/schema"
+                | "http://json-schema.org/draft-06/schema" => Draft::Draft6,
+                "https://json-schema.org/draft-04/schema"
+                | "http://json-schema.org/draft-04/schema" => Draft::Draft4,
                 value => return Err(Error::unknown_specification(value)),
             })
         } else {
@@ -199,8 +206,11 @@ mod tests {
     #[test_case(&json!({"$schema": "https://json-schema.org/draft/2020-12/schema#"}), Draft::Draft202012; "detect Draft 2020-12 with fragment")]
     #[test_case(&json!({"$schema": "https://json-schema.org/draft/2019-09/schema"}), Draft::Draft201909; "detect Draft 2019-09")]
     #[test_case(&json!({"$schema": "http://json-schema.org/draft-07/schema"}), Draft::Draft7; "detect Draft 7")]
+    #[test_case(&json!({"$schema": "https://json-schema.org/draft-07/schema"}), Draft::Draft7; "detect Draft 7 https")]
     #[test_case(&json!({"$schema": "http://json-schema.org/draft-06/schema"}), Draft::Draft6; "detect Draft 6")]
+    #[test_case(&json!({"$schema": "https://json-schema.org/draft-06/schema"}), Draft::Draft6; "detect Draft 6 https")]
     #[test_case(&json!({"$schema": "http://json-schema.org/draft-04/schema"}), Draft::Draft4; "detect Draft 4")]
+    #[test_case(&json!({"$schema": "https://json-schema.org/draft-04/schema"}), Draft::Draft4; "detect Draft 4 https")]
     #[test_case(&json!({}), Draft::Draft7; "default to Draft 7 when no $schema")]
     fn test_detect(contents: &serde_json::Value, expected: Draft) {
         let result = Draft::Draft7

[Stranger6667]

I see that https:// is not a part of the standard for draft-04, draft-06, draft-07.
Would you still accept it?

Yep! IIRC some of the other implementations made similar changes

[Artifizer]

I see that https:// is not a part of the standard for draft-04, draft-06, draft-07.
Would you still accept it?

Yep! IIRC some of the other implementations made similar changes

OK, #803

[eirnym]

Strictly speaking, these are IDs and not supposed to be URLs, you can fetch. The similar situation is with XML.

On the other hand, there's many scanners, which will complain on http urls.