Skip to content

Commit e96ee9f

Browse files
(#2) Fix ReSharper warnings
1 parent 6ec0d62 commit e96ee9f

File tree

6 files changed

+11
-12
lines changed

6 files changed

+11
-12
lines changed

release-notes/wip-release-notes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Date: ???
1111
### Miscellaneous
1212

1313
- #1: Initial set up
14+
- #2: Create the initial provider
1415

1516
### Dependabot
1617

src/Example/MyFeatureConfiguration.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ namespace Example;
22

33
public class MyFeatureConfiguration
44
{
5-
public int SomeNumber { get; set; }
5+
public int? SomeNumber { get; set; }
66

7-
public string SomeString { get; set; }
7+
public string? SomeString { get; set; }
88

9-
public double SomeFloatingPointNumber { get; set; }
9+
public double? SomeFloatingPointNumber { get; set; }
1010

11-
public bool SomeBoolean { get; set; }
11+
public bool? SomeBoolean { get; set; }
1212
}

src/Example/TheHostedService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public TheHostedService(
3434
_featureValues = featureValues;
3535
_timer = new Timer(10000);
3636
_timer.Elapsed += TimerOnElapsed;
37-
featureValues.OnChange((v, s) =>
37+
featureValues.OnChange((_, s) =>
3838
{
3939
Console.WriteLine($"[{DateTime.Now:HH:mm:ss}] Change Detected. {s}");
4040
});

src/Stravaig.Configuration.SqlServer.Tests/UnitTest1.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
using System.Collections.Generic;
2-
using Microsoft.Extensions.Configuration;
3-
using Microsoft.Extensions.Hosting;
42
using NUnit.Framework;
53
using Shouldly;
64

src/Stravaig.Configuration.SqlServer/DataLoader.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ public interface IDataLoader
1010
public class DataLoader : IDataLoader
1111
{
1212
private const string RetrieveSqlTemplate = "SELECT [ConfigKey], [ConfigValue] FROM [{0}].[{1}]";
13-
private const int keyColumnPosition = 0;
14-
private const int valueColumnPosition = 1;
13+
private const int KeyColumnPosition = 0;
14+
private const int ValueColumnPosition = 1;
1515

1616
public IEnumerable<KeyValuePair<string, string>> RetrieveData(SqlServerConfigurationSource source)
1717
{
@@ -22,8 +22,8 @@ public IEnumerable<KeyValuePair<string, string>> RetrieveData(SqlServerConfigura
2222
using var reader = cmd.ExecuteReader();
2323
while (reader.Read())
2424
{
25-
var key = reader.GetString(keyColumnPosition);
26-
var value = reader.GetString(valueColumnPosition);
25+
var key = reader.GetString(KeyColumnPosition);
26+
var value = reader.GetString(ValueColumnPosition);
2727
yield return new KeyValuePair<string, string>(key, value);
2828
}
2929
}

version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.4.1
1+
0.1.0

0 commit comments

Comments
 (0)