#111: Provide an opt out for using dots in structured logging keys

Author: colinangusmackay

src/.editorconfig

@@ -16,7 +16,7 @@ guidelines=80 1px dotted 80FF00FF, 100 1px dashed B0FF0000, 120 2px solid FFFF00
 csharp_new_line_before_members_in_object_initializers=false
 csharp_preferred_modifier_order=public, private, protected, internal, new, abstract, virtual, sealed, override, static, readonly, extern, unsafe, volatile, async:suggestion
 csharp_style_var_elsewhere=true:suggestion
-csharp_style_var_for_built_in_types=true:suggestion
+csharp_style_var_for_built_in_types=false
 csharp_style_var_when_type_is_apparent=true:suggestion
 dotnet_style_parentheses_in_arithmetic_binary_operators=never_if_unnecessary:none
 dotnet_style_parentheses_in_other_binary_operators=never_if_unnecessary:none

src/Stravaig.Configuration.Diagnostics.Core/Renderers/Renderer.cs

@@ -8,6 +8,8 @@ namespace Stravaig.Configuration.Diagnostics.Renderers
     public abstract class Renderer
     {
         private const string PlaceholderPartJoin = "_";
+
+        private bool _convertDotToUnderscore = false;
 
         /// <summary>
         /// Creates a safely named placeholder for use in structured renderers.
@@ -17,9 +19,9 @@ public abstract class Renderer
         protected string Placeholder(params string[] parts)
         {
             StringBuilder placeholderBuilder = new StringBuilder();
-            placeholderBuilder.Append("{");
+            placeholderBuilder.Append('{');
             int partPos = 0;
-            foreach (var part in parts)
+            foreach (string part in parts)
             {
                 if (string.IsNullOrWhiteSpace(part))
                     continue;
@@ -31,18 +33,20 @@ protected string Placeholder(params string[] parts)
                 foreach (char character in part)
                 {
                     if (charPos == 0 && character >= '0' && character <= '9')
-                        placeholderBuilder.Append("_");
-                    if (char.IsLetterOrDigit(character) || character == '.')
+                        placeholderBuilder.Append('_');
+                    if (char.IsLetterOrDigit(character))
                         placeholderBuilder.Append(character);
+                    if (character == '.')
+                        placeholderBuilder.Append(_convertDotToUnderscore ? '_' : '.');
                     else
-                        placeholderBuilder.Append("_");
+                        placeholderBuilder.Append('_');
                     charPos++;
                 }
 
                 partPos++;
             }
 
-            placeholderBuilder.Append("}");
+            placeholderBuilder.Append('}');
             return placeholderBuilder.ToString();
         }
     }