#111: Write tests that demonstrate the bug

Author: colinangusmackay

src/Stravaig.Configuration.Diagnostics.Tests/RegressionTests/DotsBugLoggerExtensionTests.cs

@@ -0,0 +1,39 @@
+using System;
+using System.Collections.Generic;
+using Microsoft.Extensions.Configuration;
+using NUnit.Framework;
+using Shouldly;
+using Stravaig.Configuration.Diagnostics.Logging;
+
+namespace Stravaig.Extensions.Configuration.Diagnostics.Tests.RegressionTests
+{
+    [TestFixture]
+    public class DotsBugLoggerExtensionTests : LoggerExtensionsTestBase
+    {
+        [Test]
+        public void ConfigElementsWithDotsShouldRenderPropertiesInMessage()
+        {
+            SetupConfig(c =>
+            {
+                c.AddInMemoryCollection(new[]
+                {
+                    new KeyValuePair<string, string>("ItemA", "Alpha"),
+                    new KeyValuePair<string, string>("ItemB", "Beta"),
+                    new KeyValuePair<string, string>("ItemB.A", "Beta-Alpha"),
+                    new KeyValuePair<string, string>("ItemC", "Gamma"),
+                });
+            });
+            SetupLogger();
+
+            Logger.LogConfigurationValuesAsInformation(ConfigRoot);
+
+            var logs = GetLogs();
+            logs.Count.ShouldBe(1);
+            var log = logs[0];
+            log.FormattedMessage.ShouldContain("ItemC : Gamma");
+            log.FormattedMessage.ShouldContain("ItemB.A : Beta-Alpha");
+            log.FormattedMessage.ShouldContain("ItemB : Beta");
+            log.FormattedMessage.ShouldContain("ItemA : Alpha");
+        }
+    }
+}

src/Stravaig.Configuration.Diagnostics.Tests/RegressionTests/DotsBugSerilog.cs

@@ -0,0 +1,45 @@
+using System;
+using System.Collections.Generic;
+using Microsoft.Extensions.Configuration;
+using Newtonsoft.Json.Linq;
+using NUnit.Framework;
+using Shouldly;
+using Stravaig.Configuration.Diagnostics.Serilog;
+using Stravaig.Extensions.Configuration.Diagnostics.Tests.__Extensions;
+
+namespace Stravaig.Extensions.Configuration.Diagnostics.Tests.RegressionTests
+{
+    [TestFixture]
+    public class DotsBugSerilog : SerilogTestBase
+    {
+        [Test]
+        public void ConfigElementsWithDotsShouldRenderPropertiesInMessage()
+        {
+            SetupConfig(c =>
+            {
+                c.AddInMemoryCollection(new[]
+                {
+                    new KeyValuePair<string, string>("ItemA", "Alpha"),
+                    new KeyValuePair<string, string>("ItemB", "Beta"),
+                    new KeyValuePair<string, string>("ItemB.A", "Beta-Alpha"),
+                    new KeyValuePair<string, string>("ItemC", "Gamma"),
+                });
+            });
+            SetupLogger(true);
+
+            Logger.LogConfigurationValuesAsInformation(ConfigRoot);
+
+            var logs = GetLogs();
+            logs.Count.ShouldBe(1);
+            var log = logs[0];
+            
+            Console.WriteLine(log.GetMessage());
+            Console.WriteLine(log.GetMessageTemplate());            
+            
+            log.GetMessage().ShouldContain("ItemC : \"Gamma\"");
+            log.GetMessage().ShouldContain("ItemB.A : \"Beta-Alpha\"");
+            log.GetMessage().ShouldContain("ItemB : \"Beta\"");
+            log.GetMessage().ShouldContain("ItemA : \"Alpha\"");
+        }
+    }
+}

src/Stravaig.Configuration.Diagnostics.Tests/SerilogTestBase.cs

@@ -16,13 +16,16 @@ public abstract class SerilogTestBase : TestBase
         protected ILogger Logger;
         private StringBuilder _logStringBuilder;
         private TextWriter _logTextWriter;
-        protected void SetupLogger()
+        protected void SetupLogger(bool writeToConsole = false)
         {
             _logStringBuilder = new StringBuilder();
             _logTextWriter = new StringWriter(_logStringBuilder);
-            Logger = new LoggerConfiguration()
+            var loggerConfiguration = new LoggerConfiguration()
                 .WriteTo.TextWriter(new JsonFormatter(renderMessage: true), _logTextWriter)
-                .MinimumLevel.Verbose()
+                .MinimumLevel.Verbose();
+            if (writeToConsole)
+                loggerConfiguration = loggerConfiguration.WriteTo.Console();
+            Logger = loggerConfiguration
                 .CreateLogger();
         }