Remove opt-out - always use underscore in logging key.

Author: colinangusmackay

release-notes/wip-release-notes.md

@@ -6,6 +6,8 @@ Date: ???
 
 ### Bugs
 
+- #111: Dots also get converted to underlines in structured keys.
+
 ### Features
 
 ### Miscellaneous

src/Stravaig.Configuration.Diagnostics.Core/Renderers/Renderer.cs

@@ -9,8 +9,6 @@ public abstract class Renderer
     {
         private const string PlaceholderPartJoin = "_";
 
-        private bool _convertDotToUnderscore = false;
-        
         /// <summary>
         /// Creates a safely named placeholder for use in structured renderers.
         /// </summary>
@@ -34,12 +32,10 @@ protected string Placeholder(params string[] parts)
                 {
                     if (charPos == 0 && character >= '0' && character <= '9')
                         placeholderBuilder.Append('_');
-                    if (char.IsLetterOrDigit(character))
-                        placeholderBuilder.Append(character);
-                    if (character == '.')
-                        placeholderBuilder.Append(_convertDotToUnderscore ? '_' : '.');
-                    else
-                        placeholderBuilder.Append('_');
+                    placeholderBuilder.Append(
+                        char.IsLetterOrDigit(character)
+                            ? character
+                            : '_');
                     charPos++;
                 }