(#123) Improve code coverage for new code

Author: colinangusmackay

src/Stravaig.Extensions.Logging.Diagnostics.Tests/TestCaptureLoggerOfTTests.cs

@@ -0,0 +1,55 @@
+using System;
+using Microsoft.Extensions.Logging;
+using NUnit.Framework;
+using Shouldly;
+
+namespace Stravaig.Extensions.Logging.Diagnostics.Tests;
+
+[TestFixture]
+public class TestCaptureLoggerOfTTests
+{
+    [Test]
+    public void CategoryNameIsBasedOnType()
+    {
+        var logger = new TestCaptureLogger<TestCaptureLoggerOfTTests>();
+        logger.CategoryName.ShouldBe(GetType().FullName);
+    }
+
+    [Test]
+    [TestCase(LogLevel.Trace)]
+    [TestCase(LogLevel.Debug)]
+    [TestCase(LogLevel.Information)]
+    [TestCase(LogLevel.Warning)]
+    [TestCase(LogLevel.Error)]
+    [TestCase(LogLevel.Critical)]
+    public void IsEnabledTests(LogLevel level)
+    {
+        var logger = new TestCaptureLogger<TestCaptureLoggerOfTTests>();
+        logger.IsEnabled(level).ShouldBeTrue();
+    }
+
+    [Test]
+    public void ResetRemovesCapturedLogs()
+    {
+        var logger = new TestCaptureLogger<TestCaptureLoggerOfTTests>();
+        logger.LogInformation("Hello");
+        logger.LogWarning("World");
+        logger.GetLogs().Count.ShouldBe(2);
+
+        logger.Reset();
+        logger.GetLogs().Count.ShouldBe(0);
+    }
+
+    [Test]
+    public void GetLogsWithExceptionsWillFilterOutNonExceptionLogs()
+    {
+        var logger = new TestCaptureLogger<TestCaptureLoggerOfTTests>();
+        logger.LogInformation("Hello");
+        logger.LogWarning(new Exception(), "World");
+        logger.LogInformation("This is a log.");
+        logger.LogError(new Exception(), "This has an exception.");
+
+        logger.GetLogEntriesWithExceptions().Count.ShouldBe(2);
+        logger.GetLogs().Count.ShouldBe(4);
+    }
+}

src/Stravaig.Extensions.Logging.Diagnostics.Tests/TestCaptureLoggerTests.cs

@@ -3,27 +3,26 @@
 using NUnit.Framework;
 using Shouldly;
 
-namespace Stravaig.Extensions.Logging.Diagnostics.Tests
+namespace Stravaig.Extensions.Logging.Diagnostics.Tests;
+
+[TestFixture]
+public class TestCaptureLoggerTests
 {
-    [TestFixture]
-    public class TestCaptureLoggerTests
+    [Test]
+    public void LogsWithExceptionOnlyReturnsLogsWithAnExceptionObjectAttached()
     {
-        [Test]
-        public void LogsWithExceptionOnlyReturnsLogsWithAnExceptionObjectAttached()
-        {
-            var logger = new TestCaptureLogger();
-            
-            logger.LogInformation("One");
-            logger.LogWarning(new Exception("I'm an exception"), "Two");
-            logger.LogError(new ApplicationException("I'm an application exception"), "Three");
-            logger.LogError("Four");
-            logger.LogCritical(new InvalidOperationException("I'm an invalid operation exception"), "Five");
+        var logger = new TestCaptureLogger();
+
+        logger.LogInformation("One");
+        logger.LogWarning(new Exception("I'm an exception"), "Two");
+        logger.LogError(new ApplicationException("I'm an application exception"), "Three");
+        logger.LogError("Four");
+        logger.LogCritical(new InvalidOperationException("I'm an invalid operation exception"), "Five");
 
-            var logsWithExceptions = logger.GetLogEntriesWithExceptions();
-            logsWithExceptions.Count.ShouldBe(3);
-            logsWithExceptions[0].OriginalMessage.ShouldBe("Two");
-            logsWithExceptions[1].OriginalMessage.ShouldBe("Three");
-            logsWithExceptions[2].OriginalMessage.ShouldBe("Five");
-        }
+        var logsWithExceptions = logger.GetLogEntriesWithExceptions();
+        logsWithExceptions.Count.ShouldBe(3);
+        logsWithExceptions[0].OriginalMessage.ShouldBe("Two");
+        logsWithExceptions[1].OriginalMessage.ShouldBe("Three");
+        logsWithExceptions[2].OriginalMessage.ShouldBe("Five");
     }
-}
+}

src/Stravaig.Extensions.Logging.Diagnostics.sln.DotSettings

@@ -1,4 +1,5 @@
 <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=LogMessageIsSentenceProblem/@EntryIndexedValue">DO_NOT_SHOW</s:String>
 	<s:Boolean x:Key="/Default/CodeInspection/Highlighting/RunLongAnalysisInSwa/@EntryValue">True</s:Boolean>
 	<s:String x:Key="/Default/CodeInspection/Highlighting/SweaWarningsMode/@EntryValue">ShowAndRun</s:String>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Shouldly/@EntryIndexedValue">True</s:Boolean>