Refactor out repeated code in unit tests

Author: colinangusmackay

src/Stravaig.ShortCode.Tests/CodeGeneratorTestsBase.cs

@@ -4,25 +4,23 @@
 using System.Linq;
 using System.Runtime.CompilerServices;
 using System.Threading.Tasks;
+using NUnit.Framework;
 using Shouldly;
 
 namespace Stravaig.ShortCode.Tests
 {
-    public class CodeGeneratorTestsBase
+    public abstract class CodeGeneratorTestsBase
     {
+        private const int ShortRunSize = 1024 * 4;
         private const int RunSize = 1024 * 1024 * 4;
+
+        protected abstract IShortCodeGenerator GetGenerator([CallerMemberName] string testName = null);
 
-        private void GenerateLots(IShortCodeGenerator gen, ulong[] result)
-        {
-            int count = result.Length;
-            for (int i = 0; i < count; i++)
-            {
-                result[i] = gen.GetNextCode();
-            }
-        }
-        
-        protected void MultiThreadStressTest(IShortCodeGenerator gen)
+        [Test]
+        [Category("LongStressTest")]
+        public void MultiThreadStressTest()
         {
+            var gen = GetGenerator();            
             var threadCount = Environment.ProcessorCount * 2;
             var tasks = new List<Task<ulong[]>>(threadCount);
             for (int i = 0; i < threadCount; i++)
@@ -52,15 +50,30 @@ protected void MultiThreadStressTest(IShortCodeGenerator gen)
             CheckAccuracy(allResults);
         }
 
-        protected void SingleThreadStressTest(IShortCodeGenerator gen)
+        [Test]
+        [Category("LongStressTest")]
+        public void SingleThreadStressTest()
         {
+            var gen = GetGenerator();
             var result = new ulong[RunSize];
+            SingleThreadStressTestImpl(gen, result);
+        }
+
+        [Test]
+        public void ShortSingleThreadStressTest()
+        {
+            var gen = GetGenerator();
+            var result = new ulong[ShortRunSize];
+            SingleThreadStressTestImpl(gen, result);
+        }
+
+        private void SingleThreadStressTestImpl(IShortCodeGenerator gen, ulong[] result)
+        {
             Stopwatch sw = new Stopwatch();
             sw.Start();
             GenerateLots(gen, result);
             sw.Stop();
             ResultReadOut(result.Length, sw);
-
             CheckAccuracy(result);
         }
 
@@ -74,6 +87,15 @@ private static void CheckAccuracy(IEnumerable<ulong> result)
             distinctCount.ShouldBe(totalCount);
         }
 
+        private void GenerateLots(IShortCodeGenerator gen, ulong[] result)
+        {
+            int count = result.Length;
+            for (int i = 0; i < count; i++)
+            {
+                result[i] = gen.GetNextCode();
+            }
+        }
+
         private void ResultReadOut(int totalCount, Stopwatch sw, int? index = null, [CallerMemberName]string caller = null)
         {
             var elapsedMs = (double)sw.ElapsedMilliseconds;

src/Stravaig.ShortCode.Tests/CryptographicallyRandomCodeGeneratorTests.cs

@@ -1,23 +1,14 @@
+using System.Runtime.CompilerServices;
 using NUnit.Framework;
 
 namespace Stravaig.ShortCode.Tests
 {
     [TestFixture]
     public class CryptographicallyRandomCodeGeneratorTests : CodeGeneratorTestsBase
     {
-        [Test]
-        public void SingleThreadStressTest()
+        protected override IShortCodeGenerator GetGenerator([CallerMemberName]string testName = null)
         {
-            var gen = new CryptographicallyRandomCodeGenerator();
-            SingleThreadStressTest(gen);
-        }
-
-        [Test]
-        [Category("LongStressTest")]
-        public void MultiThreadStressTest()
-        {
-            var gen = new CryptographicallyRandomCodeGenerator();
-            MultiThreadStressTest(gen);
+            return new CryptographicallyRandomCodeGenerator();
         }
     }
 }

src/Stravaig.ShortCode.Tests/GuidCodeGeneratorTests.cs

@@ -5,19 +5,9 @@ namespace Stravaig.ShortCode.Tests
     [TestFixture]
     public class GuidCodeGeneratorTests : CodeGeneratorTestsBase
     {
-        [Test]
-        public void SingleThreadStressTest()
+        protected override IShortCodeGenerator GetGenerator(string testName = null)
         {
-            var gen = new GuidCodeGenerator();
-            SingleThreadStressTest(gen);
-        }
-
-        [Test]
-        [Category("LongStressTest")]
-        public void MultiThreadStressTest()
-        {
-            var gen = new GuidCodeGenerator();
-            MultiThreadStressTest(gen);
+            return new GuidCodeGenerator();
         }
     }
 }

src/Stravaig.ShortCode.Tests/RandomCodeGeneratorTests.cs

@@ -5,19 +5,9 @@ namespace Stravaig.ShortCode.Tests
     [TestFixture]
     public class RandomCodeGeneratorTests : CodeGeneratorTestsBase
     {
-        [Test]
-        public void SingleThreadStressTest()
+        protected override IShortCodeGenerator GetGenerator(string testName = null)
         {
-            var gen = new RandomCodeGenerator();
-            SingleThreadStressTest(gen);
-        }
-
-        [Test]
-        [Category("LongStressTest")]
-        public void MultiThreadStressTest()
-        {
-            var gen = new RandomCodeGenerator();
-            MultiThreadStressTest(gen);
+            return new RandomCodeGenerator();
         }
     }
 }

src/Stravaig.ShortCode.Tests/SequentialCodeGeneratorTests.cs

@@ -15,19 +15,9 @@ public void SeedZero_GetNextCode_IncrementsByOneEachTime()
             gen.GetNextCode().ShouldBe(3UL);
         }
 
-        [Test]
-        public void SingleThreadStressTest()
+        protected override IShortCodeGenerator GetGenerator(string testName = null)
         {
-            var gen = new SequentialCodeGenerator(0);
-            SingleThreadStressTest(gen);
-        }
-
-        [Test]
-        [Category("LongStressTest")]
-        public void MultiThreadStressTest()
-        {
-            var gen = new SequentialCodeGenerator(0);
-            MultiThreadStressTest(gen);
+            return new SequentialCodeGenerator(0);
         }
     }
 }