Skip to content

Commit 6bf3e50

Browse files
Remove unused method RangeRequired
1 parent ef7ee5e commit 6bf3e50

File tree

6 files changed

+1
-35
lines changed

6 files changed

+1
-35
lines changed

src/Stravaig.ShortCode.Benchmarks/Variants/Encoder1.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ public string Convert(ulong fullCode, int? fixedChars = null, int maxChars = int
2929
return result.ToString();
3030
}
3131

32-
public ulong RangeRequired(int numChars)
33-
{
34-
return (ulong)Math.Pow(_characterSpace.Length, numChars);
35-
}
36-
3732
public int MaxLength()
3833
{
3934
return (int)(Math.Log(ulong.MaxValue) / Math.Log(_characterSpace.Length));

src/Stravaig.ShortCode.Benchmarks/Variants/Encoder2.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ public string Convert(ulong fullCode, int? fixedChars = null, int maxChars = 64)
2828
return new String(resultChars, 0, index);
2929
}
3030

31-
public ulong RangeRequired(int numChars)
32-
{
33-
return (ulong)Math.Pow(_characterSpace.Length, numChars);
34-
}
35-
3631
public int MaxLength()
3732
{
3833
return (int)(Math.Log(ulong.MaxValue) / Math.Log(_characterSpace.Length));

src/Stravaig.ShortCode.Tests/EncoderTests.cs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,6 @@ public void Ctor_WithSingleCharacter()
2525
ex.Message.ShouldStartWith("Value cannot have a single character.");
2626
}
2727

28-
[TestCase(1, NamedCharacterSpaces.Digits, ExpectedResult = (ulong)10)]
29-
[TestCase(2, NamedCharacterSpaces.Digits, ExpectedResult = (ulong)100)]
30-
[TestCase(1, NamedCharacterSpaces.LowerLatinLetters, ExpectedResult = (ulong)26)]
31-
[TestCase(2, NamedCharacterSpaces.LowerLatinLetters, ExpectedResult = (ulong)676)]
32-
[TestCase(3, NamedCharacterSpaces.LatinLetters, ExpectedResult = (ulong)140608)]
33-
[TestCase(4, NamedCharacterSpaces.LettersAndDigits, ExpectedResult = (ulong)14776336)]
34-
[TestCase(5, NamedCharacterSpaces.LettersAndDigits, ExpectedResult = (ulong)916132832)]
35-
public ulong RangeRequiredReturnsGoodValueForCharacterSpace(int numChars, string charSpace)
36-
{
37-
var characterSpace = new Encoder(charSpace);
38-
return characterSpace.RangeRequired(numChars);
39-
}
40-
4128
[TestCase(NamedCharacterSpaces.LettersAndDigits, ExpectedResult = 10)]
4229
[TestCase(NamedCharacterSpaces.Digits, ExpectedResult = 19)]
4330
public int MaxLengthTests(string charSpace)

src/Stravaig.ShortCode/Encoder.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,7 @@ public string Convert(ulong fullCode, int? fixedChars = null, int maxChars = 64)
2929

3030
return new String(resultChars, 0, index);
3131
}
32-
33-
public ulong RangeRequired(int numChars)
34-
{
35-
return (ulong)Math.Pow(_characterSpace.Length, numChars);
36-
}
37-
32+
3833
public int MaxLength()
3934
{
4035
return (int)(Math.Log(ulong.MaxValue) / Math.Log(_characterSpace.Length));

src/Stravaig.ShortCode/IEncoder.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ namespace Stravaig.ShortCode
33
public interface IEncoder
44
{
55
string Convert(ulong fullCode, int? fixedChars = null, int maxChars = int.MaxValue);
6-
ulong RangeRequired(int numChars);
76
int MaxLength();
87

98
string NamedCharacterSpace { get; }

src/Stravaig.ShortCode/PatternedEncoder.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@ private ulong BuildShortCode(ulong fullCode, PatternPart part, char[] code, int
5353
return fullCode;
5454
}
5555

56-
public ulong RangeRequired(int numChars)
57-
{
58-
throw new NotImplementedException();
59-
}
60-
6156
public int MaxLength()
6257
{
6358
throw new NotImplementedException();

0 commit comments

Comments
 (0)