Skip to content

Commit ec55cb5

Browse files
authored
Merge pull request #55 from StrawberryPerl/mod_install_log_names
git ignore, module names and INST_VER
2 parents 7a0356c + 327af01 commit ec55cb5

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed

.gitignore

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ pod.raw*
1515
_internal
1616
META.yml
1717
MYMETA.yml
18-
MANIFEST
19-
/META.json
20-
/MYMETA.json
18+
MANIFEST
19+
/META.json
20+
/MYMETA.json
21+
22+
*.iml
23+
/.idea/

lib/Perl/Dist/Strawberry/Step.pm

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -420,9 +420,9 @@ sub _install_module {
420420
$shortname =~ s|[\\/]+|_|g;
421421
$shortname =~ s/\.(tar\.gz|tar\.bz2|zip|tar|gz)$//;
422422
my $script_pl = $self->boss->resolve_name("<dist_sharedir>/utils/CPANMINUS_install_module.pl");
423-
my $log = catfile($self->global->{debug_dir}, "mod_install_".$now."_".$shortname.".log.txt");
424-
my $dumper_file = catfile($self->global->{debug_dir}, "mod_install_".$now."_".$shortname.".list.dumper.txt");
425-
my $nstore_file = catfile($self->global->{debug_dir}, "mod_install_".$now."_".$shortname.".list.nstore.txt");
423+
my $log = catfile($self->global->{debug_dir}, "mod_install_${shortname}_${now}.log.txt");
424+
my $dumper_file = catfile($self->global->{debug_dir}, "mod_install_${shortname}_${now}.list.dumper.txt");
425+
my $nstore_file = catfile($self->global->{debug_dir}, "mod_install_${shortname}_${now}.list.nstore.txt");
426426

427427
my $env = {
428428
PERL_MM_USE_DEFAULT=>1, AUTOMATED_TESTING=>undef, RELEASE_TESTING=>undef,

lib/Perl/Dist/Strawberry/Step/InstallPerlCore.pm

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,12 @@ sub run {
5252
}
5353
die "ERROR: cannot detect perl-src dir" unless $perlsrc;
5454

55-
#get verion string - e.g. '5.15.9'
56-
my ($version) = grep { /INST_VER/ } read_file(catfile($unpack_to, $perlsrc, qw/win32 makefile.mk/));
55+
#get version string - e.g. '5.15.9'
56+
my $file_to_check = catfile($unpack_to, $perlsrc, qw/win32 makefile.mk/);
57+
if (!-e $file_to_check) {
58+
$file_to_check = catfile($unpack_to, $perlsrc, qw/win32 GNUMakefile/);
59+
}
60+
my ($version) = grep { /INST_VER/ } read_file($file_to_check);
5761
$version =~ s/^.*?(5\..*?)[\r\n]*$/$1/;
5862

5963
# some handy variables

0 commit comments

Comments
 (0)