Skip to content

Commit fbc2693

Browse files
committed
Log when a check is disabled and thus skipped
Includes a refactor of the relevant loop.
1 parent b54d7e0 commit fbc2693

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

lib/Perl/Dist/Strawberry.pm

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,21 @@ sub do_job {
119119

120120
#check
121121
$self->message(0, "starting global check");
122-
$i = 0;
123-
for (@{$self->{build_job_steps}}) {
124-
$self->message(1, "checking [step:$i] ".ref($_));
125-
$_->check unless $_->{data}->{done} || $_->{config}->{disable}; # dies on error
122+
$i = -1;
123+
STEP:
124+
for my $step (@{$self->{build_job_steps}}) {
126125
$i++;
126+
my $msg = "checking [step:$i] ".ref($_);
127+
if ($step->{config}->{disable}) {
128+
$msg .= " (disabled, skipping check)";
129+
$self->message(1, $msg);
130+
next STEP;
131+
}
132+
$self->message(1, $msg);
133+
134+
next STEP if $step->{data}->{done};
135+
136+
$step->check; # dies on error
127137
};
128138

129139
#run

0 commit comments

Comments
 (0)