perl 5.40.1 build: Possibly Error test t/08warndie.t will fail

[twata1]

Hello,

I split my issue with #231 .

Sample fail report:
http://www.cpantesters.org/cpan/report/faab977f-6d26-1014-8029-a7def125e0a9

That test passes in perl 5.40.0 build .

Thank you,

[sisyphus]

Which module was it that produced http://www.cpantesters.org/cpan/report/faab977f-6d26-1014-8029-a7def125e0a9 ?
I can't see any mention of that anywhere in the report.

[twata1]

The module that is failing the test is a module called Error.
The log is also attached.
build-on-SP-5.40.1.log

Relevant part of the log:

t/07try-in-obj-destructor.t .......... ok
t/08warndie.t ........................ 
Dubious, test returned 5 (wstat 1280, 0x500)
Failed 20/21 subtests 
t/09dollar-at.t ...................... ok

[shawnlaffan]

Also fails on perl 5.41.3 built using visual studio so is perhaps not a strawberry specific issue.

This also looks similar to Test::Trap, reported in #231 (comment)

Has anything been backported that changes stack behaviour?

[bekuno]

The Error distribution had a new version on 2025-02-18.
From the release notes:

    - Fix die/warn hooks for perl 5.41.9 changes
        - https://github.com/shlomif/perl-error.pm/pull/4
        - Thanks @mauke .

The passed test on 5.40.0 are problably done with version 0.17029 of the module Error.

@shlomif @mauke
Can you cross check, please?

[sisyphus]

The passed test on 5.40.0 are probably done with version 0.17029 of the module

I'm seeing the same issue with 0.17030.
I've created a BBC ticket at Perl/perl5#23022 .

[shawnlaffan]

This now passes with the beta release of SP 5.40.2.1. That build patches in most of Perl/perl5#23179

I'll do the same for 5.38.4.1 when it is built.

I'll leave this open until the final releases are out.

[shawnlaffan]

Patching the 5.38.4.1 build with a modified version of Perl/perl5#23179 causes the perl build to fail. The patch seems to apply cleanly but with large offsets so might need to be reworked for 5.38.

I have it disabled for now, which means the Error module continues to fail with 5.38.4.1.

[shawnlaffan]

The patch file is at https://github.com/StrawberryPerl/Perl-Dist-Strawberry/blob/sp5.40.1/share/perl-5.40/gh23179_no_delta.patch
scope_types.h was regenerated after the patch was applied and is part of 1d9f293

Perl build error is

C:/strawberry/c/bin/../lib/gcc/x86_64-w64-mingw32/13.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: mini\scope.o:scope.c:(.text+0x18f8): undefined reference to `Perl_release_RExC_state'
collect2.exe: error: ld returned 1 exit status
gmake: *** [GNUmakefile:1226: ..\lib\buildcustomize.pl] Error 1

Patch log is:

patching file embed.fnc
Hunk #1 succeeded at 2714 (offset -77 lines).
Hunk #2 succeeded at 2725 with fuzz 1 (offset -77 lines).
patching file embed.h
Hunk #1 succeeded at 1051 (offset -149 lines).
patching file proto.h
Hunk #1 succeeded at 3891 with fuzz 2 (offset -2 lines).
patching file regcomp.c
Hunk #1 succeeded at 1211 with fuzz 1 (offset -145 lines).
Hunk #2 succeeded at 1233 (offset -145 lines).
Hunk #3 succeeded at 1336 (offset -145 lines).
patching file regen/scope_types.pl
patching file scope.c
Hunk #1 succeeded at 1372 (offset -19 lines).
patching file scope.h
patching file sv.c
Hunk #1 succeeded at 15366 (offset -149 lines).
patching file regcomp.c
Hunk #1 succeeded at 1336 (offset -145 lines).
Hunk #2 succeeded at 1433 (offset -146 lines).
Hunk #3 succeeded at 1450 (offset -146 lines).
Hunk #4 succeeded at 1502 (offset -146 lines).
Hunk #5 succeeded at 2337 (offset -146 lines).

[shawnlaffan]

Removing the #ifdef PERL_RE_BUILD_AUX ... #endif conditional from the patch gets the build past that point. Presumably PERL_RE_BUILD_AUX is a 5.40 thing.

Perl-Dist-Strawberry/share/perl-5.40/gh23179_no_delta.patch

Line 92 in 1d9f293

+#ifdef PERL_RE_BUILD_AUX

[shawnlaffan]

The relevant patches are included in the recent SP releases. Closing issue now.