Merge pull request #59 from StreetSupport/fix/remove_todos

Remove TODOs

Author: o-seliuchenko

src/constants/roles.ts

@@ -80,26 +80,6 @@ export function isOrgSpecificRole(role: string): boolean {
   return role.startsWith(ROLE_PREFIXES.ADMIN_FOR);
 }
 
-// TODO: remove it if we don't need it
-/**
- * Extract the location/org slug from a specific role
- * @example extractRoleSlug('CityAdminFor:birmingham') => 'birmingham'
- */
-// export function extractRoleSlug(role: string): string | null {
-//   if (isLocationSpecificRole(role)) {
-//     if (role.startsWith(ROLE_PREFIXES.CITY_ADMIN_FOR)) {
-//       return role.substring(ROLE_PREFIXES.CITY_ADMIN_FOR.length);
-//     }
-//     if (role.startsWith(ROLE_PREFIXES.SWEP_ADMIN_FOR)) {
-//       return role.substring(ROLE_PREFIXES.SWEP_ADMIN_FOR.length);
-//     }
-//   }
-//   if (isOrgSpecificRole(role)) {
-//     return role.substring(ROLE_PREFIXES.ADMIN_FOR.length);
-//   }
-//   return null;
-// }
-
 /**
  * Create a location-specific city admin role
  * @example createCityAdminRole('birmingham') => 'CityAdminFor:birmingham'
@@ -116,15 +96,6 @@ export function createSwepAdminRole(locationSlug: string): string {
   return `${ROLE_PREFIXES.SWEP_ADMIN_FOR}${locationSlug}`;
 }
 
-// TODO: remove it if we don't need it
-/**
- * Create an org-specific admin role
- * @example createOrgAdminRole('org-slug') => 'AdminFor:org-slug'
- */
-// export function createOrgAdminRole(orgSlug: string): string {
-//   return `${ROLE_PREFIXES.ADMIN_FOR}${orgSlug}`;
-// }
-
 /**
  * Validate if a role string matches the expected format
  */
@@ -144,30 +115,6 @@ export function isValidRole(role: string): boolean {
   return rolePatterns.some(pattern => pattern.test(role));
 }
 
-// TODO: remove it if we don't need it
-/**
- * Get all roles from a user's auth claims (base roles only)
- */
-// export function getBaseRoles(authClaims: string[]): BaseRole[] {
-//   return authClaims.filter(isBaseRole);
-// }
-
-// TODO: remove it if we don't need it
-/**
- * Get all location-specific roles from auth claims
- */
-export function getLocationSpecificRoles(authClaims: string[]): string[] {
-  return authClaims.filter(isLocationSpecificRole);
-}
-
-// TODO: remove it if we don't need it
-/**
- * Get all org-specific roles from auth claims
- */
-// export function getOrgSpecificRoles(authClaims: string[]): string[] {
-//   return authClaims.filter(isOrgSpecificRole);
-// }
-
 /**
  * Check if user has a specific base role
  */
@@ -203,27 +150,6 @@ export function hasLocationAccess(authClaims: string[], locationSlug: string): b
   return authClaims.includes(cityAdminRole) || authClaims.includes(swepAdminRole);
 }
 
-
-// TODO: remove it if we don't need it
-/**
- * Check if user has access to a specific organisation
- */
-// export function hasOrgAccess(authClaims: string[], orgSlug: string): boolean {
-//   // SuperAdmin has access to all organisations
-//   if (isSuperAdmin(authClaims)) {
-//     return true;
-//   }
-  
-//   // Check for general OrgAdmin role
-//   if (hasRole(authClaims, ROLES.ORG_ADMIN)) {
-//     return true;
-//   }
-  
-//   // Check for org-specific role
-//   const orgAdminRole = createOrgAdminRole(orgSlug);
-//   return authClaims.includes(orgAdminRole);
-// }
-
 // ============================================================================
 // VALIDATION REGEX
 // ============================================================================

src/index.ts

@@ -10,7 +10,6 @@ dotenv.config();
 connectDB();
 
 // Start background jobs
-// TODO: think how to restrict this job to run only on production
 startVerificationJob();
 startDisablingJob();
 startSwepActivationJob();

src/jobs/verificationOrganisationJob.ts

@@ -22,9 +22,7 @@ export function startVerificationJob() {
 
       // Find all organisations with selected administrators
       const organisations = await Organisation.find({
-        'Administrators.IsSelected': true,
-        // TODO: remove this after testing
-        DocumentCreationDate: { $gte: new Date('2025-01-01') }
+        'Administrators.IsSelected': true
       });
 
       for (const org of organisations) {

src/models/bannerModel.ts

@@ -107,7 +107,6 @@ export const BannerSchema = new Schema({
 });
 
 // Indexes for performance
-// TODO: We will handle synching later for all collections
 BannerSchema.index({ IsActive: 1, Priority: -1, 'DocumentCreationDate': -1 });
 BannerSchema.index({ LocationSlug: 1, IsActive: 1 });
 BannerSchema.index({ TemplateType: 1, IsActive: 1 });