[Feature]: Do not show subtitles as selected until they have been downloaded.

[RokeJulianLockhart]

Feature Description

When I last attempted to switch subtitles, I selected a subtitle, and played the relevant scene. I saw no subtitles. This was because I had not yet waited for the notification to inform me that the subtitle had been downloaded.

Proposed Solution

Provide a download progress indicator, instead of pretending that the desired subtitle is selected.

Additional Context or Screenshots

This is especially important for those using slow networks, with auditory disabilities, for they may believe that no available subtitles contain the subtitles for the relevant video section.

My Environment

App Version: 5.0.0-beta.27
Build Version: 872243fc5c4f680e5235fd49d81e0754a073867d
Server Version: 4.20.3

Code of Conduct

• I agree

[kKaskak]

im not sure what exactly are you talking about when you switch the subs you will get a message for either success or error loading, its an srt file which is only a couple of kb so even with slow connection it should be available almost instantly

[RokeJulianLockhart]

#1012 (comment)

@kKaskak, in practice, that is untrue. ¹ When switching between OpenSubtitles V3 .srts, as provided by magnet:?xt=urn:btih:450ceb822d062044672fdcfbc2932fefde288288 of ⪅ ba3a289ef93b14be30ab2ac5351cde16925c54b8 of TheBeastLT/torrentio-scraper's /addon, loading required ⪆ PT40S. That may have been because I switching between them, for I believed that, due to their loading time, some lacked the relevant subtitles. They are certainly never available "almost instantly" (more like PT7S).

If it reproduces again, if I am able to profile its performance, I shall attempt to. However, solely if you are able to provide guidance, because whether to utilise Firefox's network profiler on the web client versus perf, and whether on the Flatpak Service proxy, or Firefox, isn't evident.

Footnotes

1. speedtest.net/result/18012165677 ↩

[kKaskak]

#1012 (comment)

@kKaskak, in practice, that is untrue. When switching between OpenSubtitles V3 .srts, as provided by magnet:?xt=urn:btih:450ceb822d062044672fdcfbc2932fefde288288 of ⪅ ba3a289ef93b14be30ab2ac5351cde16925c54b8 of TheBeastLT/torrentio-scraper's /addon, loading required ⪆ PT40S. That may have been because I switching between them, for I believed that, due to their loading time, some lacked the relevant subtitles. They are certainly never available "almost instantly" (more like PT7S).

i will check asap

[davedumto]

can I work on this issue to fix it?

[RokeJulianLockhart]

@davedumto, are you an example of what RocketChat/Rocket.Chat#37084 (comment) references, or is that a sincere request? I ask because many of your issues in other repositories appear to be written by LLMs.

[davedumto]

Oh no I am a genuine open source contributor, I just use LLMs for my pull request descriptions to make sure it is detailed.
you can check my onlydust profile

[davedumto]

Do I proceed to work on it?

[RokeJulianLockhart]

@davedumto, I presume you're asking @kKaskak? (I don't mind if you submit a PR.)

[davedumto]

Ok in it and also will I be needing any env to run the server locally?

[RokeJulianLockhart]

@davedumto, I'd suggest tagging @kKaskak or another developer when asking, because they might not be subscribed to the thread.

[kKaskak]

Ok in it and also will I be needing any env to run the server locally?

no

[davedumto]

hey @kKaskak , @RokeJulianLockhart

so when I am on the local server, I am not able to add downloaded subtitles, but I can see the embedded ones. how do I go about this. also I am only able to watch the trailers. how can I setup to be able to stream the shows to be able to test the subtitle fix

[davedumto]

Hi can we talk over telegram for faster communication?

This is my handle davedumto

[RokeJulianLockhart]

@davedumto, apologies for the wait: reddit.com/r/degoogle/comments/1ksj118/comment/nix4926 required some effort to bypass. My username is t.me/RokeJulianLockhart.