Fixed side effect for non PR

Voffkaa · Voffkaa · commit 1728477ade76 · 2016-02-02T02:04:18.000+03:00
diff --git a/lib/webhooks.js b/lib/webhooks.js
@@ -29,7 +29,9 @@ function makeJob(project, config) {
     deploy = config.deploy && branch.deploy_on_green
   }
 
-  deploy = ((config.trigger.type === 'pull-request') && branch.deploy_on_pull_request === true);
+  if(config.trigger.type === 'pull-request') {
+    deploy = (branch.deploy_on_pull_request === true)
+  }
 
   job = {
     type: deploy ? 'TEST_AND_DEPLOY' : 'TEST_ONLY',

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,9 @@ function makeJob(project, config) {`
`29`	`29`	`deploy = config.deploy && branch.deploy_on_green`
`30`	`30`	`}`
`31`	`31`
`32`		`- deploy = ((config.trigger.type === 'pull-request') && branch.deploy_on_pull_request === true);`
	`32`	`+ if(config.trigger.type === 'pull-request') {`
	`33`	`+ deploy = (branch.deploy_on_pull_request === true)`
	`34`	`+ }`
`33`	`35`
`34`	`36`	`job = {`
`35`	`37`	`type: deploy ? 'TEST_AND_DEPLOY' : 'TEST_ONLY',`