Throw error if github email missing

Author: Ilya Radchenko

lib/webapp.js

@@ -58,21 +58,24 @@ module.exports = {
   },
 
   auth: function (passport, context) {
-    var config = this.appConfig
+    var config = this.appConfig;
+
     if (!config.appId || !config.appSecret || !config.hostname) {
-      throw new Error('Github plugin misconfigured! Need appId and appSecret and hostname')
+      throw new Error('Github plugin misconfigured! Need `appId`, `appSecret` and `hostname`.');
     }
-    var callbackURL = config.hostname + "/auth/github/callback";
+
+    var callbackURL = config.hostname + '/auth/github/callback';
+
     passport.use(new GithubStrategy({
-          clientID : config.appId
-        , clientSecret: config.appSecret
-        , callbackURL : callbackURL
-        , authorizationURL: config.apiDomain + '/login/oauth/authorize'
-        , tokenURL: config.apiDomain + '/login/oauth/access_token'
-        , userProfileURL: config.apiEndpoint + '/user'
-        , scope: ['repo']
-        , passReqToCallback: true
-        }, validateAuth));
+      clientID : config.appId
+      clientSecret: config.appSecret
+      callbackURL : callbackURL
+      authorizationURL: config.apiDomain + '/login/oauth/authorize'
+      tokenURL: config.apiDomain + '/login/oauth/access_token'
+      userProfileURL: config.apiEndpoint + '/user'
+      scope: ['repo']
+      passReqToCallback: true
+    }, validateAuth));
   },
 
   setupRepo: function (account, config, project, done) {
@@ -139,23 +142,30 @@ module.exports = {
 
 function validateAuth(req, accessToken, refreshToken, profile, done){
   if (!req.user){
-    console.warn('Github OAuth but no logged-in user')
-    req.flash('account', "Cannot link a github account if you aren't logged in")
-    return done()
+    console.warn('Github OAuth but no logged-in user');
+    req.flash('account', 'Cannot link a github account if you aren\'t logged in');
+    return done();
   }
-  var account = req.user.account('github', profile.id)
+
+  var account = req.user.account('github', profile.id);
+
   if (account) {
-    console.warn("Trying to attach a github account that's already attached...")
-    req.flash('account', 'That github account is already linked. <a target="_blank" href="https://github.com/logout">Sign out of github</a> before you click "Add Account"')
-    return done(null, req.user)
+    console.warn('Trying to attach a github account that\'s already attached...');
+    req.flash('account', 'That github account is already linked. <a target="_blank" href="https://github.com/logout">Sign out of github</a> before you click "Add Account"');
+    return done(null, req.user);
   }
-  req.user.accounts.push(makeAccount(accessToken, profile))
+
+  req.user.accounts.push(makeAccount(accessToken, profile));
   req.user.save(function (err) {
     done(err, req.user);
-  })
+  });
 }
 
 function makeAccount(accessToken, profile) {
+  if (!profile.emails || !profile.emails.length) {
+    throw new Error('You need to enter your email address into Github.');
+  }
+
   return {
     provider: 'github',
     id: profile.id,