Merge pull request #19 from oliversalzburg/fix/response

Don't rely on on res being defined

Author: Ilya Radchenko

lib/api.js

@@ -36,14 +36,15 @@ function get(config, uri, done) {
       per_page: 100
     })
     .set('User-Agent', 'StriderCD (http://stridercd.com)')
-    .end(function (error, response) {
-      if (response.error) {
-        return done(response.error, null);
+    .end(function (error, res) {
+      res = res || {};
+      if (res.error) {
+        return done(res.error, null);
       }
-      if (!response.body) {
+      if (!res.body) {
         return done();
       }
-      done(null, response.body);
+      done(null, res.body);
     });
 }
 
@@ -80,7 +81,7 @@ function createHooks(config, repo_id, url, callback) {
     })
     .end(function (err, res) {
       if (err) return callback(err);
-      if (res.status !== 201) return callback(res.status);
+      if (res && res.status !== 201) return callback(res.status);
 
       return callback(null, true);
     });
@@ -97,6 +98,10 @@ function deleteHooks(config, repo_id, url, callback) {
     .end(function (err, res) {
       var deleted = false;
 
+      if (!res) {
+        return callback(new Error("Empty response."));
+      }
+
       async.each(res.body, function (hook, cb) {
         // Remove all webhooks matching url
         if (hook.url == url) {
@@ -129,7 +134,7 @@ function addDeployKey(config, repo_id, title, key, callback) {
     })
     .end(function (err, res) {
       if (err) return callback(err);
-      if (res.status !== 201) return callback(res.status);
+      if (res && res.status !== 201) return callback(res.status);
 
       return callback(null, true)
     });
@@ -146,6 +151,10 @@ function removeDeployKey(config, repo_id, title, callback) {
     .end(function (err, res) {
       var deleted = false;
 
+      if (!res) {
+        return callback(new Error("Empty response."));
+      }
+
       async.each(res.body, function (key, cb) {
         // Remove all webhooks matching url
         if (key.title == title) {