Code cleanup

Author: oliversalzburg

.editorconfig

@@ -0,0 +1,20 @@
+# Strider Editor/IDE Settings
+# This file is used to promote consistent source code standards
+# amongst all Strider-CD contributors.
+# More information can be found here: http://editorconfig.org/
+
+# General Settings
+root = true
+
+# Settings for all files
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+# Settings specific to Markdown files
+[*.md]
+trim_trailing_whitespace = false

.eslintrc

@@ -0,0 +1,21 @@
+{
+  "parserOptions": {
+    "ecmaVersion": 5,
+    "sourceType": "script"
+  },
+  "env": {
+    "node": true
+  },
+  "extends": "eslint:recommended",
+  "rules": {
+    "indent": [2, 2],
+    "brace-style": [2, "1tbs"],
+    "quotes": [2, "single"],
+    "no-console": 0,
+    "no-use-before-define": [2, "nofunc"],
+    "no-underscore-dangle": 0,
+    "no-constant-condition": 0,
+    "space-before-function-paren": [2, {"anonymous": "always", "named": "never"}],
+    "func-style": [2, "declaration"]
+  }
+}

.gitignore

@@ -1,5 +1,7 @@
+.idea/
+node_modules/
+
 .DS_Store
-node_modules
 *~
 *#
 .#*

.jshintrc

@@ -1,4 +1,3 @@
-
 app.controller('NodeController', ['$scope', function ($scope) {
   $scope.nodeVersions = ['0.10', '0.12', 'lts', 'stable', 'latest', 'whatever', 'custom'];
   $scope.ioVersions = ['stable', 'latest', 'whatever'];

config/config.js

@@ -18,7 +18,7 @@ function updateCache(context, projectDir, done) {
 
     async.series([
       cachier.update.bind(null, hash, dest),
-      cachier.update.bind(null, context.branch, dest),
+      cachier.update.bind(null, context.branch, dest)
     ], done);
   });
 }

lib/update-cache.js

@@ -4,13 +4,13 @@
   "description": "Run Nodejs tests in Strider",
   "main": "worker.js",
   "scripts": {
-    "test": "jshint webapp.js worker.js lib/ && node test | tap-spec"
+    "test": "eslint webapp.js worker.js lib/ && node test | tap-spec"
   },
   "repository": {
     "type": "git",
     "url": "https://github.com/Strider-CD/strider-node"
   },
-    "keywords": [
+  "keywords": [
     "strider",
     "node"
   ],
@@ -22,7 +22,7 @@
     "fs-extra": "^0.8.1"
   },
   "devDependencies": {
-    "jshint": "^2.3.0",
+    "eslint": "^3.0.1",
     "tap-spec": "^2.1.0",
     "tape": "^3.0.3"
   },

package.json

@@ -1,4 +1,3 @@
-
 module.exports = {
   // an object that defines the schema for configuration
   config: {
@@ -21,7 +20,7 @@ module.exports = {
       enum: ['strict', 'loose', 'none'],
       default: 'none'
     },
-    test: { type: String, default: 'npm test' },
+    test: {type: String, default: 'npm test'},
     globals: [{
       type: String
     }]

webapp.js

@@ -36,7 +36,7 @@ module.exports = {
         var global = config.globals && config.globals.length;
 
         if (config.test && config.test !== '<none>') {
-          context.data({ doTest: true }, 'extend');
+          context.data({doTest: true}, 'extend');
         }
 
         if (!npmInstall && !global) {