Fix isObject’s detection of undefined keys

Author: AJCStriker

package.json

@@ -1,6 +1,6 @@
 {
   "name": "strontium",
-  "version": "2.3.3",
+  "version": "2.3.4",
   "description": "Strontium is a TypeScript toolkit for High Performance API servers built for Production not Projects.",
   "main": "lib/src/index.js",
   "types": "lib/src/index.d.ts",

src/validation/drivers/validators/isObject.ts

@@ -16,14 +16,18 @@ export const isObject = <V extends ObjectValidator>(validator: V) => async (
     let response: Partial<ValidatedObject<V>> = {}
 
     for (let p in validator) {
-        if (validator.hasOwnProperty(p) && i.hasOwnProperty(p)) {
+        if (validator.hasOwnProperty(p)) {
             // Sadly ts-ignore this as TS doesn't understand that we have strongly ensured
             // that this property is present.
             // @ts-ignore
             let rawValue = i[p]
 
             try {
-                response[p] = await validator[p](rawValue)
+                let validatedOutput = await validator[p](rawValue)
+
+                if (validatedOutput !== undefined) {
+                    response[p] = validatedOutput
+                }
             } catch (e) {
                 if (e instanceof ValidationError) {
                     // Append the path to the error message

tests/validation/drivers/validators/isObject.spec.ts

@@ -1,15 +1,16 @@
 import { expect } from "chai"
 import { combineValidators } from "../../../../src/validation/drivers/helpers/combineValidators"
 import {
-    ValidationError,
-    isISOAlpha2CountryCode,
-    isObject,
-    isString,
-} from "../../../../src"
+  ValidationError,
+  isISOAlpha2CountryCode,
+  isObject,
+  isString, isUndefined
+} from "../../../../src";
+import { either } from "../../../../src/validation/drivers/helpers/either";
 
 describe("isNull", () => {
     const objectFilter = isObject({
-        test: isString,
+        test: either(isString, isUndefined),
         otherTest: combineValidators(isString, isISOAlpha2CountryCode),
     })
 
@@ -55,4 +56,16 @@ describe("isNull", () => {
             expect(e.constraintName).to.equal("IS_STRING")
         }
     })
+
+    it("should return a required validation error if a key is absent", async () => {
+      try {
+        await objectFilter({
+          test: "Test Value"
+        })
+        expect(false).to.equal(true)
+      } catch (e) {
+        expect(e).to.be.instanceOf(ValidationError)
+        expect(e.constraintName).to.equal("IS_STRING")
+      }
+    })
 })