Repair and improve the JWT Signer with RS256

Author: AJCStriker

src/cryptography/drivers/node/AsymmetricJWTSigner.ts

@@ -55,13 +55,12 @@ export class AsymmetricJWTSigner extends JWTSigner {
         }
 
         let claimBody = claimComponents[1]
-
-        let decodedSignature = new Buffer(decode(claimComponents[2]))
+        let claimSignature = claimComponents[2]
 
         // Delegate validation of the signature to the signer
         await this.signer.verify(
             new Buffer(`${claimHeader}.${claimBody}`),
-            decodedSignature
+            new Buffer(claimSignature)
         )
 
         // If no error occurred then the token is valid. Parse the claim and return

src/cryptography/drivers/node/RSASHA256Signer.ts

@@ -13,7 +13,11 @@ export class RSASHA256Signer extends AsymmetricSigner {
     }
 
     public async verify(plaintext: Buffer, signature: Buffer): Promise<Buffer> {
-        let isValid = await RS256.verify(plaintext, signature, this.publicKey)
+        let isValid = await RS256.verify(
+            plaintext,
+            signature.toString(),
+            this.publicKey
+        )
 
         if (!isValid) {
             throw new InvalidSignatureError()

tests/cryptography/drivers/node/AsymmetricJWTSigner.spec.ts

@@ -99,5 +99,22 @@ describe("AsymmetricJWTSigner", () => {
                 admin: true,
             })
         })
+
+        it("Should throw if the JWT is invalid", async () => {
+            try {
+                await jwtSigner.verify(
+                    "eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCJ9" +
+                        "." +
+                        "eyJuYW1lIjoiSGVsbG8gV29ybGQiLCJhZG1pbiI6dHJ1ZX0" +
+                        "." +
+                        "abcdefg"
+                )
+                expect(true).to.equal(false)
+            } catch (e) {
+                expect(e.message).to.equal(
+                    "The signature provided was not valid."
+                )
+            }
+        })
     })
 })