Fix removal of external spec dependency (httpstat.us offline) (#298)

abrom · web-flow · commit d5eb9d826400 · 2025-10-31T12:49:02.000+10:00
* Fix removal of external spec dependency (httpstat.us offline)
* Remove codeclimate
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -84,6 +84,3 @@ jobs:
         env:
           PUPPETEER_VERSION: ${{ matrix.puppeteer-version }}
           GROVER_NO_SANDBOX: true
-
-      - name: Test & publish code coverage
-        uses: paambaati/codeclimate-action@v3.2.0
diff --git a/Gemfile b/Gemfile
@@ -18,5 +18,4 @@ gem 'rspec-retry', '~> 0.6'
 gem 'rubocop', '~> 1.68'
 gem 'rubocop-rake', '~> 0.6'
 gem 'rubocop-rspec', '~> 3.2'
-gem 'simplecov', '~> 0.22.0'
 gem 'sinatra', '~> 4.1'
diff --git a/README.md b/README.md
@@ -1,6 +1,4 @@
 [![Test Build Status](https://github.com/Studiosity/grover/actions/workflows/test.yml/badge.svg)](https://github.com/Studiosity/grover/actions/workflows/test.yml)
-[![Maintainability](https://api.codeclimate.com/v1/badges/37609653789bcf2c8d94/maintainability)](https://codeclimate.com/github/Studiosity/grover/maintainability)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/37609653789bcf2c8d94/test_coverage)](https://codeclimate.com/github/Studiosity/grover/test_coverage)
 [![Gem Version](https://badge.fury.io/rb/grover.svg)](https://badge.fury.io/rb/grover)
 
 # Grover
diff --git a/spec/grover/processor_spec.rb b/spec/grover/processor_spec.rb
@@ -776,7 +776,7 @@
                 <head><link rel="icon" href="data:;base64,iVBORw0KGgo="></head>
                 <body>
                   Hey there
-                  <img src="https://httpstat.us/304" />
+                  <img src="http://localhost:4567/304" />
                 </body>
               </html>
             HTML
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require 'simplecov'
-SimpleCov.start
-
 $LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 require 'grover'
 
diff --git a/spec/support/test_app.rb b/spec/support/test_app.rb
@@ -50,3 +50,7 @@ def authorized?
 get '/cat' do
   '<html><body><img src="/cat.png" alt="Cat"></body></html>'
 end
+
+get '/304' do
+  redirect to('/cat.png'), 304
+end
