Skip to content

Commit a81c179

Browse files
committed
Fixed tests.
1 parent fd40ba0 commit a81c179

File tree

2 files changed

+24
-15
lines changed

2 files changed

+24
-15
lines changed

structure_threader/wrappers/maverick_wrapper.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def mav_alpha_failsafe(mav_params, k_list):
9696
"""
9797
Implements a failsafe for discrepancies with multiple alpha values.
9898
Returns the following dict:
99-
{paramter: {k:param_value}, parameter: {k: param_value}}
99+
{parameter: {k:param_value}, parameter: {k: param_value}}
100100
If the paramterer values are a single value, False is returned:
101101
{paramter: False, parameter: {k: param_value}}
102102
"""
@@ -287,6 +287,7 @@ def _write_normalized_output(evidence, k_list, parameters):
287287
first_k = False
288288
else:
289289
outfile.write(diff[1])
290+
outfile.write("\n")
290291
if evidence is not None:
291292
bestk = _write_normalized_output(evidence, k_list, mav_params)
292293
outfile.close()

tests/maverick_functions_tests.py

Lines changed: 22 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@
2222
import structure_threader.wrappers.maverick_wrapper as mw
2323

2424

25-
2625
def test_mav_cli_generator():
2726
"""
2827
Tests if mav_cli_generator() is working correctlly.
2928
"""
3029
# Define arguments
3130
arg = mockups.Arguments()
3231
k_val = 4
32+
parameters = {}
3333

3434
mock_cli = ["EP", "-Kmin", str(k_val), "-Kmax", str(k_val), "-data",
3535
"IF", "-outputRoot", "mav_K4/", "-masterRoot", "/",
@@ -41,7 +41,7 @@ def test_mav_cli_generator():
4141
if arg.notests is True:
4242
mock_cli += ["-thermodynamic_on", "f"]
4343

44-
returned_cli, out_dir = mw.mav_cli_generator(arg, k_val)
44+
returned_cli, out_dir = mw.mav_cli_generator(arg, k_val, parameters)
4545
assert returned_cli == mock_cli
4646
assert out_dir == "mav_K4/"
4747

@@ -60,16 +60,23 @@ def test_mav_alpha_failsafe():
6060
Tests if mav_alpha_failsafe() is working correctlly.
6161
"""
6262
k_list = [2, 3, 4, 5]
63-
assert mw.mav_alpha_failsafe("smalldata/parameters.txt", k_list) == {
64-
"alpha": False, "alphaPropSD": False}
65-
assert mw.mav_alpha_failsafe("smalldata/parameters_a.txt", k_list) == {
66-
"alpha": {2: "0.9", 3: "0.8", 4: "0.7", 5: "0.6"}, "alphaPropSD": False}
67-
assert mw.mav_alpha_failsafe("smalldata/parameters_as.txt", k_list) == {
68-
"alpha": False,
69-
"alphaPropSD": {2: "0.09", 3: "0.08", 4: "0.07", 5: "0.06"}}
70-
assert mw.mav_alpha_failsafe("smalldata/parameters_a_as.txt", k_list) == {
71-
"alpha": {2: "0.9", 3: "0.8", 4: "0.7", 5: "0.6"},
72-
"alphaPropSD": {2: "0.09", 3: "0.08", 4: "0.07", 5: "0.06"}}
63+
mock_params = [{"alpha": "1", "alphaPropSD": "0.1"},
64+
{"alpha": "0.9,0.8,0.7,0.6", "alphaPropSD": "0.1"},
65+
{"alpha": "1", "alphaPropSD": "0.09,0.08,0.07,0.06"},
66+
{"alpha": "0.9,0.8,0.7,0.6",
67+
"alphaPropSD": "0.09,0.08,0.07,0.06"}]
68+
69+
expected_results = [{"alpha": False, "alphaPropSD": False},
70+
{"alpha": {2: "0.9", 3: "0.8", 4: "0.7", 5: "0.6"},
71+
"alphaPropSD": False},
72+
{"alpha": False,
73+
"alphaPropSD": {2: "0.09", 3: "0.08", 4: "0.07",
74+
5: "0.06"}},
75+
{"alpha": {2: "0.9", 3: "0.8", 4: "0.7", 5: "0.6"},
76+
"alphaPropSD": {2: "0.09", 3: "0.08", 4: "0.07",
77+
5: "0.06"}}]
78+
for exp, mck in zip(expected_results, mock_params):
79+
assert mw.mav_alpha_failsafe(mck, k_list) == exp
7380

7481

7582
def test_maverick_merger():
@@ -88,8 +95,9 @@ def _hash_function(dir_to_test):
8895

8996
return hashes
9097

91-
mw.maverick_merger("files", [1, 2, 3], "smalldata/parameters.txt", False)
98+
mav_params = mw.mav_params_parser("smalldata/parameters.txt")
99+
mw.maverick_merger("files", [1, 2, 3], mav_params, False)
92100
known_hashes = _hash_function("files/test_merged")
93-
generated_hashes = _hash_function("files/merged")
101+
generated_hashes = _hash_function("files/merged")[1:]
94102

95103
assert known_hashes == generated_hashes

0 commit comments

Comments
 (0)