Update the opa version to latest #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
reviewed
Jan 5, 2026
| one_arg = x { | ||
| x = custom.oneArgBuiltin(input.args[0]) | ||
| } | ||
| one_arg() := custom.oneArgBuiltin(input.args[0]) |
Contributor
There was a problem hiding this comment.
arity-0 functions are rules, and asking for trouble 😅
Let's do
one_arg := custom.oneArgBuiltin(input.args[0])instead?
Contributor
There was a problem hiding this comment.
Sorry I meant all of them in this file ;)
Collaborator
Author
There was a problem hiding this comment.
got it, sorry 👍 should be good now
srenatus
approved these changes
Jan 5, 2026
Contributor
srenatus
left a comment
srenatus
left a comment
There was a problem hiding this comment.
LGTM just a nitpick re: arity-0 functions
Collaborator
Author
|
Thanks a lot for the quick review @srenatus ! Appreciated 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #103