Skip to content

Commit 97c2dbf

Browse files
author
Gunslinger
committed
Fix error messages to show actual API response instead of assumed causes
- Remove hardcoded "denied by provider due to insufficient permissions or quota limits" messages that assumed 403 causes - Show actual status code and API error message when available - Remove unused getMovieRequestDeniedMessage and getSeasonRequestDeniedMessage - Helps diagnose actual issues (reverse proxy, network, permissions, etc.)
1 parent 642b7b6 commit 97c2dbf

File tree

2 files changed

+5
-37
lines changed

2 files changed

+5
-37
lines changed

lib/media-status.js

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ import { extractMediaStatus, formatStatusMessage, formatMedia } from './request.
77
import { extractApiMessage } from './api-message-extractor.js';
88
import {
99
getMovieRequestSuccessMessage,
10-
getMovieRequestDeniedMessage,
1110
getSeasonRequestSuccessMessage,
12-
getSeasonRequestDeniedMessage,
1311
getAllSeasonsRequestSuccessMessage,
1412
getGenericErrorMessage
1513
} from './message-mapper.js';
@@ -289,27 +287,13 @@ export function getRequestStatusMessage(res, typeStr, isTvShow = false, is4k = f
289287
return `ℹ️ Already requested or available`;
290288
}
291289

292-
// Check for denied/forbidden statuses (403, 400 with specific messages)
293-
if (res.status === 403 || (res.status === 400 && apiMessage && (
294-
apiMessage.toLowerCase().includes('denied') ||
295-
apiMessage.toLowerCase().includes('permission') ||
296-
apiMessage.toLowerCase().includes('quota') ||
297-
apiMessage.toLowerCase().includes('limit')
298-
))) {
299-
if (isTvShow) {
300-
return getSeasonRequestDeniedMessage();
301-
} else {
302-
return getMovieRequestDeniedMessage();
303-
}
304-
}
305-
306-
// For other error statuses, try to extract API message
290+
// For error statuses, show actual error info without assuming the cause
291+
// Prioritize API message if available, otherwise show status code
307292
if (apiMessage) {
308-
// Return API message as-is if available, otherwise use generic error
309-
return apiMessage;
293+
return `❌ Request failed (${res.status}): ${apiMessage}`;
310294
}
311295

312-
// Generic error fallback
313-
return getGenericErrorMessage();
296+
// No API message - show status code with generic description
297+
return `❌ Request failed with status ${res.status}`;
314298
}
315299

lib/message-mapper.js

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,6 @@ export function getMovieRequestSuccessMessage(movieTitle) {
5757
return `✅ Your request for **${movieTitle}** was sent successfully!`;
5858
}
5959

60-
/**
61-
* Gets the appropriate message for a movie request denied
62-
* @returns {string} Denied message
63-
*/
64-
export function getMovieRequestDeniedMessage() {
65-
return `❌ Your request was denied by the provider due to insufficient permissions or quota limits.`;
66-
}
67-
6860
/**
6961
* Gets the appropriate message for a movie notification success
7062
* @param {string} movieTitle - Movie title
@@ -274,14 +266,6 @@ export function getShowCannotBeRequestedMessage() {
274266
return `⚠️ This show cannot be automatically requested, please ask the server owner to manually add it.`;
275267
}
276268

277-
/**
278-
* Gets the appropriate message for a season request denied
279-
* @returns {string} Denied message
280-
*/
281-
export function getSeasonRequestDeniedMessage() {
282-
return `❌ Your request was denied by the provider due to an insufficient quota limit or insufficient roles.`;
283-
}
284-
285269
/**
286270
* Gets the appropriate message for a TV show not found
287271
* @param {Object} options - Options object

0 commit comments

Comments
 (0)