Skip to content

Commit b7b8c2d

Browse files
Sub6ResourcesSub6Resources
committed
Fix analysis hints in test/
1 parent e1a5d3d commit b7b8c2d

File tree

7 files changed

+37
-40
lines changed

7 files changed

+37
-40
lines changed

‎pubspec.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,6 @@ dev_dependencies:
2727
flutter_test:
2828
sdk: flutter
2929
flutter_lints: ^2.0.1
30+
meta: ^1.8.0
3031

3132
flutter:

‎test/flutter_html_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ void main() {
6161
MaterialApp(
6262
home: Html(
6363
data: "<p>Text</p>",
64-
tagsList: ['div'], //Anything but `p`
64+
tagsList: const ['div'], //Anything but `p`
6565
),
6666
),
6767
);
@@ -73,7 +73,7 @@ void main() {
7373
MaterialApp(
7474
home: Html(
7575
data: "<p>Text</p>",
76-
tagsList: ['html', 'body', 'p'],
76+
tagsList: const ['html', 'body', 'p'],
7777
),
7878
),
7979
);

‎test/golden_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import 'test_data.dart';
77
class TestApp extends StatelessWidget {
88
final Widget body;
99

10-
TestApp(this.body);
10+
const TestApp(this.body, {super.key});
1111

1212
@override
1313
Widget build(BuildContext context) {

‎test/html_parser_test.dart

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ void main() {
2222
testNewParser(context);
2323

2424
// The builder function must return a widget.
25-
return Placeholder();
25+
return const Placeholder();
2626
},
2727
),
2828
);
@@ -32,7 +32,7 @@ void main() {
3232
void testNewParser(BuildContext context) {
3333
HtmlParser.parseHTML("<b>Hello, World!</b>");
3434

35-
StyledElement tree = HtmlParser.lexDomTree(
35+
HtmlParser.lexDomTree(
3636
HtmlParser.parseHTML(
3737
"Hello! <b>Hello, World!</b><i>Hello, New World!</i>"),
3838
[],
@@ -49,16 +49,15 @@ void testNewParser(BuildContext context) {
4949
onImageError: null,
5050
shrinkWrap: false,
5151
selectable: true,
52-
style: {},
52+
style: const {},
5353
customRenders: generateDefaultRenders(),
5454
tagsList: Html.tags,
5555
selectionControls: null,
5656
scrollPhysics: null,
5757
),
5858
);
59-
print(tree.toString());
6059

61-
tree = HtmlParser.lexDomTree(
60+
HtmlParser.lexDomTree(
6261
HtmlParser.parseHTML(
6362
"Hello, World! <a href='https://example.com'>This is a link</a>"),
6463
[],
@@ -75,64 +74,61 @@ void testNewParser(BuildContext context) {
7574
onImageError: null,
7675
shrinkWrap: false,
7776
selectable: true,
78-
style: {},
77+
style: const {},
7978
customRenders: generateDefaultRenders(),
8079
tagsList: Html.tags,
8180
selectionControls: null,
8281
scrollPhysics: null,
8382
),
8483
);
85-
print(tree.toString());
8684

87-
tree = HtmlParser.lexDomTree(
88-
HtmlParser.parseHTML("<img src='https://image.example.com' />"),
85+
HtmlParser.lexDomTree(
86+
HtmlParser.parseHTML("<img alt='' src='https://image.example.com' />"),
8987
[],
9088
Html.tags,
9189
context,
9290
HtmlParser(
9391
key: null,
94-
htmlData: HtmlParser.parseHTML("<img src='https://image.example.com' />"),
92+
htmlData: HtmlParser.parseHTML("<img alt='' src='https://image.example.com' />"),
9593
onLinkTap: null,
9694
onAnchorTap: null,
9795
onImageTap: null,
9896
onCssParseError: null,
9997
onImageError: null,
10098
shrinkWrap: false,
10199
selectable: true,
102-
style: {},
100+
style: const {},
103101
customRenders: generateDefaultRenders(),
104102
tagsList: Html.tags,
105103
selectionControls: null,
106104
scrollPhysics: null,
107105
),
108106
);
109-
print(tree.toString());
110107

111-
tree = HtmlParser.lexDomTree(
108+
HtmlParser.lexDomTree(
112109
HtmlParser.parseHTML(
113-
"<div><div><div><div><a href='link'>Link</a><div>Hello, World! <b>Bold and <i>Italic</i></b></div></div></div></div></div>"),
110+
"<div><div><div><div><a href='https://example.com'>Link</a><div>Hello, World! <b>Bold and <i>Italic</i></b></div></div></div></div></div>"),
114111
[],
115112
Html.tags,
116113
context,
117114
HtmlParser(
118115
key: null,
119116
htmlData: HtmlParser.parseHTML(
120-
"<div><div><div><div><a href='link'>Link</a><div>Hello, World! <b>Bold and <i>Italic</i></b></div></div></div></div></div>"),
117+
"<div><div><div><div><a href='https://example.com'>Link</a><div>Hello, World! <b>Bold and <i>Italic</i></b></div></div></div></div></div>"),
121118
onLinkTap: null,
122119
onAnchorTap: null,
123120
onImageTap: null,
124121
onCssParseError: null,
125122
onImageError: null,
126123
shrinkWrap: false,
127124
selectable: true,
128-
style: {},
125+
style: const {},
129126
customRenders: generateDefaultRenders(),
130127
tagsList: Html.tags,
131128
selectionControls: null,
132129
scrollPhysics: null,
133130
),
134131
);
135-
print(tree.toString());
136132

137133
/*ReplacedElement videoContentElement = parseReplacedElement(
138134
HtmlParser.parseHTML("""
@@ -174,7 +170,7 @@ void testNewParser(BuildContext context) {
174170
}*/
175171

176172
Style style1 = Style(
177-
display: Display.BLOCK,
173+
display: Display.block,
178174
fontWeight: FontWeight.bold,
179175
);
180176

@@ -186,7 +182,7 @@ void testNewParser(BuildContext context) {
186182

187183
Style finalStyle = style1.merge(style2);
188184

189-
expect(finalStyle.display, equals(Display.BLOCK));
185+
expect(finalStyle.display, equals(Display.block));
190186
expect(finalStyle.before, equals("* "));
191187
expect(finalStyle.direction, equals(TextDirection.rtl));
192188
expect(finalStyle.fontStyle, equals(FontStyle.italic));

‎test/image_render_source_matcher_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ void main() {
179179

180180
String _fakeElement(String? src) {
181181
return """
182-
<img src="$src" />
182+
<img alt ='' src="$src" />
183183
""";
184184
}
185185

@@ -198,7 +198,7 @@ void testImgSrcMatcher(
198198
customRenders: {
199199
matcher: CustomRender.widget(
200200
widget: (RenderContext context, _) {
201-
return Text("Success");
201+
return const Text("Success");
202202
},
203203
),
204204
},

‎test/style/fontsize_test.dart

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,52 +5,52 @@ import 'package:flutter_test/flutter_test.dart';
55
void main() {
66
test('Check basic FontSize inheritance', () {
77
final FontSize parent = FontSize(16);
8-
final FontSize? child = null;
8+
const FontSize? child = null;
99

1010
final result = FontSize.inherit(parent, child);
1111

1212
expect(result?.value, equals(16));
1313
});
1414

1515
test('Check double null FontSize inheritance', () {
16-
final FontSize? parent = null;
17-
final FontSize? child = null;
16+
const FontSize? parent = null;
17+
const FontSize? child = null;
1818

1919
final result = FontSize.inherit(parent, child);
2020

2121
expect(result?.value, equals(null));
2222
});
2323

2424
test('Check basic em inheritance', () {
25-
final FontSize? parent = FontSize(16);
26-
final FontSize? child = FontSize(1, Unit.em);
25+
final FontSize parent = FontSize(16);
26+
final FontSize child = FontSize(1, Unit.em);
2727

2828
final result = FontSize.inherit(parent, child);
2929

3030
expect(result?.value, equals(16));
3131
});
3232

3333
test('Check factor em inheritance', () {
34-
final FontSize? parent = FontSize(16);
35-
final FontSize? child = FontSize(0.5, Unit.em);
34+
final FontSize parent = FontSize(16);
35+
final FontSize child = FontSize(0.5, Unit.em);
3636

3737
final result = FontSize.inherit(parent, child);
3838

3939
expect(result?.value, equals(8));
4040
});
4141

4242
test('Check basic % inheritance', () {
43-
final FontSize? parent = FontSize(16);
44-
final FontSize? child = FontSize(100, Unit.percent);
43+
final FontSize parent = FontSize(16);
44+
final FontSize child = FontSize(100, Unit.percent);
4545

4646
final result = FontSize.inherit(parent, child);
4747

4848
expect(result?.value, equals(16));
4949
});
5050

5151
test('Check scaled % inheritance', () {
52-
final FontSize? parent = FontSize(16);
53-
final FontSize? child = FontSize(50, Unit.percent);
52+
final FontSize parent = FontSize(16);
53+
final FontSize child = FontSize(50, Unit.percent);
5454

5555
final result = FontSize.inherit(parent, child);
5656

‎test/utils_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ void main() {
1313

1414
test('CustomBorderSide does not allow negative width', () {
1515
expect(() => CustomBorderSide(width: -5), throwsAssertionError);
16-
expect(CustomBorderSide(width: 0), TypeMatcher<CustomBorderSide>());
17-
expect(CustomBorderSide(width: 5), TypeMatcher<CustomBorderSide>());
16+
expect(CustomBorderSide(width: 0), const TypeMatcher<CustomBorderSide>());
17+
expect(CustomBorderSide(width: 5), const TypeMatcher<CustomBorderSide>());
1818
});
1919

2020
const originalString = 'Hello';
@@ -25,18 +25,18 @@ void main() {
2525
expect(originalString.transformed(null), equals(originalString));
2626
});
2727

28-
test('TextTransformUtil uppercases correctly', () {
28+
test('TextTransformUtil uppercase-s correctly', () {
2929
expect(originalString.transformed(TextTransform.uppercase), equals(uppercaseString));
3030
});
3131

32-
test('TextTransformUtil lowercases correctly', () {
32+
test('TextTransformUtil lowercase-s correctly', () {
3333
expect(originalString.transformed(TextTransform.lowercase), equals(lowercaseString));
3434
});
3535

3636
const originalLongString = 'Hello, world! pub.dev';
3737
const capitalizedLongString = 'Hello, World! Pub.Dev';
3838

39-
test('TextTransformUtil capitalizs correctly', () {
39+
test('TextTransformUtil capitalizes correctly', () {
4040
expect(originalLongString.transformed(TextTransform.capitalize), equals(capitalizedLongString));
4141
});
4242
}

0 commit comments

Comments
 (0)