Should have done everything the comments said! (hopefully!)

Author: oblongboot

src/main/kotlin/com/github/subat0m1c/hatecheaters/HateCheaters.kt

@@ -45,7 +45,7 @@ class HateCheaters {
         if (timesCheckedForUpdate > 1 || isUpdateCheckInProgress) return
 
         isUpdateCheckInProgress = true
-        launch(Dispatchers.IO) {
+        launch {
             CheckUpdate.lookForUpdates()
             isUpdateCheckInProgress = false
         }

src/main/kotlin/com/github/subat0m1c/hatecheaters/modules/HateCheatersModule.kt

@@ -14,6 +14,6 @@ object HateCheatersModule : Module(
 ) {
     val logJson: Boolean by BooleanSetting("Log Json", default = false, description = "Logs requested json data to Config/hatecheaters/json_logs")
     val debugMessages: Boolean by BooleanSetting("Debug messages", default = false, description = "Prints debug messages in your chat instead of needing to open logs.")
-
+    val checkUpdates: Boolean by BooleanSetting("Update Checker", default = true, description = "Checks GitHub for latest HateCheaters releases and notifies you if you are on an old version!")
     val server: String by StringSetting("Api Server", default = "default", hidden = false, description = "Server to be used to connect to the api. set to \"default\" to use the default. Only change if you know what you're doing. format: \"subdomain.domain.tld\"")
 }

src/main/kotlin/com/github/subat0m1c/hatecheaters/utils/CheckUpdate.kt

@@ -2,7 +2,12 @@ package com.github.subat0m1c.hatecheaters.utils
 
 import com.github.subat0m1c.hatecheaters.utils.ChatUtils
 import com.github.subat0m1c.hatecheaters.utils.LogHandler.Logger
+import com.github.subat0m1c.hatecheaters.utils.WebUtils
+import me.odinmain.utils.skyblock.getChatBreak
+import com.github.subat0m1c.hatecheaters.utils.OdinCheck.compareVersions
+import com.github.subat0m1c.hatecheaters.modules.HateCheatersModule.checkUpdates
 import com.github.subat0m1c.hatecheaters.HateCheaters
+import net.minecraft.event.ClickEvent
 import kotlinx.serialization.*
 import kotlinx.serialization.json.*
 import kotlinx.coroutines.*
@@ -19,37 +24,30 @@ data class ReleaseInfo(
     val tag_name: String
 )
 
-object CheckUpdate { // hi my goat SubAt0m1c <3
+object CheckUpdate {
     private const val githubAPIURL = "https://api.github.com/repos/subat0m1c/HateCheaters/releases/latest"
-    private val currentVersion: String = HateCheaters.version
-    private val updateScope = CoroutineScope(Dispatchers.IO + SupervisorJob())
+    private inline val currentVersion: String get() = HateCheaters.version
 
     fun lookForUpdates() {
-        updateScope.launch {
-            try {
-                val url = URL(githubAPIURL)
-                val connection = url.openConnection() as HttpURLConnection
-                connection.requestMethod = "GET"
-                connection.setRequestProperty("Accept", "application/json")
-                connection.setRequestProperty("User-Agent", "Mozilla/5.0")
-                connection.connectTimeout = 5000
-                connection.readTimeout = 5000
+        if (!checkUpdates) {
+            return
+        }
 
+        HateCheaters.scope.launch {
+            try {
                 Logger.info("Currently on HateCheaters $currentVersion")
-
-                if (connection.responseCode == HttpURLConnection.HTTP_OK) {
-                    val jsonResponse = connection.inputStream.bufferedReader().use { it.readText() }
-
-                    checkVersion(jsonResponse)
-                } else {
-                    Logger.warning("Failed to check GitHub releases. HTTP ${connection.responseCode}")
+                val jsonResponse = WebUtils.getInputStream(githubAPIURL).getOrElse {
+                    return@launch Logger.warning("Failed to fetch data from GitHub API: ${it.message}")
                 }
+                val jsonString = jsonResponse.bufferedReader().use { it.readText() }
+                checkVersion(jsonString)
             } catch (e: Exception) {
                 Logger.warning("Error while checking for updates: ${e.message}")
             }
         }
     }
 
+
     private suspend fun checkVersion(jsonResponse: String) {
         val releaseInfo = json.decodeFromString<ReleaseInfo>(jsonResponse)
         val latestVersion = releaseInfo.tag_name
@@ -60,43 +58,23 @@ object CheckUpdate { // hi my goat SubAt0m1c <3
             ChatUtils.modMessage("You are on a development build! Hi!")
             Logger.info("HC > Development Build Detected!")
         } else if (isNewVersionAvailable > 0) {
-            val newReleaseURL = "https://github.com/SubAt0m1c/HateCheaters/releases/tag/"
-            val releaseLink = "$newReleaseURL$latestVersion"
+            val releaseLink = "https://github.com/SubAt0m1c/HateCheaters/releases/tag/$latestVersion"
             delay(2000)
-            ChatUtils.modMessage("Update available! ($currentVersion → $latestVersion)")
             ChatUtils.chatConstructor {
+                displayText(getChatBreak())
+                displayText("§bH§3C §8»§r Update available! ($currentVersion → $latestVersion) ")
                 clickText(
-                    "§bH§3C §8»§r Click HERE to copy the latest release link",
-                    "/hcdev writetoclipboard $releaseLink",
-                    hoverText = listOf("Click to copy the release link to clipboard") // ill try make it open the link but idk how to do that atm!
+                    "Click here to open the latest release link!",
+                    releaseLink,
+                    listOf("Click to open the release link."),
+                    ClickEvent.Action.OPEN_URL
                 )
+                displayText(getChatBreak())
             }.print()
+
             Logger.info("HC > Update available.")
         } else {
             Logger.info("HC > No update needed.")
         }
     }
-
-    private fun compareVersions(version1: String, version2: String): Int {
-        fun parseVersion(version: String): List<Int> {
-            return if (version.contains(".")) {
-                version.split(".").map { it.toIntOrNull() ?: 0 }
-            } else {
-                version.map { it.toString().toIntOrNull() ?: 0 }
-            }
-        }
-
-        val v1Components = parseVersion(version1)
-        val v2Components = parseVersion(version2)
-
-        val maxLength = maxOf(v1Components.size, v2Components.size)
-        val paddedV1 = v1Components + List(maxLength - v1Components.size) { 0 }
-        val paddedV2 = v2Components + List(maxLength - v2Components.size) { 0 }
-
-        for (i in 0 until maxLength) {
-            if (paddedV1[i] > paddedV2[i]) return 1
-            if (paddedV1[i] < paddedV2[i]) return -1
-        }
-        return 0
-    }
 }

src/main/kotlin/com/github/subat0m1c/hatecheaters/utils/OdinCheck.kt

@@ -30,7 +30,7 @@ object OdinCheck {
 
         try {
             val currentOdin = Loader.instance().activeModList.find { it.modId == "od" || it.modId == "odclient" }?.version ?: ""
-            if (compareVersions(currentOdin) == -1) odinWarning("Odin is outdated!", currentOdin)
+            if (compareVersions(currentOdin, "@REQUIREDODINVERSION@") == -1) odinWarning("Odin is outdated!", currentOdin)
         } catch (e: Throwable) {
             odinWarning("An unknown error occurred trying to determine Odin version!")
             return
@@ -120,9 +120,10 @@ object OdinCheck {
      *
      * I think this code is bad but i cant be bothered fixing it. also can return lower than -1.
      */
-    private fun compareVersions(version1: String): Int {
+    fun compareVersions(version1: String, version2: String): Int {
         val v1 = versionRegex.find(version1)?.groupValues?.drop(1)?.map { it.toIntOrNull() } ?: return -2
-        val v2 = versionRegex.find("@REQUIREDODINVERSION@")?.groupValues?.drop(1)?.map { it.toIntOrNull() } ?: return -2
+        val v2 = versionRegex.find(version2)?.groupValues?.drop(1)?.map { it.toIntOrNull() } ?: return -2
+
 
         for (i in 0..2) {
             val compared = compareNumbers(v1[i], v2[i])