scoped the connection open and close at the wrong level in the code

Author: kccarter76

SubSonic.Extensions.Test/MockDbClient/MockDBErrors.Designer.cs

@@ -117,8 +117,11 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="ConnectionStateAlreadyOpen" xml:space="preserve">
+    <value>Connection State Already Open.</value>
+  </data>
   <data name="ConnectionStateNotOpen" xml:space="preserve">
-    <value>Connection State Not Open</value>
+    <value>Connection State Not Open.</value>
   </data>
   <data name="MissingDbParameter" xml:space="preserve">
     <value>Missing expected db parameter.</value>

SubSonic.Extensions.Test/MockDbClient/MockDBErrors.resx

@@ -55,6 +55,11 @@ public override string Database
 
         public override void Open()
         {
+            if (state == ConnectionState.Open)
+            {
+                throw Error.InvalidOperation(MockDBErrors.ConnectionStateAlreadyOpen);
+            }
+
             state = ConnectionState.Open;
         }
 

SubSonic.Extensions.Test/MockDbClient/MockDbConnection.cs

@@ -190,6 +190,8 @@ public object Execute(Expression expression)
 
                         bool isEntityModel = DbContext.DbModel.IsEntityModelRegistered(elementType);
 
+                        Scope.Connection.Open();
+
                         using (DbDataReader reader = Scope.Database.ExecuteReader(dbQuery))
                         {
                             if (reader.HasRows)
@@ -218,6 +220,8 @@ public object Execute(Expression expression)
                     finally
                     {
                         dbQuery.CleanUpParameters();
+
+                        Scope.Connection.Close();
                     }
                 }
             }

SubSonic/Infrastructure/Builders/DbSqlQueryBuilder/DbSqlQueryBuilderQueryProvider.cs

@@ -264,13 +264,13 @@ public DbDataReader ExecuteReader(IDbQuery queryObject)
 
                 try
                 {
-                    cmd.Connection.Open();
-
                     return cmd.ExecuteReader(queryObject.Behavior);
                 }
-                finally
-                {
-                    cmd.Connection.Close();
+                catch(DataException ex)
+                { 
+                    logger.LogCritical(ex, ex.Message);
+
+                    throw;
                 }
             }
         }

SubSonic/Infrastructure/Database/DbDatabase.cs

@@ -9,7 +9,7 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <PackageTags>DAL;SqlServer;C#;.NetFramework;.NetCore;</PackageTags>
-    <Version>4.1.0-alpha.3</Version>
+    <Version>4.1.0-alpha.4</Version>
     <PackageId>SubSonic.Core.DAL</PackageId>
     <Company>SubSonic-Core</Company>
     <PackageProjectUrl>https://github.com/SubSonic-Core/SubSonic/wiki</PackageProjectUrl>