#34 - identified the source of the stack overflow

Author: kccarter76

SubSonic.Core.Abstractions/SubSonic.Core.Abstractions.csproj

@@ -6,6 +6,8 @@
     <Authors>Kenneth Carter</Authors>
     <Version>4.1.0-alpha.1</Version>
     <SignAssembly>true</SignAssembly>
+    <IncludeSymbols>true</IncludeSymbols>
+    <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <AssemblyOriginatorKeyFile>SubSonicStrongName.snk</AssemblyOriginatorKeyFile>
     <PackageLicenseFile>LICENSE.MD</PackageLicenseFile>
   </PropertyGroup>

SubSonic.Tests/DAL/ExtensionMethod/PagingExtensionMethodTests.cs

@@ -87,17 +87,21 @@ public async Task ShouldBeAbleToEnumeratePagedDataAsync()
                 recordCount = People.Count(),
                 pageSize = 10,
                 pageCount = (int)Math.Ceiling((decimal)recordCount / pageSize),
-                count = 0;
+                cnt = 0, 
+                pageCnt = 0;
 
             foreach (var page in Context.People.ToPagedCollection(pageSize).GetPages())
             {
-                await foreach(Person person in page)
+                pageCnt++;
+
+                await foreach (Person person in page)
                 {
-                    count++;
+                    cnt++;
                 }
             }
 
-            count.Should().Be(recordCount);
+            pageCnt.Should().Be(pageCount);
+            cnt.Should().Be(recordCount);
         }
     }
 }

SubSonic/Database/DbPageCollection.cs

@@ -5,6 +5,7 @@
 using System.Data;
 using System.Data.Common;
 using System.Globalization;
+using System.Runtime.CompilerServices;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
@@ -107,7 +108,7 @@ IEnumerator IEnumerable.GetEnumerator()
         }
 
 #if NETSTANDARD2_0
-        public IAsyncEnumerator<TEntity> GetAsyncEnumerator(CancellationToken cancellationToken = default)
+        IAsyncEnumerator<TEntity> IAsyncEnumerable<TEntity>.GetAsyncEnumerator(CancellationToken cancellationToken)
         {
             return new Dasync.Collections.AsyncEnumerable<TEntity>(async yield =>
             {
@@ -116,14 +117,15 @@ public IAsyncEnumerator<TEntity> GetAsyncEnumerator(CancellationToken cancellati
                     await yield.ReturnAsync(entity).ConfigureAwait(false);
                 }
             }).GetAsyncEnumerator(cancellationToken);
+        }
 #elif NETSTANDARD2_1
-        public async IAsyncEnumerator<TEntity> GetAsyncEnumerator(CancellationToken cancellationToken = default)
+        async IAsyncEnumerator<TEntity> IAsyncEnumerable<TEntity>.GetAsyncEnumerator(CancellationToken cancellationToken)
         {
-            await foreach(TEntity entity in this.WithCancellation(cancellationToken))
+            foreach(TEntity entity in this)
             {
                 yield return entity;
             }
-#endif
         }
+#endif
     }
 }