update pytest warning factory boy

Author: Sublian

products/views.py

@@ -17,8 +17,13 @@ def get_permissions(self):
 
     def get_queryset(self):
         user = self.request.user
-        if user.role == 'ADMIN':
+
+        if user.role == "ADMIN":
             return Product.objects.all()
+
+        if user.role == "STAFF":
+            return Product.objects.filter(is_public=True)
+
         return Product.objects.filter(owner=user)
 
     def perform_create(self, serializer):

tests/factories.py

@@ -8,12 +8,19 @@
 class UserFactory(factory.django.DjangoModelFactory):
     class Meta:
         model = User
+        skip_postgeneration_save = True  # ✅ ESTA LÍNEA ELIMINA EL WARNING
 
     username = factory.Sequence(lambda n: f"user{n}")
     email = factory.LazyAttribute(lambda o: f"{o.username}@test.com")
-    password = factory.PostGenerationMethodCall('set_password', '123456')
     role = 'CLIENTE'
 
+    @factory.post_generation
+    def password(self, create, extracted, **kwargs):
+        pwd = extracted if extracted else "123456"
+        self.set_password(pwd)
+        if create:
+            self.save()
+
 
 class AdminFactory(UserFactory):
     role = 'ADMIN'

tests/test_products.py

@@ -62,3 +62,37 @@ def test_admin_can_delete_product(api_client, admin_user, get_token):
     response = api_client.delete(f"/api/products/{product.id}/")
 
     assert response.status_code == 204
+
+@pytest.mark.django_db
+def test_client_sees_only_own_products(api_client, client_user, get_token):
+    ProductFactory.create_batch(3, owner=client_user)
+    ProductFactory.create_batch(2)
+
+    token = get_token(client_user)
+    api_client.credentials(HTTP_AUTHORIZATION=f"Bearer {token}")
+
+    response = api_client.get("/api/products/")
+    assert len(response.data) == 3
+
+
+@pytest.mark.django_db
+def test_staff_sees_only_public_products(api_client, staff_user, get_token):
+    ProductFactory.create_batch(2, is_public=True)
+    ProductFactory.create_batch(2, is_public=False)
+
+    token = get_token(staff_user)
+    api_client.credentials(HTTP_AUTHORIZATION=f"Bearer {token}")
+
+    response = api_client.get("/api/products/")
+    assert len(response.data) == 2
+
+
+@pytest.mark.django_db
+def test_admin_sees_all_products(api_client, admin_user, get_token):
+    ProductFactory.create_batch(5)
+
+    token = get_token(admin_user)
+    api_client.credentials(HTTP_AUTHORIZATION=f"Bearer {token}")
+
+    response = api_client.get("/api/products/")
+    assert len(response.data) == 5