Plugins: Update set unsaved view name listener

This commit implements auto view name assignment according to ST's
default implementation but instead of sticking with first line only,
it still prefers first heading if available.

Author: deathaxe

plugins/decorators.py

@@ -0,0 +1,50 @@
+import sublime
+
+from functools import partial, wraps
+from time import time as now
+
+
+def debounced(delay_in_ms, sync=False):
+    """Delay calls to event hooks until they weren't triggered for n ms.
+
+    Performs view-specific tracking and is best suited for the
+    `on_modified` and `on_selection_modified` methods
+    and their `_async` variants.
+    The `view` is taken from the first argument for `EventListener`s
+    and from the instance for `ViewEventListener`s.
+
+    Calls are only made when the `view` is still "valid" according to ST's API,
+    so it's not necessary to check it in the wrapped function.
+    """
+
+    # We assume that locking is not necessary because each function will be called
+    # from either the ui or the async thread only.
+    set_timeout = sublime.set_timeout if sync else sublime.set_timeout_async
+
+    def decorator(func):
+        call_at = {}
+
+        def _debounced_callback(view, callback):
+            if not view.is_valid():
+                del call_at[view.view_id]
+                return
+            diff = call_at[view.view_id] - now() * 1000
+            if diff > 0:
+                set_timeout(partial(_debounced_callback, view, callback), diff)
+            else:
+                del call_at[view.view_id]
+                callback()
+
+        @wraps(func)
+        def wrapper(self, *args, **kwargs):
+            view = self.view if hasattr(self, 'view') else args[0]
+            pending = view.view_id in call_at
+            call_at[view.view_id] = now() * 1000 + delay_in_ms
+            if pending:
+                return
+            callback = partial(func, self, *args, **kwargs)
+            set_timeout(partial(_debounced_callback, view, callback), delay_in_ms)
+
+        return wrapper
+
+    return decorator

plugins/headings/common.py

@@ -1,6 +1,9 @@
 import re
+import unicodedata
+
 import sublime
 
+from ..decorators import debounced
 from ..view import MdeViewEventListener
 
 HEADINGS_RE = re.compile(
@@ -54,15 +57,42 @@ class MdeUnsavedViewNameSetter(MdeViewEventListener):
     This view event listener prints the first heading as tab title of unsaved documents.
     """
 
-    MAX_NAME = 50
-
+    @debounced(50, sync=True)
     def on_modified(self):
-        if self.view.file_name() is not None or not self.view.settings().get(
-            "set_unsaved_view_name", True
-        ):
+        if self.view.file_name() or self.view.is_loading():
+            return
+
+        view_settings = self.view.settings()
+        if not view_settings.get('set_unsaved_view_name', True):
+            return
+
+        cur_name = view_settings.get('mde_auto_name')
+        view_name = self.view.name()
+
+        # Name has been explicitly set, don't override it
+        if not cur_name and view_name:
+            return
+
+        # Name has been explicitly changed, don't override it
+        if cur_name and cur_name != view_name:
+            view_settings.erase('mde_auto_name')
+            return
+
+        # Don't set the names on widgets, it'll just trigger spurious
+        # on_modified callbacks
+        if view_settings.get('is_widget'):
             return
 
         name = first_heading_text(self.view)
-        if len(name) > self.MAX_NAME:
-            name = name[: self.MAX_NAME] + "…"
+        if len(name) > 50:
+            name = name[: 50] + "…"
+
+        # Filter non-printable characters. Without this the save dialog on
+        # windows fails to open.
+        first_line = ''.join(c for c in name if unicodedata.category(c)[0] != 'C')
+
         self.view.set_name(name)
+        view_settings.set('mde_auto_name', name)
+
+        # make sure ST's default auto-namer keeps quite
+        view_settings.erase('auto_name')

syntaxes/Markdown.sublime-settings

@@ -1,3 +1,6 @@
 {
+	// Disable ST's default view name assigner
+	"set_unsaved_view_name_for_syntax": false,
+
 	"trim_trailing_white_space_on_save": "none"
 }

syntaxes/MultiMarkdown.sublime-settings

@@ -1,3 +1,6 @@
 {
+	// Disable ST's default view name assigner
+	"set_unsaved_view_name_for_syntax": false,
+
 	"trim_trailing_white_space_on_save": "none"
 }