Revert get_sublime_exe() to return str again

Fixes #1635

Main use cases are forming command line arguments, etc.
Hence returning `Path` object is probably just overhead, causing issues.

Author: deathaxe

latextools/utils/sublime_utils.py

@@ -32,7 +32,7 @@ def focus():
     sublime.set_timeout(focus, int(wait_time * 1000))
 
 
-def get_sublime_exe() -> Path:
+def get_sublime_exe() -> str:
     """
     Get the full path to the currently executing Sublime instance.
 
@@ -42,8 +42,8 @@ def get_sublime_exe() -> Path:
     platform = sublime.platform()
     plat_settings = cast(dict, get_setting(platform, {}))
     sublime_executable = plat_settings.get("sublime_executable")
-    if sublime_executable:
-        return Path(sublime_executable)
+    if sublime_executable and isinstance(sublime_executable, str):
+        return sublime_executable
 
     # we cache the results of the other checks, if possible
     if hasattr(get_sublime_exe, "result"):
@@ -62,7 +62,7 @@ def get_sublime_exe() -> Path:
     elif platform == "windows":
         executable = executable.parent / "subl.exe"
 
-    get_sublime_exe.result = executable
+    get_sublime_exe.result = str(executable)
     return get_sublime_exe.result
 
 

plugins/viewer/command_viewer.py

@@ -56,7 +56,7 @@ def _replace_vars(self, s, pdf_file, tex_file=None, line="", col=""):
         if not self.CONTAINS_VARIABLE.search(s):
             return (s, False)
 
-        sublime_binary = get_sublime_exe() or ""
+        sublime_binary = get_sublime_exe()
 
         pdf_file_path = os.path.split(pdf_file)[0]
         pdf_file_name = os.path.basename(pdf_file)

plugins/viewer/sioyek_viewer.py

@@ -46,7 +46,7 @@ def forward_sync(self, pdf_file, tex_file, line, col, **kwargs):
             "--forward-search-column",
             f"{col}",
             "--inverse-search",
-            f'\"{get_sublime_exe()}\" \"%1:%2\"',
+            f'"{get_sublime_exe()}" "%1:%2"',
             pdf_file,
             **kwargs
         )