Use built-in "append" to add content to build output

The `append` command is what ST's default build executor uses to add content
to otherwise read-only build output and scroll to the end.

Author: deathaxe

latextools/make_pdf.py

@@ -40,7 +40,6 @@
 
 __all__ = [
     "LatextoolsMakePdfCommand",
-    "LatextoolsDoOutputEditCommand",
     "LatextoolsDoFinishEditCommand",
     "LatextoolsExecEventListener",
 ]
@@ -561,8 +560,9 @@ def run(
     def output(self, data):
         if isinstance(data, (list, tuple)):
             data = "\n".join(data)
-        data = data.replace("\r\n", "\n").replace("\r", "\n")
-        self.output_view.run_command("latextools_do_output_edit", {"data": data})
+        self.output_view.run_command(
+            "append", {"characters": data, "force": True, "scroll_to_end": True}
+        )
 
     def show_output_panel(self, force=False):
         if force or self.hide_panel_level != "always":
@@ -703,18 +703,6 @@ def hide_annotations(self):
         self.show_errors_inline = False
 
 
-class LatextoolsDoOutputEditCommand(sublime_plugin.TextCommand):
-    def run(self, edit, data):
-        view = self.view
-        sel = view.sel()
-        sel_at_end = len(sel) == 1 and sel[0].end() == view.size()
-        view.set_read_only(False)
-        view.insert(edit, view.size(), data)
-        view.set_read_only(True)
-        if sel_at_end:
-            view.show(view.size())
-
-
 class LatextoolsDoFinishEditCommand(sublime_plugin.TextCommand):
     def run(self, edit):
         self.view.sel().clear()

plugin.py

@@ -89,7 +89,6 @@
 )
 from .latextools.make_pdf import (
     LatextoolsMakePdfCommand,
-    LatextoolsDoOutputEditCommand,
     LatextoolsDoFinishEditCommand,
     LatextoolsExecEventListener,
 )