Skip to content

Commit 2cfba5b

Browse files
authored
Merge pull request #253 from SubtitleEdit/github-actions
Update artifact upload workflow
2 parents dccc120 + fa1fb85 commit 2cfba5b

File tree

5 files changed

+194
-200
lines changed

5 files changed

+194
-200
lines changed

.github/workflows/main.yml

Lines changed: 35 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,14 @@ on:
44
push:
55
branches:
66
- main
7+
- github-actions
78
pull_request:
89
branches:
910
- main
1011

1112
jobs:
12-
build:
13+
build-job:
1314
runs-on: windows-latest
14-
# strategy:
15-
# matrix:
16-
# plugin: [ 'NoRecursiveDash', 'HIColorer', 'HI2UC', 'LinesUnbreaker' ]
1715

1816
steps:
1917
# Checkout the repository
@@ -41,21 +39,40 @@ jobs:
4139

4240
# Build the solution
4341
- name: Build solution
44-
run: msbuild "source\Plugins.Filter.slnf" /p:Configuration=Release /p:SkipSharedProject=true
42+
run: msbuild "source\Plugins.Filter.slnf" /p:Configuration=Release
4543

44+
# Copy dll to target directory
4645
- name: Create archives
4746
shell: pwsh
4847
run: source\zip-plugin-files.ps1
49-
50-
# - name: Upload Artifact (All)
51-
# uses: actions/upload-artifact@v4
52-
# with:
53-
# name: Plugins
54-
# path: C:\plugins\*.dll
55-
call-upload-artifacts-workflow:
56-
- use: ./github/workflows/upload-artifacts.yml
57-
# - name: Upload Artifact
58-
# uses: actions/upload-artifact@v4
59-
# with:
60-
# name: ${{matrix.plugin}}
61-
# path: C:\plugins\${{matrix.plugin}}.dll
48+
49+
# Upload plugins/artifacts
50+
- name: Upload HI2UC
51+
uses: actions/upload-artifact@v4
52+
with:
53+
name: HI2UC
54+
path: C:\plugins\HI2UC.dll
55+
56+
- name: Upload HIColorer
57+
uses: actions/upload-artifact@v4
58+
with:
59+
name: HIColorer
60+
path: C:\plugins\HIColorer.dll
61+
62+
- name: Upload TightHyphen
63+
uses: actions/upload-artifact@v4
64+
with:
65+
name: TightHyphen
66+
path: C:\plugins\TightHyphen.dll
67+
68+
- name: Upload NoRecursiveDash
69+
uses: actions/upload-artifact@v4
70+
with:
71+
name: NoRecursiveDash
72+
path: C:\plugins\NoRecursiveDash.dll
73+
74+
- name: Upload LinesUnbreaker
75+
uses: actions/upload-artifact@v4
76+
with:
77+
name: LinesUnbreaker
78+
path: C:\plugins\LinesUnbreaker.dll

.github/workflows/upload-artifacts.yml

Lines changed: 0 additions & 18 deletions
This file was deleted.

source/DictionariesProvider/Forms/Main.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using Newtonsoft.Json;
2-
using Nikse.SubtitleEdit.PluginLogic.Helpers;
1+
using Nikse.SubtitleEdit.PluginLogic.Helpers;
32
using Nikse.SubtitleEdit.PluginLogic.Models;
43
using System;
54
using System.Collections.Generic;
@@ -9,6 +8,7 @@
98
using System.Threading.Tasks;
109
using System.Windows.Forms;
1110
using System.Xml.Linq;
11+
using Newtonsoft.Json;
1212

1313
namespace Nikse.SubtitleEdit.PluginLogic.Forms
1414
{
Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
3-
<PropertyGroup Label="Globals">
4-
<ProjectGuid>59aa41aa-6c3e-456f-8ec1-3c0c90e31811</ProjectGuid>
5-
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
6-
</PropertyGroup>
7-
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
8-
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\CodeSharing\Microsoft.CodeSharing.Common.Default.props" />
9-
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\CodeSharing\Microsoft.CodeSharing.Common.props" />
10-
<PropertyGroup />
11-
<Import Project="Plugin-Shared.projitems" Label="Shared" Condition="'$(SkipSharedProject)' != 'true'"/>
12-
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\CodeSharing\Microsoft.CodeSharing.CSharp.targets" />
3+
<PropertyGroup Label="Globals">
4+
<ProjectGuid>59aa41aa-6c3e-456f-8ec1-3c0c90e31811</ProjectGuid>
5+
<MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
6+
</PropertyGroup>
7+
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')"/>
8+
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\CodeSharing\Microsoft.CodeSharing.Common.Default.props"/>
9+
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\CodeSharing\Microsoft.CodeSharing.Common.props"/>
10+
<Import Project="Plugin-Shared.projitems" Label="Shared"/>
11+
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\CodeSharing\Microsoft.CodeSharing.CSharp.targets"/>
1312
</Project>

0 commit comments

Comments
 (0)