Refactor ListView for better performance and add cancellation handling.

Replaced default ListView with a DoubleBufferedListView to improve UI performance during updates. Introduced cancellation handling for long-running tasks, ensuring resources are properly disposed and user actions are responsive. Adjusted LmStudioClient parameters for clarity and consistency.

Author: ivandrofly

source/Commas/Controls/DoubleBufferedListView.cs

@@ -0,0 +1,9 @@
+namespace Nikse.SubtitleEdit.PluginLogic.Controls;
+
+public class DoubleBufferedListView : ListView
+{
+    public DoubleBufferedListView()
+    {
+        DoubleBuffered = true;
+    }
+}

source/Commas/Main.Designer.cs

@@ -7,45 +7,85 @@ namespace Commas;
 public partial class Main : Form
 {
     private readonly Subtitle _subtitle;
+    private volatile bool _isProcessing;
 
     public Main(Subtitle subtitle)
     {
         _subtitle = subtitle;
         InitializeComponent();
 
         buttonOkay.DialogResult = DialogResult.OK;
+
+        Closing += (sender, args) => { _ = CancelAndDisposeResources(); };
+    }
+
+    private bool CancelAndDisposeResources()
+    {
+        if (_isProcessing)
+        {
+            _cancellationTokenSource.Cancel();
+            _cancellationTokenSource.Dispose();
+            _isProcessing = false;
+            return true;
+        }
+
+        return false;
     }
 
     private CancellationTokenSource _cancellationTokenSource;
 
     private async void buttonFixComma_Click(object sender, EventArgs e)
     {
+        if (CancelAndDisposeResources())
+        {
+            return;
+        }
 
         using var lmStudioClient = new LmStudioClient(textBoxEndPoint.Text, textBoxPrompt.Text);
 
         // listView1.BeginUpdate();
         _cancellationTokenSource = new CancellationTokenSource();
 
-        IProgress<ListViewItem> progress = new Progress<ListViewItem>(listViewItem =>
+        var previousPercentage = 0;
+        IProgress<(ListViewItem, int)> progress = new Progress<(ListViewItem listViewItem, int index)>(item =>
         {
-            listView1.Items.Add(listViewItem);
-            listView1.Refresh();
+            listView1.Items.Add(item.listViewItem);
+
+            var percentage = (item.index * 100 / _subtitle.Paragraphs.Count);
+            // refresh every 5%
+            if (percentage != previousPercentage && percentage % 5 == 0)
+            {
+                listView1.Refresh();
+                previousPercentage = percentage;
+            }
         });
-        await Task.Run(async () =>
+
+        try
         {
-            foreach (var paragraph in _subtitle.Paragraphs)
+            await Task.Run(async () =>
             {
-                var output = await lmStudioClient.SendAsync(paragraph.Text).ConfigureAwait(false);
-
-                if (!output.Equals(paragraph.Text, StringComparison.Ordinal))
+                _isProcessing = true;
+                for (var index = 0; index < _subtitle.Paragraphs.Count; index++)
                 {
-                    progress.Report(new ListViewItem(paragraph.Text)
+                    if (_cancellationTokenSource.IsCancellationRequested)
+                    {
+                        _cancellationTokenSource.Token.ThrowIfCancellationRequested();
+                    }
+
+                    var paragraph = _subtitle.Paragraphs[index];
+                    var output = await lmStudioClient.SendAsync(paragraph.Text).ConfigureAwait(false);
+
+                    if (!output.Equals(paragraph.Text, StringComparison.Ordinal))
                     {
-                        SubItems = { output, }
-                    });
+                        progress.Report((new ListViewItem(new[] { paragraph.Text, output }), index));
+                    }
                 }
-            }
-        }, _cancellationTokenSource.Token);
+            }, _cancellationTokenSource.Token).ConfigureAwait(false);
+        }
+        catch (Exception exception)
+        {
+            Console.WriteLine(exception);
+        }
         // listView1.EndUpdate();
     }
 }

source/Commas/Main.cs

@@ -22,24 +22,23 @@ public LmStudioClient(string url, string prompt)
     public async Task<string> SendAsync(string text)
     {
         /*
-         * curl http://0.0.0.0:1234/v1/chat/completions \
-  -H "Content-Type: application/json" \
-  -d '{
-    "model": "deepseek-r1-distill-qwen-7b",
-    "messages": [
-      { "role": "system", "content": "Always answer in rhymes." },
-      { "role": "user", "content": "Introduce yourself." }
-    ],
-    "temperature": 0.7,
-    "max_tokens": -1,
-    "stream": true
-  }'
-
+          curl http://0.0.0.0:1234/v1/chat/completions \
+          -H "Content-Type: application/json" \
+          -d '{
+            "model": "deepseek-r1-distill-qwen-7b",
+            "messages": [
+              { "role": "system", "content": "Always answer in rhymes." },
+              { "role": "user", "content": "Introduce yourself." }
+            ],
+            "temperature": 0.7,
+            "max_tokens": -1,
+            "stream": true
+          }'
          */
 
         var chatCompletionRequest = new ChatCompletionRequest(false, new[]
         {
-            new Message("user", $"{_prompt}:\n\"{text}\""),
+            new Message("user", $"{_prompt}:\n\n{text}"),
             new Message("system", "You are a helpful assistant.")
         }, 0.7);