Merge branch 'refactoring/remove-warnings' into develop

SubvertDev · SubvertDev · commit 5eab201fc19f · 2025-11-30T00:05:13.000+03:00
diff --git a/Modules/Sources/AppFeature/AppFeature.swift b/Modules/Sources/AppFeature/AppFeature.swift
@@ -399,7 +399,7 @@ public struct AppFeature: Reducer, Sendable {
                 
                 // MARK: - Deeplinks
                 
-                #warning("merge these two actions somehow")
+                // TODO: Merge these two actions below somehow
                 
             case let .deeplink(url):
                 do {
diff --git a/Modules/Sources/AppFeature/Navigation/Path.swift b/Modules/Sources/AppFeature/Navigation/Path.swift
@@ -24,7 +24,7 @@ import SettingsFeature
 import TopicFeature
 import AuthFeature
 
-@Reducer(state: .equatable)
+@Reducer
 public enum Path {
     case articles(Articles.Body = Articles.body)
     case favorites(FavoritesRootFeature)
@@ -34,42 +34,49 @@ public enum Path {
     case qms(QMS.Body = QMS.body)
     case auth(AuthFeature)
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Articles {
         case articlesList(ArticlesListFeature)
         case article(ArticleFeature)
     }
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Profile {
         case profile(ProfileFeature)
         case history(HistoryFeature)
         case reputation(ReputationFeature)
     }
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Forum {
         case forumList(ForumsListFeature)
         case forum(ForumFeature)
         case announcement(AnnouncementFeature)
         case topic(TopicFeature)
     }
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Settings {
         case settings(SettingsFeature)
         case navigation(NavigationSettingsFeature)
         case notifications(NotificationsFeature)
         case developer(DeveloperFeature)
     }
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum QMS {
         case qmsList(QMSListFeature)
         case qms(QMSFeature)
     }
 }
 
+extension Path.State: Equatable {}
+extension Path.Articles.State: Equatable {}
+extension Path.Profile.State: Equatable {}
+extension Path.Forum.State: Equatable {}
+extension Path.Settings.State: Equatable {}
+extension Path.QMS.State: Equatable {}
+
 extension Path {
     @MainActor @ViewBuilder
     public static func view(_ store: Store<Path.State, Path.Action>) -> some View {
diff --git a/Modules/Sources/AppFeature/Navigation/StackTab.swift b/Modules/Sources/AppFeature/Navigation/StackTab.swift
@@ -295,7 +295,7 @@ public struct StackTab: Reducer, Sendable {
     private func handleAuthNavigation(action: AuthFeature.Action, state: inout State) -> Effect<Action> {
         // Also make necessary changes to delegate actions in AppFeature
         switch action {
-        case let .delegate(.loginSuccess(reason, userId)):
+        case .delegate(.loginSuccess(_, _)):
             fatalError("Auth navigation must be handled in ProfileFlow enum reducer")
             
         case .delegate(.showSettings):
diff --git a/Modules/Sources/ArticleFeature/ArticleFeature.swift b/Modules/Sources/ArticleFeature/ArticleFeature.swift
@@ -37,7 +37,7 @@ public struct ArticleFeature: Reducer, Sendable {
     
     // MARK: - Destinations
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Destination: Hashable {
         @ReducerCaseIgnored
         case share(URL)
@@ -465,6 +465,8 @@ public struct ArticleFeature: Reducer, Sendable {
     }
 }
 
+extension ArticleFeature.Destination.State: Equatable {}
+
 // MARK: - Alert Extension
 
 extension AlertState where Action == ArticleFeature.Destination.Alert {
diff --git a/Modules/Sources/ArticlesListFeature/ArticlesListFeature.swift b/Modules/Sources/ArticlesListFeature/ArticlesListFeature.swift
@@ -46,7 +46,7 @@ public struct ArticlesListFeature: Reducer, Sendable {
     
     // MARK: - Destinations
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Destination: Hashable {
         @ReducerCaseIgnored
         case share(URL)
@@ -254,3 +254,5 @@ public struct ArticlesListFeature: Reducer, Sendable {
         return .none
     }
 }
+
+extension ArticlesListFeature.Destination.State: Equatable {}
diff --git a/Modules/Sources/BBBuilder/Builder/BBBuilder.swift b/Modules/Sources/BBBuilder/Builder/BBBuilder.swift
@@ -161,8 +161,8 @@ public struct BBBuilder {
                 }
                 
             case .img:
+                // TODO: Finish image case
                 logger.info("Image case")
-                #warning("todo")
                 mergedNodes.lastOrAppend = unwrap(node: node, with: mutableText)
                 
             case let .attachment(attribute):
diff --git a/Modules/Sources/ForumsListFeature/ForumsListFeature.swift b/Modules/Sources/ForumsListFeature/ForumsListFeature.swift
@@ -101,7 +101,8 @@ public struct ForumsListFeature: Reducer, Sendable {
                 reportFullyDisplayed(&state)
                 
             case let .internal(.forumsListResponse(.failure(error))):
-                #warning("add toast")
+                print(error)
+                // TODO: Add toast
                 reportFullyDisplayed(&state)
                 
             case .delegate:
diff --git a/Modules/Sources/ProfileFeature/Edit/EditFeature.swift b/Modules/Sources/ProfileFeature/Edit/EditFeature.swift
@@ -27,7 +27,7 @@ public struct EditFeature: Reducer, Sendable {
     
     // MARK: - Destinations
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Destination: Hashable, Equatable {
         case alert(AlertState<Alert>)
         case avatarPicker
@@ -226,6 +226,8 @@ public struct EditFeature: Reducer, Sendable {
     }
 }
 
+extension EditFeature.Destination.State: Equatable {}
+
 private extension Date {
     func toProfileString() -> String {
         let dateFormatter = DateFormatter()
diff --git a/Modules/Sources/ProfileFeature/ProfileFeature.swift b/Modules/Sources/ProfileFeature/ProfileFeature.swift
@@ -27,7 +27,7 @@ public struct ProfileFeature: Reducer, Sendable {
     
     // MARK: - Destinations
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Destination {
         case alert(AlertState<ProfileFeature.Action.Alert>)
         case editProfile(EditFeature)
@@ -198,6 +198,8 @@ public struct ProfileFeature: Reducer, Sendable {
     }
 }
 
+extension ProfileFeature.Destination.State: Equatable {}
+
 // MARK: - Alert Extension
 
 private extension AlertState where Action == ProfileFeature.Action.Alert {
diff --git a/Modules/Sources/ReputationFeature/ReputationFeature.swift b/Modules/Sources/ReputationFeature/ReputationFeature.swift
@@ -17,7 +17,7 @@ public struct ReputationFeature: Reducer, Sendable {
     
     // MARK: - Destinations
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Destination: Hashable {
         case alert(AlertState<Alert>)
         
@@ -164,6 +164,7 @@ public struct ReputationFeature: Reducer, Sendable {
                 return .none
                 
             case let .internal(.historyResponse(.failure(error))):
+                print(error)
                 state.isLoading = false
                 state.destination = .alert(.error)
                 reportFullyDisplayed(&state)
@@ -182,6 +183,8 @@ public struct ReputationFeature: Reducer, Sendable {
     }
 }
 
+extension ReputationFeature.Destination.State: Equatable {}
+
 // MARK: - Alert Extension
 
 extension AlertState where Action == ReputationFeature.Destination.Alert {
diff --git a/Modules/Sources/SettingsFeature/SettingsFeature.swift b/Modules/Sources/SettingsFeature/SettingsFeature.swift
@@ -20,7 +20,7 @@ public struct SettingsFeature: Reducer, Sendable {
     
     // MARK: - Destinations
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Destination {
         case alert(AlertState<SettingsFeature.Action.Alert>)
     }
@@ -249,6 +249,8 @@ public struct SettingsFeature: Reducer, Sendable {
     }
 }
 
+extension SettingsFeature.Destination.State: Equatable {}
+
 // MARK: - Alert Extensions
 
 private extension AlertState where Action == SettingsFeature.Action.Alert {
diff --git a/Modules/Sources/TopicBuilder/TopicView.swift b/Modules/Sources/TopicBuilder/TopicView.swift
@@ -582,10 +582,9 @@ struct HideView: View {
         }
         .animation(.default, value: isShown)
         .task {
-            #warning("What is happening here?")
             @Dependency(\.cacheClient) var cache
             if let userId = shouldLoadUser, let info {
-                if let currentUser = await cache.getUser(userId) {
+                if let currentUser = cache.getUser(userId) {
                     if currentUser.replies >= info {
                         isShown = true
                     }
diff --git a/Modules/Sources/TopicFeature/Models/JumpTo.swift b/Modules/Sources/TopicFeature/Models/JumpTo.swift
@@ -0,0 +1,32 @@
+//
+//  JumpTo.swift
+//  ForPDA
+//
+//  Created by Ilia Lubianoi on 29.11.2025.
+//
+
+import APIClient
+
+public enum JumpTo: Sendable {
+    case unread
+    case last
+    case post(id: Int)
+    case page(Int)
+    
+    var postId: Int {
+        switch self {
+        case .unread, .last: return 0
+        case .post(let id):  return id
+        case .page:          fatalError("Unsupported interaction")
+        }
+    }
+    
+    var type: JumpForumRequest.ForumJumpType {
+        switch self {
+        case .unread: return .new
+        case .last:   return .last
+        case .post:   return .post
+        case .page:   fatalError("Unsupported interaction")
+        }
+    }
+}
diff --git a/Modules/Sources/TopicFeature/TopicFeature.swift b/Modules/Sources/TopicFeature/TopicFeature.swift
@@ -40,7 +40,7 @@ public struct TopicFeature: Reducer, Sendable {
     
     // MARK: - Destinations
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Destination {
         @ReducerCaseIgnored
         case gallery([URL], [Int], Int)
@@ -571,31 +571,6 @@ public struct TopicFeature: Reducer, Sendable {
         }
     }
     
-    #warning("move")
-    public enum JumpTo: Sendable {
-        case unread
-        case last
-        case post(id: Int)
-        case page(Int)
-        
-        var postId: Int {
-            switch self {
-            case .unread, .last: return 0
-            case let .post(id):  return id
-            case .page: fatalError("Unsupported interaction")
-            }
-        }
-        
-        var type: JumpForumRequest.ForumJumpType {
-            switch self {
-            case .unread: return .new
-            case .last:   return .last
-            case .post:   return .post
-            case .page:   fatalError("Unsupported interaction")
-            }
-        }
-    }
-    
     public func jumpTo(_ jump: JumpTo, _ forceRefresh: Bool, _ state: inout State) -> Effect<Action> {
         if case let .page(page) = jump {
             return reduce(into: &state, action: .pageNavigation(.goToPage(newPage: page)))
@@ -630,6 +605,8 @@ public struct TopicFeature: Reducer, Sendable {
     }
 }
 
+extension TopicFeature.Destination.State: Equatable {}
+
 func measureElapsedTime(_ operation: () throws -> Void) throws -> UInt64 {
     let startTime = DispatchTime.now()
     try operation()
diff --git a/Modules/Sources/WriteFormFeature/WriteFormFeature.swift b/Modules/Sources/WriteFormFeature/WriteFormFeature.swift
@@ -25,7 +25,7 @@ public struct WriteFormFeature: Reducer, Sendable {
     
     // MARK: - Destinations
     
-    @Reducer(state: .equatable)
+    @Reducer
     public enum Destination {
         case preview(FormPreviewFeature)
         case alert(AlertState<Alert>)
@@ -316,6 +316,7 @@ public struct WriteFormFeature: Reducer, Sendable {
     }
 }
 
+extension WriteFormFeature.Destination.State: Equatable {}
 
 // MARK: - Alert Extension
 
diff --git a/Project.swift b/Project.swift
@@ -815,9 +815,9 @@ extension Dictionary where Key == String, Value == SettingValue {
 extension Array where Element == String {
     static let longTypeCheckingFlags = [
         "-Xfrontend",
-        "-warn-long-function-bodies=600",
+        "-warn-long-function-bodies=700",
         "-Xfrontend",
-        "-warn-long-expression-type-checking=100"
+        "-warn-long-expression-type-checking=150"
     ]
 }
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public struct ArticleFeature: Reducer, Sendable {`
`37`	`37`
`38`	`38`	`// MARK: - Destinations`
`39`	`39`
`40`		`- @Reducer(state: .equatable)`
	`40`	`+ @Reducer`
`41`	`41`	`public enum Destination: Hashable {`
`42`	`42`	`@ReducerCaseIgnored`
`43`	`43`	`case share(URL)`
`@@ -465,6 +465,8 @@ public struct ArticleFeature: Reducer, Sendable {`
`465`	`465`	`}`
`466`	`466`	`}`
`467`	`467`
	`468`	`+extension ArticleFeature.Destination.State: Equatable {}`
	`469`	`+`
`468`	`470`	`// MARK: - Alert Extension`
`469`	`471`
`470`	`472`	`extension AlertState where Action == ArticleFeature.Destination.Alert {`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public struct ArticlesListFeature: Reducer, Sendable {`
`46`	`46`
`47`	`47`	`// MARK: - Destinations`
`48`	`48`
`49`		`- @Reducer(state: .equatable)`
	`49`	`+ @Reducer`
`50`	`50`	`public enum Destination: Hashable {`
`51`	`51`	`@ReducerCaseIgnored`
`52`	`52`	`case share(URL)`
`@@ -254,3 +254,5 @@ public struct ArticlesListFeature: Reducer, Sendable {`
`254`	`254`	`return .none`
`255`	`255`	`}`
`256`	`256`	`}`
	`257`	`+`
	`258`	`+extension ArticlesListFeature.Destination.State: Equatable {}`
Original file line number	Diff line number	Diff line change
`@@ -161,8 +161,8 @@ public struct BBBuilder {`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`case .img:`
	`164`	`+ // TODO: Finish image case`
`164`	`165`	`logger.info("Image case")`
`165`		`- #warning("todo")`
`166`	`166`	`mergedNodes.lastOrAppend = unwrap(node: node, with: mutableText)`
`167`	`167`
`168`	`168`	`case let .attachment(attribute):`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public struct EditFeature: Reducer, Sendable {`
`27`	`27`
`28`	`28`	`// MARK: - Destinations`
`29`	`29`
`30`		`- @Reducer(state: .equatable)`
	`30`	`+ @Reducer`
`31`	`31`	`public enum Destination: Hashable, Equatable {`
`32`	`32`	`case alert(AlertState<Alert>)`
`33`	`33`	`case avatarPicker`
`@@ -226,6 +226,8 @@ public struct EditFeature: Reducer, Sendable {`
`226`	`226`	`}`
`227`	`227`	`}`
`228`	`228`
	`229`	`+extension EditFeature.Destination.State: Equatable {}`
	`230`	`+`
`229`	`231`	`private extension Date {`
`230`	`232`	`func toProfileString() -> String {`
`231`	`233`	`let dateFormatter = DateFormatter()`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public struct ProfileFeature: Reducer, Sendable {`
`27`	`27`
`28`	`28`	`// MARK: - Destinations`
`29`	`29`
`30`		`- @Reducer(state: .equatable)`
	`30`	`+ @Reducer`
`31`	`31`	`public enum Destination {`
`32`	`32`	`case alert(AlertState<ProfileFeature.Action.Alert>)`
`33`	`33`	`case editProfile(EditFeature)`
`@@ -198,6 +198,8 @@ public struct ProfileFeature: Reducer, Sendable {`
`198`	`198`	`}`
`199`	`199`	`}`
`200`	`200`
	`201`	`+extension ProfileFeature.Destination.State: Equatable {}`
	`202`	`+`
`201`	`203`	`// MARK: - Alert Extension`
`202`	`204`
`203`	`205`	`private extension AlertState where Action == ProfileFeature.Action.Alert {`