File tree Expand file tree Collapse file tree 4 files changed +10
-48
lines changed
FavoritesFeature/Analytics Expand file tree Collapse file tree 4 files changed +10
-48
lines changed Original file line number Diff line number Diff line change @@ -28,11 +28,6 @@ public enum FavoritesEvent: Event {
2828 case sortCancelButtonTapped
2929 case sortTypeSelected( String )
3030
31- case loadingStart( Int )
32- case loadingSuccess
33- case loadingFailure( any Error )
34- case startUnreadLoadingIndicator( Int )
35-
3631 public var name : String {
3732 return " Favorites " + eventName( for: self ) . inProperCase
3833 }
@@ -68,15 +63,6 @@ public enum FavoritesEvent: Event {
6863 case let . sortTypeSelected( type) :
6964 return [ " type " : type]
7065
71- case let . loadingStart( offset) :
72- return [ " offset " : String ( offset) ]
73-
74- case let . loadingFailure( error) :
75- return [ " error " : error. localizedDescription]
76-
77- case let . startUnreadLoadingIndicator( id) :
78- return [ " id " : String ( id) ]
79-
8066 default :
8167 return nil
8268 }
Original file line number Diff line number Diff line change @@ -30,11 +30,6 @@ public enum TopicEvent: Event {
3030 case menuChangeReputation( Int , Int )
3131 case menuPostCopyLink( Int )
3232
33- case loadingStart( Int )
34- case loadingSuccess
35- case loadingFailure( any Error )
36- case setFavoriteResponse( Bool )
37-
3833 public var name : String {
3934 return " Topic " + eventName( for: self ) . inProperCase
4035 }
@@ -58,15 +53,6 @@ public enum TopicEvent: Event {
5853 let . imageTapped( url) :
5954 return [ " url " : url. absoluteString]
6055
61- case let . loadingStart( offset) :
62- return [ " offset " : String ( offset) ]
63-
64- case let . loadingFailure( error) :
65- return [ " error " : error. localizedDescription]
66-
67- case let . setFavoriteResponse( state) :
68- return [ " state " : state. description]
69-
7056 default :
7157 return nil
7258 }
Original file line number Diff line number Diff line change @@ -79,16 +79,11 @@ extension FavoritesFeature {
7979 analytics. log ( FavoritesEvent . sortCancelButtonTapped)
8080 }
8181
82- case let . internal( . favoritesResponse( response) ) :
83- switch response {
84- case . success:
85- analytics. log ( FavoritesEvent . loadingSuccess)
86- case let . failure( error) :
87- analytics. log ( FavoritesEvent . loadingFailure ( error) )
88- }
82+ case . internal( . favoritesResponse) :
83+ break
8984
90- case let . internal( . loadFavorites( offset : offset ) ) :
91- analytics . log ( FavoritesEvent . loadingStart ( offset ) )
85+ case . internal( . loadFavorites) :
86+ break
9287
9388 case . internal( . refresh) :
9489 break
Original file line number Diff line number Diff line change @@ -90,19 +90,14 @@ extension TopicFeature {
9090 case . view( . editWarningSheetCloseButtonTapped) :
9191 analytics. log ( TopicEvent . editWarningSheetClosed)
9292
93- case let . internal( . loadTopic( offset : offset ) ) :
94- analytics . log ( TopicEvent . loadingStart ( offset ) )
93+ case . internal( . loadTopic) :
94+ break
9595
96- case let . internal( . topicResponse( response) ) :
97- switch response {
98- case . success:
99- analytics. log ( TopicEvent . loadingSuccess)
100- case let . failure( error) :
101- analytics. log ( TopicEvent . loadingFailure ( error) )
102- }
96+ case . internal( . topicResponse) :
97+ break
10398
104- case let . internal( . setFavoriteResponse( response ) ) :
105- analytics . log ( TopicEvent . setFavoriteResponse ( response ) )
99+ case . internal( . setFavoriteResponse) :
100+ break
106101 }
107102
108103 return . none
You can’t perform that action at this time.
0 commit comments