Fix static assets app icon linking

Author: SubvertDev

Configs/App.xcconfig

@@ -1,4 +1,4 @@
 #include "Secrets.xcconfig"
 MARKETING_VERSION = 0.8.0
 CURRENT_PROJECT_VERSION = 817
-ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon-Stable
+RELEASE_CHANNEL = Stable

Fastlane/Fastfile

@@ -39,16 +39,15 @@ platform :ios do
     desc "Uploads to TestFlight"
     lane :upload do |options|
         print_lane_options("Uploads to Testflight", {
-            scheme: { desctiption: "Scheme: beta or stable", default: "beta" }   
+            release: { desctiption: "Release channel: beta or stable", default: "beta" }   
         })
 
-        scheme = options[:scheme] || "beta"
-        appIconName = "AppIcon-#{scheme.capitalize}"
+        release_channel = (options[:release] || "beta").capitalize
 
         update_xcconfig_value(
             path: 'Configs/App.xcconfig',
-            name: 'ASSETCATALOG_COMPILER_APPICON_NAME',
-            value: appIconName
+            name: 'RELEASE_CHANNEL',
+            value: release_channel
         )
 
         prepare_certificates
@@ -68,15 +67,15 @@ platform :ios do
     lane :upload_oneoff do |options|
         print_lane_options("One-off upload to TF without tests/notify/bump", {
             build_number: { description: "Sets specific build number" },
-            scheme: { desctiption: "Scheme: beta or stable.", default: "beta" }
+            release: { desctiption: "Release channel: beta or stable", default: "beta" }   
         })
 
-        scheme = options[:scheme] || "beta"
+        release_channel = (options[:release] || "beta").capitalize
 
         update_xcconfig_value(
             path: 'Configs/App.xcconfig',
-            name: 'ASSETCATALOG_COMPILER_APPICON_NAME',
-            value: 'AppIcon-#{scheme.capitalize}'
+            name: 'RELEASE_CHANNEL',
+            value: release_channel
         )
 
         prepare_certificates

Project.swift

@@ -649,7 +649,7 @@ extension ProjectDescription.Target {
             dependencies: dependencies,
             settings: .settings(
                 base: .targetSettings,
-                defaultSettings: .recommended(excluding: ["ASSETCATALOG_COMPILER_APPICON_NAME"])
+                defaultSettings: .recommended
             )
         )
     }
@@ -727,7 +727,7 @@ extension Dictionary where Key == String, Value == SettingValue {
     }
 
     func includeAppIcon() -> SettingsDictionary {
-        return merging(["ASSETCATALOG_COMPILER_APPICON_NAME": .string("$(ASSETCATALOG_COMPILER_APPICON_NAME)")])
+        return merging(["ASSETCATALOG_COMPILER_APPICON_NAME": .string("AppIcon-$(RELEASE_CHANNEL)")])
     }
 
     func excludeAppIcon() -> SettingsDictionary {