-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathdummy_comments.csv
More file actions
We can't make this file beautiful and searchable because it's too large.
3402 lines (3402 loc) · 711 KB
/
dummy_comments.csv
File metadata and controls
3402 lines (3402 loc) · 711 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
"createdAt","body"
"2022-11-09 09:36:04.032536+00","yes, edited"
"2022-11-07 18:44:59.757591+00","```suggestion ```"
"2022-11-08 16:20:59.662478+00","@lcolston08 "
"2022-11-09 09:36:04.032536+00","yes, edited"
"2022-11-02 17:35:11.766522+00","Agree, we can create a util just for this."
"2022-11-02 18:41:11.029451+00","such a boss"
"2022-11-02 18:42:13.48715+00","This prevents the OSX `.DS_Store` from being checked into git."
"2022-11-03 08:13:02.482488+00","Add a description of this page?"
"2022-11-03 20:32:20.188195+00","I changed this to `lab`"
"2022-11-07 16:44:39.554285+00","what's this?"
"2022-11-07 22:01:15.252477+00","```suggestion * Files other than UTF-8 are excluded ```"
"2022-11-08 01:15:14.019467+00","I tried to reorder this and made proposals below"
"2022-11-08 10:05:24.972697+00","@FaridGitStart delete this empty first line"
"2022-11-08 16:24:24.423394+00","Thanks. Resolving this conversation. "
"2022-11-09 21:52:15.500752+00","this comment should be removed"
"2022-11-11 06:32:25.018098+00","Shouldn't we be using it? Why not?"
"2022-11-02 06:22:17.221404+00","```suggestion # Environment variables ```"
"2022-11-02 16:13:04.910913+00","nit: make `name.split(' ')[0]` a const"
"2022-11-03 20:32:44.411203+00","Updated descriptions to add this info"
"2022-11-03 20:34:10.346852+00","Added this test case"
"2022-11-03 20:34:20.108443+00","Updated descriptions to add this info"
"2022-11-03 20:34:25.721771+00","Updated descriptions to add this info"
"2022-11-03 22:28:37.971393+00","Yes definitely agree! Great catch, thanks JR"
"2022-11-03 22:36:48.611793+00","uh... is this missing `@orthly/critical-path`? I'm unclear what a name on a line by itself does"
"2022-11-07 22:05:02.835441+00","Are we indexing code from code hosts other than GitHub on dot com?"
"2022-11-08 00:40:24.01431+00","Can the router be placed inside of the ComponentsComposer components list?"
"2022-11-08 07:19:24.291443+00","Is the Sentry significant enough to be included in this list? If yes, better include it as well."
"2022-11-08 07:19:24.370954+00","@murcul-coherent Any information can be provided on this?"
"2022-11-08 16:26:25.088922+00","Nuke empty line 3"
"2022-11-09 08:35:20.12241+00","This TODO is outdated, can you remove it?"
"2022-11-09 11:46:35.722742+00","The output is rather ugly, but surely transparent, so 👍 "
"2022-11-09 21:06:49.944994+00","Are these `#region...` sort of tags a new pattern? 👀 "
"2022-11-10 08:07:33.594139+00","Could you please move these to an ""Open questions"" section?"
"2022-11-11 01:55:26.394822+00","This might be difficult as the DB lives in Amazon, is not instrumented AFAIK"
"2022-11-11 01:55:26.924461+00","They are exposed on staging too: https://fly-metrics.net/d/fly-app/fly-app?orgId=42164&var-app=equanimity-stg"
"2022-11-08 16:49:32.99638+00","Should this be compiler-accurate"
"2022-11-08 16:53:51.569579+00","Updated"
"2022-11-11 01:55:26.568007+00","This is called ""Tracing"". https://en.wikipedia.org/wiki/Tracing_(software)"
"2022-11-11 01:55:26.598971+00","What do you mean by `Ecto query strings by default`?"
"2022-11-11 01:55:26.886121+00","+1 to start with this one"
"2022-11-01 12:39:20.330371+00","switching from peer to regular dep?"
"2022-11-01 16:54:28.801757+00","What's the reason for fetching this as the practice rather than as internal or the lab?"
"2022-11-01 17:23:09.061963+00","Out of curiosity, is there an instance where the response would be `undefined` and need the `?`? It seems like it will always response with an object containing `monitors`. If not, we will have an error and drop into the error handler portion."
"2022-11-01 22:13:29.476753+00","Can we do something to `queryExampleSectionsColumns` doesn't do a server call on dotcom?"
"2022-11-02 09:09:01.947567+00","@sourcegraph/dev-experience the generated PRs from this workflow requires stamp approvals + merge"
"2022-11-01 16:54:34.597816+00","```suggestion 'should mark an order as ""In Fabrication"" as ops', ```"
"2022-11-01 17:14:45.235937+00","```suggestion - [REVIEW] Review pull request ```"
"2022-11-01 17:55:09.061623+00","https://gfycat.com/welldocumentedevilindianrhinoceros"
"2022-11-02 10:39:16.708346+00","So can I do it if I am an experienced developer, or repo owner or only the project managers? This is not clear to me. "
"2022-11-03 08:41:13.132313+00","@Mjanuary same here "
"2022-11-02 10:39:54.00296+00","Sorry for late review! If this is already protected in the dashboard, it's fine"
"2022-11-02 10:57:27.258439+00","`specs`? Should be `webhooks`, right?"
"2022-11-02 10:57:27.393911+00","Do you need that?"
"2022-11-03 12:11:39.771464+00","Missing empty new line at the end."
"2022-11-03 16:46:12.782468+00","i first read this as ""prioritized sorted please"" map, which is also a good name"
"2022-11-04 01:58:48.842481+00","yes"
"2022-11-04 16:21:07.078745+00","```suggestion // tslint:disable:max-file-line-count ```"
"2022-11-07 07:36:51.446723+00","```suggestion startGitSlicePull(pull_job: GitSlicePullUpsertOptions!): _some_output ```"
"2022-11-07 15:00:54.2332+00","Lets nuke, we need to resolve eslint errors"
"2022-11-07 15:13:39.08466+00","Add a space above"
"2022-11-07 22:15:30.282628+00","```suggestion GitHub code search does not offer commit diff search or commit message search. ```"
"2022-11-03 16:46:21.874021+00","lolol"
"2022-11-07 22:25:04.793549+00","We're 100% sure that it's 100% accurate?"
"2022-11-07 22:25:48.79112+00","Should use `setFieldValue` instead so that we don't have to explicitly call `clearValue` every time we call this method."
"2022-11-03 16:46:28.121428+00","nice refactor"
"2022-11-07 22:27:06.118314+00","Not sure if this is a necessary row for the end user "
"2022-11-07 22:43:40.154199+00","CC @iskyOS "
"2022-11-07 22:43:48.520393+00","cc @iskyOS "
"2022-11-07 22:43:59.770544+00","cc @iskyOS "
"2022-11-07 22:58:44.726654+00","Yes, for example we have repos from http://src.fedoraproject.org/"
"2022-11-07 15:13:39.072505+00","This file won't exists, move your tests and delete it"
"2022-11-08 00:04:12.593025+00","Thanks. This seems to back up the statement about public repos from multiple code hosts. "
"2022-11-08 05:51:31.132679+00","we don't actually use this anywhere - let's get rid of it"
"2022-11-08 08:11:42.999578+00","@murcul-coherent should be in total 7 types of products, seems the ""participating whole life"" product type is missing? "
"2022-11-10 04:49:11.377318+00","Was there a clear owner/incident commander at this point?"
"2022-11-10 04:49:11.388554+00","Good to have a template for this"
"2022-11-10 08:13:14.328041+00","I added the open questions section, and am also keeping this here to ensure they get answered."
"2022-11-10 16:24:29.123299+00","missing other metadata"
"2022-11-10 18:00:13.267226+00","Maybe I misunderstood how to read those constraints but I thought it would mean 1.1 and any above lol "
"2022-11-11 02:35:40.670261+00","```suggestion - [ ] **File changes:** This PR is expected to result in ≥ 10 file changes ```"
"2022-11-11 09:07:34.940557+00","Oh I mean the raw SQL queries. Appsignal does record them whereas the PromEx metrics do not"
"2022-11-11 10:39:57.102514+00","I have added a custom handler in https://github.com/Murcul/equanimity/pull/623"
"2022-11-11 12:42:02.331213+00","Nice! I think we cab send those notifications to #platform-engineering-alerts just for our team to monitor"
"2022-11-10 18:00:13.670163+00","If not, I wonder if we shouldn't do that and just say here, use 1.1+"
"2022-11-11 02:35:43.185719+00","The other factors make more sense to me"
"2022-11-10 18:00:14.254844+00","I think this is the default, isn't it? "
"2022-11-10 18:29:36.826999+00","Yep it is. I'll remove this section (thought it was not defaulting to `true`)"
"2022-11-10 16:24:29.655658+00","missing other metadata"
"2022-11-11 09:07:38.015153+00","Grafana just reads data from the metrics PromEx collects. It does not collect anything on its own."
"2022-11-10 17:06:12.973331+00","will add it "
"2022-11-10 17:06:20.180126+00","will add it "
"2022-11-11 01:55:27.096325+00","You meant: `while Grafana does not`?"
"2022-11-11 01:55:28.869055+00","I'm not sure if we are using Swap, if we are not even using a swap partition we can remove this alert"
"2022-11-02 13:26:43.681501+00","Should we add a doc, then? Or change the naming somehow?"
"2022-11-03 08:35:20.749293+00","Revert this line"
"2022-11-10 23:30:15.521211+00","```suggestion min-width: 45px; overflow: hidden; ```"
"2022-11-08 15:53:26.237357+00","I'd add a `set -ex` to this, which we use in a lot of scripts: https://sourcegraph.sourcegraph.com/search?q=context%3Aglobal+set+-ex+repo%3Asourcegraph%24&patternType=standard&groupBy=repo "
"2022-11-10 05:05:42.368876+00","I have added the type, please take a look"
"2022-11-11 03:05:23.443375+00","```suggestion export async function getStaticProps({ locale }) { ```"
"2022-11-11 12:04:14.762482+00","https://github.com/sourcegraph/sourcegraph/pull/44275"
"2022-11-01 20:25:33.975795+00","Rename and move under the `// Text` section ```suggestion $color-missing-value: #808080; ```"
"2022-11-02 15:13:42.993769+00","Merge main/revert this file to main"
"2022-11-03 08:06:34.81379+00","```suggestion @spec create_tasks_multi(Ecto.Multi.t(), list(map())) :: Ecto.Multi.t() ```"
"2022-11-03 08:06:34.840587+00","```suggestion @spec get_task!(pos_integer()) :: Task.t() ```"
"2022-11-03 08:06:35.554322+00","Same here. Import and use relative path"
"2022-11-03 08:35:19.012662+00","Revert this line"
"2022-11-03 16:57:58.951511+00","Update docstring: `Alert Delay` -> `Bucket Count`"
"2022-11-04 09:07:42.490298+00","```suggestion @spec get_client!(String.t()) :: Client.t() def get_client!(id), do: Repo.get!(Client, id) ```"
"2022-11-07 08:54:10.957373+00","```suggestion @type role :: :admin | :user | :internal ```"
"2022-11-07 21:43:48.458546+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion /* Causes fanout */ -- , labtrac_production_case_steps.stageitemid -- , labtrac_production_case_steps.pathstepid ``` "
"2022-11-09 23:04:34.824094+00","https://github.com/sourcegraph/sourcegraph/issues/44179"
"2022-11-10 04:11:47.720901+00","```suggestion @spec get_ticket(pos_integer()) :: {:ok, Ticket.t()} | {:error, :ticket_not_found} ```"
"2022-11-10 07:58:10.812473+00","Can you remove the bang in the `get_pull_request_ticket!` function as well?"
"2022-11-11 12:59:56.082479+00","```suggestion * The list of ids of photos that were skipped. ```"
"2022-11-02 09:15:04.712479+00","lol"
"2022-11-02 10:10:59.371521+00","> Suggestion use this  "
"2022-11-03 11:46:08.081244+00","Should we have a feature flag / some other kind of toggle for running this (here, on in CleanUp)?"
"2022-11-04 09:05:27.242503+00","```suggestion @spec list_tasks(map(), pos_integer(), Keyword.t()) :: list(Task.t()) ```"
"2022-11-07 08:58:02.489492+00","@passy4ucj But this [PR](https://github.com/GitStartHQ/client-bluemeg-database-service/pull/4) is not yet merged, this means, this PR will return errors"
"2022-11-04 09:05:28.311199+00","```suggestion @spec get_total_time_spent_in_minutes(Task.t()) :: non_neg_integer() ```"
"2022-11-07 12:07:38.405114+00","```suggestion onInputChange={filterByCities} ```"
"2022-11-07 14:20:39.086032+00","Value should be a boolean"
"2022-11-07 14:45:37.107808+00","Your metadata should include all query params"
"2022-11-07 12:32:37.651501+00","Just a frame of reference to debug when multiple stuff is happening simultaneously. 🙂 "
"2022-11-07 14:20:39.323806+00","Value should be an empty array or undefined"
"2022-11-07 14:45:36.104007+00","Space between words ```suggestion /* Envelope Activities related activity */ ``` "
"2022-11-07 12:39:34.971432+00","@passy4ucj Done!"
"2022-11-08 11:24:59.560934+00","Yes, I was thinking about this too... the `Menu` component doesn't seem to wrap around selection, though maybe that can be configured. > Additionally, I think that menu makes more sense semantically here than listbox anyway since it's not a form control but a menu that lists options that will cause navigation (if the submission is immediate). If the submission was immediate I would agree, but it's not. After reading MDN's description: > A menu generally represents a grouping of common actions or functions that the user can invoke. I felt that a listbox would be a better fit. (That's why a11y is hard :-/) But I don't have strong feelings about this..."
"2022-11-08 21:43:04.551745+00","should we not add a `nexHealthEnabled` var as well? "
"2022-11-08 11:45:08.162484+00","Reverted, thanks for the heads up!"
"2022-11-09 16:13:10.427411+00","```suggestion @spec list_all_tickets_for_developer_query(pos_integer()) :: Ecto.Query.t() ```"
"2022-11-02 16:26:40.766918+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion FROM source ``` "
"2022-11-02 16:26:41.03332+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion SELECT * FROM {{ ref('base_segment_marketing_website_fcpid') }} ``` "
"2022-11-02 16:26:41.698411+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion FROM source ``` "
"2022-11-04 09:45:47.712492+00","Not running in frontend is IMO the way to go because otherwise we horizontally scale this routine for no benefit"
"2022-11-07 09:06:34.226444+00","maybe? ```suggestion return nil, errors.Wrap(err, ""http request failed"") ```"
"2022-11-07 21:50:59.765119+00","tests, sure -- but why should it be static? lol"
"2022-11-08 08:44:39.230194+00","Wrapped error with the repo name is a good idea! Will fix!"
"2022-11-08 16:48:25.81336+00","is there no updated_at field in dialpad users? Will we need to snapshot it?"
"2022-11-08 21:43:44.352342+00","This field serves both purposes. If they have a config it's enabled."
"2022-11-10 14:46:53.076355+00","same here"
"2022-11-11 14:11:49.512481+00","Done."
"2022-11-02 13:26:46.583406+00","this function doesn't seem to return a bool. should the doc be fixed"
"2022-11-02 13:38:36.580777+00","Should have an await"
"2022-11-02 13:38:36.574053+00","Organize your imports in the format we shared earlier, relative imports should come last Format to be https://gitstart.slack.com/archives/C02QH7ZUQBT/p1667213225110949 "
"2022-11-02 14:13:45.597654+00","note here, we are changing the format of the job names. the new job will simply be called `excavator-pre-release` for instance. "
"2022-11-02 14:18:06.230797+00","```suggestion > NOTE: Repository access over SSH is not yet supported on [Sourcegraph Cloud](../../cloud/index.md). ``` not sure if without the ""space"" would work or not"
"2022-11-02 15:38:44.261286+00","Organize imports"
"2022-11-02 15:38:45.359749+00","Space between import categories"
"2022-11-03 16:48:00.492485+00","did you create the relevant two slack channels?"
"2022-11-03 17:53:51.372374+00","Can we use the page as a prefix here, i.e. `this.deps.opsDashboardSearch`?"
"2022-11-03 17:53:51.645476+00","Nitpick: 'cause this method returns a `JSXString` I believe you can just type this as a self-closing tag, i.e. ```ts <div id=""search"" /> ```"
"2022-11-03 22:27:42.802502+00","True... `publicEventTypes` Makes sense. "
"2022-11-03 22:56:15.836935+00","I am bad at typing yikes "
"2022-11-03 16:48:20.222489+00","yes :)"
"2022-11-04 06:25:36.057939+00","After looking into https://docs.sourcegraph.com/dev/background-information/workers, I think it is too heavy-lifting (requires a dedicated database table) for a simple clean-up job."
"2022-11-04 08:47:20.524303+00","Let's limit the possible atom that can be passed here ` @possible_statuses [:draft, :open, :paid, :void, :uncollectible, :deleted]` Refer to my comment here for guidelines https://github.com/GitStartHQ/client-gitstart-backend/pull/34#discussion_r1012583800"
"2022-11-04 14:58:46.116357+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , prospects AS ( SELECT * FROM {{ ref('stg_prospect') }} ``` "
"2022-11-04 14:58:46.38839+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion WHERE row_num = 1 ``` "
"2022-11-02 17:24:29.990774+00","@trevorImmunefi this part of the code is because we only want to run this on the client side, correct?"
"2022-11-02 17:25:49.771617+00","This was a poc test. @trevorImmunefi should we delete this one?"
"2022-11-04 14:44:40.509892+00","I think you're right about that. I'll modify this to ensure a 404 is returned."
"2022-11-04 04:39:20.809179+00","Removed this as I think we should not come up with our own kickoff projects through refactor comments/ and instead through conversations. Besides, reimplementing syncers in equanimity is already a project and this will be handled then."
"2022-11-01 17:09:31.911206+00","The problem is you are using un-typed prop, IMO it's pretty the same as the old one `isSelected` un-typed un-documented."
"2022-11-01 12:41:40.672464+00","is there a reason to avoid fetch/axios here?"
"2022-11-01 12:43:23.977988+00","this is a pure function from the perspective of this component and it can be declared outside of the component to avoid unneccesary rerenders/memory usage"
"2022-11-01 12:43:44.412468+00","Yeah, I'd do that. In theory, we should always have the actor ID available, but if there was some kind of background job pruning stale tokens using internal actor the call would crash."
"2022-11-01 13:00:15.141155+00","my bad. switched in back 3f506caeef3b2cd48e1d9d16c9c091dd10fa5856"
"2022-11-01 12:45:26.822471+00","Yep, looking good!"
"2022-11-01 12:51:53.701539+00","Do you think we can take the > 0?"
"2022-11-01 12:53:34.790473+00","I think would be clean, WDYT? ```suggestion const controlsCount = Object.values(rows).filter( (argType) => !argType.table?.disable ).length; ```"
"2022-11-01 12:56:39.762473+00","@JoeWrenn fetch is not supported by IE 11. Sending request via axios throws react-saga related errors. I'll see what can be done for axios."
"2022-11-01 13:04:58.653552+00","@matheusmuniz03 changed it"
"2022-11-01 13:08:31.539028+00","yes. and its tripping up because in AuthenticatedRoute, component is defined as: `component: PropTypes.elementType,` whereas in TeacherAuthRoute: `component: PropTypes.object,` Should I just updated the propType?"
"2022-11-01 13:13:38.767673+00","> and should review approval be considered here since it's considered for the ""final design"" flag above? I've raised this concern with Sana and Ana. They've said they're ok considering some units as multiple times because they still wanted units that weren't sent to a lab/delivered but had a QC approved design to be paid out on. QC also happens much faster than lab acceptance or delivery, and they want to payout sooner / know sooner for capacity model. Since you're out and we want to get this merged for today, I'm merging, however I'm happy to further discuss if you have more concerns"
"2022-11-01 13:31:52.519462+00","You're right about that. I should change the docstring to reflect that. It's the list of authz providers that will be used in any query coming from the frontend to determine if the user has access or not. "
"2022-11-01 13:37:04.139287+00","For the purposes of this test, we only care about the list of authz providers used in the frontend. The flakiness was happening when the list wasn't yet updated there, and we were bypassing any authz checking entirely in that case (which happened about 1 in 10 times)"
"2022-11-01 13:39:07.819184+00","This new gql api is basically the equivalent of the repo-updater debug endpoint that you posted, just for the frontend. The state of the authz providers list could potentially differ between the two for a few seconds, causing test flakiness if we try to use the endpoint from repo-updater."
"2022-11-01 13:42:23.16665+00","this is what is set on dotcom, so wanted to be more explicit about it "
"2022-11-01 13:43:00.978381+00","If our test cases are targeting the read path (checking perms), totally on board with the approach in the PR. I couldn't really in detail anymore though, if this set of test setup expects the background perms syncing to do anything (if not, then good!)."
"2022-11-01 13:44:21.23225+00","Note: no intention to block the PR, purely jumping on for discussions 😛 "
"2022-11-01 14:16:27.80043+00","oops - this shouldn't be here"
"2022-11-01 14:30:09.642474+00","I appreciate your comments! 🙏 "
"2022-11-01 14:54:29.416256+00","not concurrently? "
"2022-11-01 14:54:42.610526+00","It's smol, already created it on cloud no issue."
"2022-11-01 14:56:51.592491+00","@karimsa @A1Liu please give the change here a look when you have a chance"
"2022-11-01 14:57:48.259323+00","Updated to avoid this in https://github.com/ChalkTalk/chalktalk-react-40/pull/3477/commits/b74a9fc4c2a26fe91b74df25970ced57b2cbd583"
"2022-11-01 14:57:59.88982+00","Added the proptype here: https://github.com/ChalkTalk/chalktalk-react-40/pull/3477/commits/b74a9fc4c2a26fe91b74df25970ced57b2cbd583"
"2022-11-01 15:02:55.818415+00","I suppose this is here because we're still in draft, just a friendly reminder that if we were to make this PR ready for review, we should explain why we're commenting those. "
"2022-11-01 15:02:55.987149+00","WIP ? "
"2022-11-01 15:02:56.130486+00","TIL this works. Totally makes sense when you think about it. "
"2022-11-01 15:02:56.77269+00","`TrimLeft` and `TrimPrefix` have different semantics, is that what we want there? What prompted to fix this? For example, if the input string is `""""foo` the old code would return `foo` whereas the new code returs `""foo`. https://go.dev/play/p/Dkntpfg7qQ3"
"2022-11-01 15:02:56.83932+00","Oh, that sounds like a bug. How did you catch this? "
"2022-11-01 15:02:56.913677+00","Why do we need this?"
"2022-11-01 15:02:59.172509+00","The previous code was effectively duplicating the client, the new code is modifying a global, which may have unintended consequences. Was this brought by a linter? "
"2022-11-01 15:02:59.244493+00","If we're returning a slice, why don't we return nil?"
"2022-11-01 15:02:59.972493+00","Why is the new code working? Does create and attach does this on its own?"
"2022-11-01 15:04:38.183995+00","Yeah it was, and that is a good point! I was wondering why it did that. GREAT CATCH! "
"2022-11-01 15:05:25.637963+00","yip ... already fixed. Will fix in next push!"
"2022-11-01 15:07:20.242469+00",":( how about the case we use model without `id` prop? Where did you get this `id` prop?"
"2022-11-01 15:07:16.980593+00","I was also puzzled but the explanatio made sense to me: https://staticcheck.io/docs/checks/#SA1024"
"2022-11-01 15:16:49.672474+00","<img width=""437"" alt=""Screenshot 2022-10-31 at 18 42 12"" src=""https://user-images.githubusercontent.com/1001709/199268441-e4557772-8cb3-4bc7-b1d1-6268b1400f71.png""> "
"2022-11-01 17:23:09.542329+00","```suggestion * Lists all auto measure subscriptions in the user's project. * * @returns A Promise that resolves with a list of all auto measure subscriptions. ```"
"2022-11-01 15:08:22.83434+00","I couldn't figure out how to do this for a single client so I just [beat all clients into submission](https://github.com/sourcegraph/sourcegraph/pull/43649/files#diff-f5bd0ec043180a518c5e040c8d8c4f83331edea600ed6c8bf98a7ba91f07de7fR67) lol I will reuse this 🎉 "
"2022-11-01 15:14:37.132481+00","Hahahahah! You know. I went through that EXACT same thought process"
"2022-11-01 15:17:22.052485+00"," "
"2022-11-01 15:19:46.898247+00","Just to check my understanding here, this change means generated queries can return duplicate results now?"
"2022-11-01 15:32:13.467474+00","This was the lint error for this line https://staticcheck.io/docs/checks/#SA4001"
"2022-11-01 15:25:12.269732+00","in the WalkDirFunc, an `error` is being passed in and the function overrides that error"
"2022-11-01 15:41:44.369165+00"," So I asked in the code-insights team about it, because the linter complained initially about a array that was being appened to but not used. When I removed the array, all what was left was the `c` var and it was also unused. Long story short, the code-insights team says it is ok to ignore."
"2022-11-01 15:14:05.907443+00","https://go.dev/play/p/oIJugDQH99g"
"2022-11-01 15:56:35.889529+00"," it follows what the method does earlier see https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/enterprise/internal/insights/store/store.go?L187"
"2022-11-01 17:46:39.102491+00","😡 "
"2022-11-01 16:00:18.154042+00","This check is correct, a user with Manage permission can also read and envelope"
"2022-11-01 15:44:27.534214+00","For the `ExternalEditor`, we are getting id from `gql query` <img width=""485"" alt=""Screen Shot 2022-11-01 at 21 22 33"" src=""https://user-images.githubusercontent.com/51731962/199274539-83a1c8aa-edaf-4766-b1ff-9ac9d22fdd74.png""> For the ConnectingOrganization we are getting id from query <img width=""583"" alt=""Screen Shot 2022-11-01 at 21 23 47"" src=""https://user-images.githubusercontent.com/51731962/199275031-f95613f1-6cc8-4ff0-9d43-447d41eaa310.png""> And for the `Selecting Framework` <img width=""415"" alt=""Screen Shot 2022-11-01 at 21 28 06"" src=""https://user-images.githubusercontent.com/51731962/199275540-cd80e5c7-fe79-4bc0-a84a-fa742eaff482.png""> Please let me know if I am missing something @phunguyenmurcul "
"2022-11-01 16:11:27.1316+00","Oh shit, it actually does not copy in the previous code as per the linting explanation. TIL. I guess the copy must be made explicit. ``` c := *client use(&c) ```"
"2022-11-01 16:12:31.000418+00","What about renaming the err to `innerErr` then?"
"2022-11-01 16:15:02.998051+00","I think we'd better with `nil` in both cases no? Why create an empty slice struct to hold nothing? "
"2022-11-01 16:15:18.054813+00","I ... am ashamed I didn't think of that 😅 "
"2022-11-01 16:24:03.284816+00","```suggestion // Find if there are crowns or abutments in the new state that aren't in the old. ```"
"2022-11-01 17:23:12.834595+00","Understandability nitpick: ```suggestion * Returns an Elasticsearch query to retrieve a list of manual measurements given the metric page's filters. ```"
"2022-11-01 16:24:03.561909+00","would recommend comparing against the `FluorideScreen` enum value"
"2022-11-01 16:33:34.206199+00","is this a left join?"
"2022-11-01 16:35:59.866803+00","OK let's go with this!"
"2022-11-01 16:37:14.365385+00","In an old thread, John had mentioned to me that for identifying ACH, `payment_source_id`: 1. if payment_source_id starts with ba_ then it's definitely an ACH payment 2. if it starts with src_, pm_, or pi_ then we can't tell whether it's a card or ACH (though those are rare) 3. anything else and it's definitely not an ACH is this consistent with filtering for 'ch_ACH'?"
"2022-11-01 16:54:31.883945+00","This is inconsistent with the tests above, and describes more technical details than user scenario: ```suggestion it('should fail to mark in fabrication as ops', () => { ```"
"2022-11-01 16:39:36.673006+00","looks like this stg table doesn't apply any filters or anything, but do want to be conscious for future changes that mix base data with dbt tables, because we may be applying filters in dbt (test orders is a good example of this. dbt filters out all test orders, but currently Acctg is interested in them as part of reconciliation)"
"2022-11-01 17:23:08.954573+00","Codebase styling nitpick: ```suggestion * Loads physical measurements data. */ private async loadPhysicalMeasurements(): Promise<Array<{ ```"
"2022-11-01 16:42:26.507016+00","do we need `treasure.` prefix here? and line below"
"2022-11-01 16:43:34.524349+00","should this be treasure.fact_invoice?"
"2022-11-01 16:47:24.282479+00","Since fields get rendered as well even if you can't parse the logs as JSON, isn't filtering for `auditId` a more relevant and specific thing to look for?"
"2022-11-01 16:48:31.798337+00","Minor, but I believe its more correct to say ""Thanks, {firstName}"" (note the comma after thanks)! "
"2022-11-01 16:54:29.005739+00","ditto ```suggestion it('should mark an order an ""In Fabrication"" as the lab', () => { ```"
"2022-11-01 16:54:30.961015+00","This describe is missing a test for a non-integrated lab being able to mark an order in fab, which was the scenario that caused the incident"
"2022-11-01 17:04:35.615905+00","Done!"
"2022-11-01 17:27:57.571651+00","I tested on main, commented vs uncommented, tests pass either way"
"2022-11-01 16:54:34.906939+00","This assumes that every manufacturer has a `ManufacturerIntegrationDTO` entry, which is not true - most manufacturers actually don't have an entry in this table, since we have zero integration with their systems"
"2022-11-01 16:58:43.415512+00","Can we clean this up pre-merge?"
"2022-11-01 16:58:43.610367+00","Do these still pass?"
"2022-11-01 16:59:08.994002+00","i swear i un-commented these before pushing, but yes they do"
"2022-11-01 16:59:18.750443+00","real brainfart moment today"
"2022-11-01 17:00:32.461667+00","Do we no longer need this record to be deleted?"
"2022-11-01 17:09:14.152491+00","The cast is just trying to convince TS that these fields are not null, right? Can't we just `updatedField!`?"
"2022-11-01 17:09:25.45249+00"," I think there is a current guarantee by the api to return a valid slice. Clicking through the call graph I see no checks for nil, so it would make sense in that regard to return an empty slice?"
"2022-11-01 17:12:26.528944+00","That's pretty interesting. Do we expect our data to hit this edge case though? My worry is that more complex code is harder to CR or verify, and since we're not storing raw data in the data model, we have a limited number of tries on this."
"2022-11-01 17:14:45.134209+00","```suggestion - **Project Manager:** a client-facing role that tracks internal progress, addresses client issues and manages client expectations on pull request delivery dates and credit costs ```"
"2022-11-01 17:14:45.218124+00","```suggestion 2. **An experienced developer:** **Find tickets that don’t have PRs or Tasks yet**. As you grow in skill and experience, try to scope out work for yourself and others such as reviewing pull requests (remember, teamwork makes the dream work 😁). ```"
"2022-11-01 17:14:46.325826+00","```suggestion - **Repo Owner:** typically an experienced developer who has deep knowledge about the client repository and ensures high code quality of each pull request ```"
"2022-11-01 17:16:50.255291+00","Minor nit: the tentative log message convention is lowercase and generally no punctuation: https://docs.sourcegraph.com/dev/how-to/add_logging#writing-log-messages"
"2022-11-01 17:22:16.968063+00","Do the '-''s belong here? it seems like it should just be: ""live and persistent documentation"""
"2022-11-01 17:22:17.005884+00","I realize you moved this and didn't write this on your own, but this sentence and paragraph are confusing to me. we say ""All developers, except:"" and then we have one bullet that *sort of* matches the ""except"" clause (the second one) and one that is just a definition of who uses sourcegraph. Maybe we should drop the ""All developers, except:"" part and just describe it in a paragraph? Or, alternatively, change the 2 sentences so they align with the ""except"" like: - Developers at organizations with a small amount of code - Developers that rarely search, read, or review code "
"2022-11-01 17:22:17.140645+00","This paragraph seems out of place. I like it but it doesn't seem to go with ""Who else uses Sourcegraph?"". It seems like it belongs at the top as a ""Why do I need code search?"" heading or something like that maybe?"
"2022-11-01 17:22:17.262488+00","it's => its"
"2022-11-01 17:22:17.59783+00","this might be a pet peeve of mine, but I prefer ""developers"" to ""devs"". Not a big deal either way - just my own preference :) Also - ""code base"" can be either but it _looks_ like we usually use ""codebase"". Again here I have no preference, just a preference towards consistency. "
"2022-11-01 17:22:17.730812+00","same thing here - could we link to the doc describing code monitoring?"
"2022-11-01 17:23:07.96265+00","Nitpick: It appears to be the case that only two lines are in need of this lint rule being disabled. We should disable those lines (i.e. `eslint-disable-next-line max-len`) specifically instead of the entire document. Alternatively, it feels we could make the params on the extra long lines into individual params. For example, ```ts const metricNameFilter = metricName ? [{ wildcard: { 'inspections.measurements.intent.name.raw': `*${metricName}*` } }] : []; ... // And then in the query bool: { filter: [ ...metricNameFilter ], } ```"
"2022-11-01 17:28:31.515402+00","When the user is parent navigate to Bookings screen"
"2022-11-01 17:22:17.789994+00","""large technology companies"" feels kind of limiting what about re-wording this to: ""In addition to the [companies listed on about.sourcegraph.com](https://about.sourcegraph.com), companies with a few hundred developers all the way up to those with more than 40,000 use Sourcegraph daily."" "
"2022-11-01 17:22:17.828998+00","is this supposed to be search contexts? could we link to the docs on it?"
"2022-11-01 17:22:18.199697+00","can we link to the query syntax page (/code_search/reference/queries) here?"
"2022-11-01 17:22:18.602484+00","I would drop the "", and has no indexing delay"" entirely. Or, if you prefer, change it to ""with minimal delay"" or similar wording. "
"2022-11-01 17:23:07.966938+00","This line should not be broken up like this for understandability purposes. We should apply the disable lint rule right above this line so it can be directly to this line. Alternatively, we can do something like this (untested): ```ts const statsAggregation = { stats: { field: 'inspections.measurements.bodyAsImageFeature.realValue' } }; ... meas_stats: statsAggregation, ```"
"2022-11-01 17:23:08.000091+00","You can save a level of indentation for the block below by just returning here. Also note that the closing parenthesis needs to be on the next line. ```suggestion if (!deps.flags.accessStatus('measurement-r-1', true) || !deps.flags.accessStatus('measurement-sandbox-persistence', true) ) return []; ```"
"2022-11-01 17:23:08.360671+00","Is there a reason for not combining these two requests in a `Promise.all`? Same questions for below on line 556?"
"2022-11-01 17:23:08.857095+00","Several items here: 1. We should use the edi-limits-helpers to do this check instead of doing it ourselves. I.e. `hasSavedLimits(limits, APIListMetricsDataType.NUMBER)` 2. The indentation is off for this line."
"2022-11-01 17:23:08.298494+00","Nitpick: We can probably just drop this for now as we are not using it nor verifying this is correct yet. FYI @jonboiser, this will probably be close to what we need for the Distribution chart."
"2022-11-01 17:23:08.582817+00","Codebase readability nitpick: ```suggestion must: [{ exists: { field: 'inspections.measurements.bodyAsImageFeature', }, }], ```"
"2022-11-01 17:23:09.960485+00","Codebase styling: ```suggestion return stationInfo.doc_count > mostMeasurementStation.doc_count ? stationInfo : mostMeasurementStation; ```"
"2022-11-01 17:23:10.091085+00","Codebase styling: ```suggestion retest ); ```"
"2022-11-01 17:23:10.250174+00","```suggestion dataType: APIListMetricsDataType.NUMBER, ```"
"2022-11-01 17:23:10.812426+00","Might be nice to organize this as `monitor: { id: DFXID, name: string }`. Also would be nice if these were alphabetical so it's easier to skim through."
"2022-11-01 17:23:11.082004+00","Nitpick: Swap the order here to match the order of inputs in the method. Also, it does not appear that the query param is ""Optional"" anymore so we should probably drop that from the description. "
"2022-11-01 17:23:11.197525+00","Codebase styling: ```suggestion const station = station_names.by_station_name.buckets.reduce(( mostMeasurementStation: any, stationInfo: any ) => { ```"
"2022-11-01 17:23:12.840331+00","I think this is possible if we set `EmptyFilter = {""match_all"": {}}`, or at least it didn't break when I ran the query in my console. The only item I would be wary of is the `match_all` sets all document scores to `1` ([documentation](https://www.elastic.co/guide/en/elasticsearch/reference/master/query-dsl-match-all-query.html)). For this use case probably doesn't make a difference, but I would be hesitant to make this our standard. That being said, we do use `match_all: {}` in the filter clause in some of the older control-panel/subscriptions queries."
"2022-11-01 17:23:12.886232+00","I also wonder if `metricName` needs to be separate considering it is a part of `physicalMeasurementData`?"
"2022-11-01 17:24:23.996864+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , ARRAY_AGG( message_details__dialpad_time_to_connect_in_seconds ) WITHIN GROUP (ORDER BY message_created_at ASC, message_details__direction = 'in' DESC)[0]::varchar AS dialpad_time_to_connect_in_seconds , ARRAY_AGG( message_details__call_duration_minutes ) WITHIN GROUP (ORDER BY message_created_at ASC, message_details__direction = 'out' DESC)[0]::varchar AS call_duration_minutes ``` "
"2022-11-01 17:24:24.281877+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-01 17:25:39.800662+00","It didnt appear to be needed beforehand either, and Im not able to figure out a reason why I had this in the first place :thinking: "
"2022-11-01 17:26:56.439156+00","Well, you took 16 and 17 out of an existing test case. Is this why?"
"2022-11-01 17:28:31.718706+00","if this hook is only for parents, every useEffect should check for `if (!isParent) return` You should not make any queries here is the user is not parent"
"2022-11-01 17:44:03.031474+00","This is just a POC to test the package is working for excavator too - I am planning on writing extensive tests for this feature in another PR"
"2022-11-01 17:44:41.931533+00","Turns out excavator uses `sdk.ts` directly, and does not have its own RDS, which is required for the test helpers. So I put this in as a copy of the zipstream one."
"2022-11-01 17:45:21.440909+00","I think the style conventions are to use lower case on all field and explore names ```suggestion explore: am_outreach_datespine { ```"
"2022-11-01 17:45:21.529189+00","i think one way to make this not a `many_to_many` join and instead a `many_to_one` join (if that's what we want) is if we join tasks directly to this table using the sf account id AND the month of the task = the month of the status?"
"2022-11-01 17:46:00.470601+00","I'd be curious to understand why you'd need such a guarantee on a normal slice, I mean if you need to append, it works with nil perfectly, so where else would we need this if we don't have methods on that type ? "
"2022-11-01 17:46:25.570754+00","You killed me with that meme btw 🤣 "
"2022-11-01 17:54:16.194337+00","Should these be cast a INT or NUMERIC type instead?"
"2022-11-01 17:56:20.693379+00","Definitely yes"
"2022-11-01 17:58:10.066439+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , ARRAY_AGG( message_details__dialpad_time_to_connect_in_seconds ) WITHIN GROUP (ORDER BY message_created_at ASC, message_details__direction = 'in' DESC)[0]::numeric AS dialpad_time_to_connect_in_seconds , ARRAY_AGG( message_details__call_duration_minutes ) WITHIN GROUP (ORDER BY message_created_at ASC, message_details__direction = 'out' DESC)[0]::numeric AS call_duration_minutes ``` "
"2022-11-01 17:50:43.76228+00","My prettier settings fucked this file, but the only real change in this to `testMatch` - integration tests are able to run alongside unit tests, we don't need them to be separate anymore"
"2022-11-01 18:19:23.710362+00","my brain was not working yesterday -- the invocation of `cmd.handle` is indeed within the context of the trace callback and captures the parent context. I think the code is a bit hard to reason about with the promise being passed out and awaited externally, so I'd still recommend going the route of my code suggestion, as it's a lot simpler to understand for most developers, IMO."
"2022-11-01 18:34:38.329601+00","To add to Jonathan's note, I pasted the training material that Vivek shared which also suggested that we use a 'bool' clause as it allows taking an array of filters or a single filter object. [Training slide](https://docs.google.com/presentation/d/1b9zD6eS50IIwSek-vtYhwZ1wOZNP4tU2yRpVSoWL0Ao/edit#slide=id.g4529e599f5_0_131) "
"2022-11-01 18:46:59.621056+00","I lost this change while rebasing this PR, so opened a new PR for it: https://github.com/sourcegraph/sourcegraph/pull/43764"
"2022-11-01 18:47:51.239964+00","👑 "
"2022-11-01 18:47:51.401295+00","Can add this once my PR is mergiddy merged"
"2022-11-01 18:51:09.956227+00","In theory yes. But in practice there isn't much overlap in the rules that should result in duplicate results. The main cause of duplicate results is running both of, say, `func parse` and `func AND parse`. Plan is to reintroduce the deduping (only for the odd ~13% of affected searches) or find a way to do this with the term negation. Depends a little how difficult it is to restructure the code for either of those cases."
"2022-11-04 18:41:25.652542+00","```suggestion if !opt.IncludeNeverActive { conds = append(conds, sqlf.Sprintf(listUsersWithEventsCond)) } ```"
"2022-11-01 19:02:56.250718+00","Isn't the `lastSeen` used here in UTC? Does it make a difference?"
"2022-11-01 19:09:30.786795+00","Just curious, how is this different from onClick? Would this cause the handler to be invoked twice?"
"2022-11-01 19:15:27.367392+00","This is a good way to reuse the old markup, but maybe it would be simpler to implement this as an actual table element? It would probably require less CSS, I imagine."
"2022-11-01 19:21:15.422476+00","@jonboiser that is a good point. @jonathan-yee Sometimes there are cases where measurement name is an empty string and I also suspect there could be a similar case as well in the autoMeasure data. With that being said, shall we still use the measurement Name against monitor Name to pull in the monitor name for the manual measurements data?"
"2022-11-01 19:24:05.151901+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion FROM account_plans ``` "
"2022-11-01 19:24:05.277595+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-01 19:24:05.274393+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-04 18:41:25.709912+00","- [x] Nest this in the if statement above so that it only applies when both `InactiveSince` and `NeverActive` are set."
"2022-11-01 19:24:05.692545+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-01 19:24:06.196508+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-01 19:24:06.286011+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-01 19:24:06.591022+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion /* ``` "
"2022-11-01 19:24:08.637249+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion /* description plan_status_changed_to_complete_at = date the status of the plan was moved to Complete */ ``` "
"2022-11-01 20:24:56.195715+00","@hashimaziz46 let's change this approach ```suggestion check('withLatestVersion').isBoolean().optional().default(true), ```"
"2022-11-01 19:31:01.192472+00","Hi @jonboiser , I tried to use an actual table element but lost the list interaction. This was the easiest route with out updating the function and still maintain the interaction."
"2022-11-01 20:03:40.538996+00","That is a good point. However, based on previous experiences, this could cause a lot of problems if we allow users to create monitors without saving a name. In fact, currently, we cannot open the bulk measure modal without saving a name for the measurement so it should never be the case that we would be able to create a monitor without a name. Update: Yes we need to match names. Otherwise, there is no way to distinctively match the measurements to the monitors?"
"2022-11-01 20:24:56.089+00","this EXCEPT enum hasn't been provided so we can remove it ```suggestion ```"
"2022-11-01 20:25:34.010275+00","Using `colors` is causing the JS bundle to compile to something that is not valid JS. Replace this line for now with this, but I think we should find a different solution for overriding the SVG attributes ```suggestion .replaceAll('#03BBD2', '#777777') ```"
"2022-11-01 20:47:55.397026+00","@hashimaziz46 since we've added `default()` in router we'll remove this line ```suggestion const { statuses, withLatestVersion } = req.query; ```"
"2022-11-01 20:48:17.993275+00","ordering a single aggregate's events in memory shouldn't be too expensive (and in any case we currently do this in node, so the index doesn't help at all - though we'll likely change that in the near-medium future)"
"2022-11-01 20:48:26.156163+00","ordering by `id` works just as well as `created_at` for this index's purpose (partitioning aggregates for rebuilds) and removing `created_at` makes this index much less expensive to build"
"2022-11-01 20:50:06.141376+00","just giving this an explicit name to make it easier/clearer to refer to in future migrations"
"2022-11-01 21:10:41.102489+00","All I did was add curly braces and a `return` statement. I can revert this file back for a cleaner diff, but I think leaving it this way will make it easier for future developers to throw in a `console.log(update)`, for example."
"2022-11-02 01:38:46.762604+00","minor nit: this component only ever calls with true, so why not make it just `() => void` and set the true part higher in the component tree closer to where the state variable is defined?"
"2022-11-01 21:11:10.05248+00","@Mjanuary I think this a tautology when do we need to countDocuments?since we pass same conditions pipeline I think we should have used one `EnvelopeService.getEnvelopeActivities({});` can you take a look in your codes?"
"2022-11-01 22:12:36.322492+00","Let's keep the name of this property consistent throughout the code. ```suggestion isSourcegraphDotCom?: boolean ```"
"2022-11-01 22:12:36.411063+00","Do we not want to show these interactive tips on dotcom? Or do they not work?"
"2022-11-01 22:12:37.252474+00","I think this footer doesn't work in its current location because [in the tablet/phone view, it's in the middle of the suggestions](https://www.chromatic.com/pullrequest?activeElementId=comparison-test-key-630e3ef135d96f02a5757bdc-544&appId=5f0f381c0e50750022dc6bf7&number=43766&view=changes). It should probably be outside of the columns altogether so it appears after all the suggestions regardless of layout."
"2022-11-01 22:12:38.232481+00","`/help` should work everywhere, even on dotcom."
"2022-11-01 23:18:09.42002+00","@dandysean this now reads imperatively ""start span, do stuff and return, end span"" vs. triple-nested async; thoughts?"
"2022-11-01 22:12:39.374967+00","I think we can simplify this? Not identical but I don't think we have (many?) customers allowing unauthenticated use. ```suggestion {(!showEnterpriseHomePanels && props.authenticatedUser) && ( ```"
"2022-11-01 22:14:34.44284+00","The logged out homepage looks almost the same as the logged in homepage, do we want to get rid of this file? The only difference left seems to be the ""pro tip"" part which I think would be OK to show to all users (authenticated or not) on dotcom."
"2022-11-01 22:15:24.637102+00","There is a lot of code duplication happening just to make these 3 lines different. Instead of creating a separate point object it would be better to just modify `point`. This could be done in two ways. Option 1: modify the definition of `points` so these properties are conditionally set: ```ts xPx: this.zoomState === 'in' ? parseFloat(eventTarget.parentElement.dataset.thumbX) + (mouseX * thumbExtract / thumbDisplay) : zoomedOutPointRegions[pointIndex].x + (mouseX * thumbExtractZoomedOut / thumbDisplay), yPx: this.zoomState === 'in' ? parseFloat(eventTarget.parentElement.dataset.thumbY) + (mouseY * thumbExtract / thumbDisplay) : zoomedOutPointRegions[pointIndex].y + (mouseY * thumbExtractZoomedOut / thumbDisplay), magnification: thumbDisplay / (this.zoomState === 'in' ? thumbExtract : thumbExtractZoomedOut), ``` Option 2: just modify the point in the `else` clause: ```ts point.xPx = zoomedOutPointRegions[pointIndex].x + (mouseX * thumbExtractZoomedOut / thumbDisplay); point.yPx = zoomedOutPointRegions[pointIndex].y + (mouseY * thumbExtractZoomedOut / thumbDisplay); point.magnification = thumbDisplay / thumbExtractZoomedOut; ``` In either case you can keep `this.points.push` where it was before, outside of the `if`/`else`."
"2022-11-01 22:23:09.038794+00","`dashboard` (lowercase `d`) to match what we have in other menu items?"
"2022-11-01 22:58:20.282811+00","I don't understand the objection to spreading an empty array? We use that pattern all over the place: ```bash frontend$ git grep -E '\.\.\.\(.*\?' | wc -l 69 ``` Personally I think it's great because it prevents unnecessary clauses from showing up in the resulting array and potentially slowing things down."
"2022-11-01 23:02:22.25015+00","It is in UTC, that's why we reformat it into user-local time."
"2022-11-01 23:07:14.041741+00","added in else below"
"2022-11-01 23:11:37.702483+00","As is, I believe that if an error is thrown inside this method our `errorHandler` will emit an alert independently of whether user's context changed (i.e. by navigating away from the page, selecting a different unit/sidebar filter) between the request trigger and the response which seems unfortunate. Have you put any thought into this?"
"2022-11-01 23:13:51.311046+00","Yeah, pulled all of that for this MVP. When using webpack to pull in this file, it would have been easy to just *not include* anything by dropping it from webpack. I'm not too sad about dns/tcp being included. GRPC was a pain to get the autoinstrumentation working, but we want that. Haven't yet figured out why we're seeing HTTP but not GraphQL. I intend to add only the ones we want once we figure out what's useful; was trying to get this in others' hands before going nuts on the configuration: still not sure how to gate that on LaunchDarkly since this is the *first thing* that loads and gets enabled."
"2022-11-02 01:38:54.080602+00","```suggestion }, [patient, setEditedPatient]); ```"
"2022-11-01 23:22:57.202493+00","I confirmed it worked correctly before I put it up."
"2022-11-01 23:24:12.644894+00","added, @Joeb3219 does that work?"
"2022-11-01 23:24:52.198553+00","I'm not familiar with how to call `errorHandler` so that it does not bring up the modal. Is it just a matter of adding an option here? https://github.com/dfxmachina/frontend/blob/49daa9ce9ab183eae212e755b5e5fb613388beb6/app/modules/metrics/metrics-controller.tsx#L1367-L1378"
"2022-11-01 23:27:59.806118+00","These tests are posting to a live click up endpoint?"
"2022-11-01 23:36:16.262453+00","Yes, you can use: [renderTarget](https://github.com/dfxmachina/frontend/blob/master/app/modules/utils/error-handler.ts#L56-L58) But that by itself won't fix the behavior I'm describing here, it'd only render the error message onto the given target and stop emitting the alert."
"2022-11-01 23:59:07.678818+00","I would need to create a closure that saves the current context at the request trigger (would the URL alone be enough to capture the context?) and cancels the callback if the context has changed by the time the response comes back. I could add here if simply checking URL is enough, or if there is another solution"
"2022-11-04 18:41:26.462619+00","- [x] Rename - [ ] Redocument to match graphql layer semantics"
"2022-11-02 00:43:18.967125+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , SUM(additions) AS sum_commit_additions , SUM(deletions) AS sum_commit_deletions , SUM(changes) AS sum_commit_changes , COUNT(DISTINCT filename) AS count_distinct_files_in_commit_changed ``` "
"2022-11-02 00:43:19.048136+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , COUNT( DISTINCT IFF(status = 'added', filename, NULL) ) AS count_distinct_files_added ``` "
"2022-11-02 00:43:19.558633+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion WITH source AS ( SELECT * FROM {{ ref ('github__pull_requests') }} ``` "
"2022-11-02 00:43:19.978937+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion SELECT ``` "
"2022-11-02 00:11:31.68756+00","I'm actually wrong, sorry about that 🤦 Looking closely it seems like we're feeding `loadControlChartTimeSeriesData` a `CancelableAPI` which means that if an error is thrown or if the context changes (which cancels any in-progress requests made with this API) the `errorHandler` will simply ignore it. Edit: fwiw and for my own sanity check, it looks like we were only using a `CancelableAPI` after rebasing from latest master 🤷 "
"2022-11-04 18:41:26.582478+00","```suggestion const listUsersWithEventsCond = ` (EXISTS ( SELECT 1 FROM event_logs WHERE event_logs.user_id = u.id )) ` ```"
"2022-11-02 00:43:20.137367+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion LEFT OUTER JOIN commit_summary ``` "
"2022-11-02 00:43:20.919387+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion FROM pull_request ``` "
"2022-11-02 00:57:17.502478+00","Okay, I went ahead and added a closure to check whether the context (based on the load ID, URL, and active chart tab) has changed. This handles the examples you gave (going to a new page, changing the filters, etc.), but still has the shortcoming (?) that we are flatten the error message by not using the error handler. Also, I'm not sure if the CancelableAPI is cancelling the request, since George and I have been able to get the error modal to appear by navigating away from the metrics page."
"2022-11-02 01:13:52.977107+00","We want to avoid functions like this as much as possible, especially when we're modifying things in state (which we are in this case). We should adopt a pure function that does not modify the input"
"2022-11-02 01:07:22.324676+00","instead of mutating the input we can return the input with the fields we do not want to keep `filter`ed out. The fields we would want to filter are those listed in `MATERIAL_TO_FIELD_ID` above"
"2022-11-02 01:07:22.467023+00","Instead of setting the fields to keep, we should set the fields that we want to remove as it will be far more flexible. If I want to add an additional field for night guards that shouldn't be cleared, I would not have any idea that I also have to update this function in order for that value to actually exist"
"2022-11-02 01:07:23.09259+00","what's the purpose of this change? It's not related to the work being done in this ticket and doesn't seem to change behavior so I'd suggest we revert"
"2022-11-02 01:07:23.284446+00","```suggestion return preference_fields.find(pref => fieldIdsForMaterialsWithThicknessSettings.includes(pref.field_id))?.value ``` this can be simplified down quite a bit"
"2022-11-02 01:07:23.491899+00","same thing with this change - is unrelated to PR w/ no effect so it doesn't make sense to include it"
"2022-11-02 04:35:10.518395+00","Let's not do this for now till we figure out better permissions rather than permissions on just the parent. I'd introduce a ticketCode field instead and just return the ticketCode only"
"2022-11-02 01:07:24.052493+00","We should derive this from the metafield itself rather than hardcoding anything. You can find an example of this in the quantity select"
"2022-11-02 01:07:24.328254+00","```suggestion const MATERIALS_WITH_THICKNESS_OPTIONS = [ 'Hard', 'Soft', 'Hard / Soft' ] as const; type MaterialsWithThicknessOptions = typeof MATERIALS_WITH_THICKNESS_OPTIONS[number]; const MATERIAL_TO_THICKNESS_FIELD_ID: { [T in MaterialsWithThicknessOptions]: string } = { Hard: 'night-guard-thickness-order-item-meta', Soft: 'soft-night-guard-thickness-order-item-meta', 'Hard / Soft': 'hard-soft-ng-thickness-order-item-meta' }; ``` just a suggestion as to how these types can be simplified"
"2022-11-02 01:07:25.032886+00","We've already declared these properties in one place, so we should aim to avoid re-declaring them so that we can maintain a single source of truth. You can just use `Object.values(MATERIAL_TO_FIELD_ID)` to get each of these properties in an array"
"2022-11-02 01:11:27.844811+00","this function is disgustingly bad already - can you move this into another component that abstracts away some of the state? Also, not sure why the state needs to be passed as props, you can just render the edit modal in the new component and manage the state locally there"
"2022-11-02 01:38:46.672529+00","why isn't `setPatientEditOpen` included in the memo props?"
"2022-11-02 06:22:20.232476+00","```suggestion - `STRIPE_WEBHOOK_SIGNING_SECRET` is the webhook secret key used to verify that the events received on our API were sent by Stripe, not by a third party mimicking to be Stripe. It's generated by Stripe and unique to an endpoint, see `endpoint.ex` for the list of all endpoints. ```"
"2022-11-02 01:40:27.500892+00","I would prefer that we use the Grid system to enforce the width rather than setting it on the options themselves - should be easier to update when it comes time to respect our layouts more accurately as part of the framework refactor"
"2022-11-02 02:10:17.757745+00","We need an additional check for the type of error being thrown otherwise when a cancelation error is thrown these new lines will cause new errors, see this: [screen capture](https://drive.google.com/file/d/1K5lxsKYhCWLemD7G2HtQqX9u0NNVx-t9/view?usp=sharing) Adding the following between lines 1371 and 1372 should suffice. ```ts if (isAbortError(error)) return undefined ```"
"2022-11-02 02:20:29.49247+00","I'm skeptical that we need the url check 🤨 Could it be that the branch version you were working from did not include the Correlations Control chart changes and as such [was not making use of a CancelableAPI](https://github.com/dfxmachina/frontend/pull/2551/files#diff-42d0d92ca14f57870f047e735b75392ecdac7f941b157bec8d05a46750446f4dL1396) for when fetching time series data for Control Charts? I believe something like following should suffice for the use cases we're trying to cover: ```ts const loadId = this.loadId; const response = await eventHandlers.activateControlChartTabHandler(metricName); if (typeof response === 'undefined') return; if (this.loadId !== loadId) return; if ((this.elem() as HTMLElement)?.dataset.chartContent !== 'control') return; ``` "
"2022-11-02 02:35:53.182485+00","From **_mattkrick_**: -1 we'll want to clean up the function on unmount. Consider using https://github.com/ParabolInc/parabol/blob/f3361ab138d76ecbd2fa233e518790226414709e/packages/client/hooks/useHotkey.ts#L7 "
"2022-11-02 03:06:58.807582+00","One last thing I noticed: I think we also want `package.json` => `""@google-cloud/opentelemetry-cloud-trace-propagator"": ""0.14.0"",` `const textMapPropagator = new CloudPropagator();` `new NodeSDK({ ..., textMapPropagator });` so that the traces will propagate with headers that are recognized by our GCP LoadBalancer, allowing e.g. *same trace* functionality in the associated GCP Logs."
"2022-11-02 03:54:29.534994+00","Just a nit: this comment is duplicating the code. I think ""Returns a query for Developer, joining with User"" should suffice."
"2022-11-02 03:56:09.939414+00","@iurimadeira @rlopzc I am not sure if this is ok, or if we should have separate environment variables for these two use cases?"
"2022-11-02 03:57:16.022487+00","because i am OFF MY GAME"
"2022-11-02 04:00:33.850114+00","Thanks for the comment, I was following how other join functions are documented. And in my opinion, specifying the named binding in the documentation is useful because we can see the named binding through the doc when piping these functions in context files, which is useful when we try to run operations like `select` and `where`. "
"2022-11-02 04:19:18.418172+00","3468ea4"
"2022-11-02 04:19:20.432495+00","3468ea4"
"2022-11-02 04:18:30.441608+00","Actually it may be nice to recommend adding more context in task titles like the PR number or the PR title so that when developers have their standups posted on Slack others also get that context. This could also be an improvement later on to add this context automatically as the default task title depending on the type of the task."
"2022-11-02 04:19:40.152615+00","."
"2022-11-02 04:42:10.702467+00","dd6e279"
"2022-11-02 04:42:24.587964+00","https://github.com/orthly/Scanner/commit/dd6e279d7198233374e20e7ed36968f8275a0049#diff-8afb574ab0744a80cd86f7db2865cce3fd29a32a6cef3309d9e798836d28e898R75"
"2022-11-02 04:48:36.664676+00","Fixed, thanks"
"2022-11-02 07:21:03.603561+00","Same as above"
"2022-11-02 07:09:55.183948+00","It's the condition that determines the presence of the SearchMenuItem field within the menu. The same applies to all the use cases below as well. I have also extracted them into variables https://github.com/GitStartHQ/client-parabolinc-parabol/blob/dc61249ebb85035bde1064f0202f82a6975c9fb4/packages/client/components/UserDashTeamMemberMenu.tsx#L76-L78"
"2022-11-02 09:21:47.202664+00","what is this?"
"2022-11-02 05:10:33.092465+00","I literally independently made this same exact change on the rebrand 🤯 I would suggest modifying the `Icon` prop to be similar to here since we actually don't need them to provide a component anymore - [`c1ab6f8` (#980)](https://github.com/orthly/Scanner/pull/980/commits/c1ab6f86bd7ec9758745996d3de800e2b9864237#diff-996a3eec4855d51afe0e3a4cbbefedfc95fd8b74ab4e655d1b86f594c4e796c1R73)"
"2022-11-02 05:10:37.962083+00","."
"2022-11-02 05:10:28.242473+00","."
"2022-11-02 04:46:35.034942+00","."
"2022-11-02 05:31:35.726801+00","0d73ed7"
"2022-11-02 05:58:41.513339+00","TIL about nil append"
"2022-11-02 06:17:03.632475+00","This is ok. Phoenix explicitly states: `a secret key used as a base to generate secrets for encrypting and signing data. For example, cookies and tokens are signed by default, but they may also be encrypted if desired. Defaults to nil as it must be set per application`"
"2022-11-02 07:21:07.782471+00","Same as above"
"2022-11-02 08:23:45.532473+00","@jhchabran / @davejrt Any reason we can't make this part of the base agent image?"
"2022-11-02 09:23:31.580267+00","Thanks. - Do we get warning in console? - Can we fix it? i.e. make correct itemKey?"
"2022-11-02 09:41:34.692602+00","oooh good point. I'll bail out rather then. Initially I aimed to keep existing behaviour"
"2022-11-07 16:24:19.516407+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion WHERE training_created_order = 1 AND is_initial = true ``` "
"2022-11-02 06:22:16.102489+00","```suggestion An environment variable is a dynamic-named value that affect the way running applications and services will behave within the system. Each variable contains a name and an associated value. We typically use them to provide credentials, and secrets for the applications that our system interacts with. Production and staging variables are defined in the appropriate [fly.io](fly.io/) project. Local variables are defined in `.envrc` which is a git-ignored file (you can create it from the template file `.envrc.example`). The values are highly sensitive and must stay private as they enable access to critical services that our system interacts with. Most of the values are stored on 1Password, while the most sensitive ones are kept in the related application for specific people to access them. This document defines all the environment variables that we use in `equanimity`. ```"
"2022-11-02 06:22:16.219369+00","Why is this removed?"
"2022-11-02 06:22:16.412489+00","```suggestion - `STRIPE_API_SECRET` is the secret key generated by Stripe. It's used to authenticate the requests made by our server to Stripe. There are a live/test mode secrets and start with ""sk_live_"" / ""sk_test_"" respectively. ```"
"2022-11-02 06:22:18.318498+00","You could also explain what is this used for"
"2022-11-02 06:22:20.426698+00","Can you list what are the AppSignal variable names?"
"2022-11-02 06:39:51.090264+00","```suggestion export interface FetchElasticResponse { ```"
"2022-11-02 06:44:05.242556+00","```suggestion private focusListener: Function; ```"
"2022-11-02 06:44:05.642335+00","Why did you add a new line here?"
"2022-11-02 06:47:06.839605+00","might be better to open up in new page instead of same page for usability"
"2022-11-02 06:47:06.981394+00","this type looks sus 😆 "
"2022-11-02 06:48:07.882497+00","```suggestion const URL = 'https://developers.gitstart.com/'; ``` Or get from env variable"
"2022-11-02 06:48:30.580633+00","```suggestion <meta property=""og:image"" content={`${URL}favicon.ico`} /> ``` There is the `/` at the end in URL"
"2022-11-02 06:52:22.201072+00","We do plan to add images and diagrams in a later step - right now, we're not entirely sure how they will render in GitBook, so don't want to spend too much time optimizing them in case they don't look good (and we're better off using just PNGs)"
"2022-11-02 06:54:43.260197+00","```suggestion private objectContainsTemplate(obj?: object) { if (!obj) { return false; } for (const key of Object.keys(obj)) { const typedKey = key as keyof typeof obj; if (this.isPrimitive(obj[typedKey])) { if (this.templateSrv.containsTemplate(obj[typedKey])) { return true; } } else if (Array.isArray(obj[typedKey])) { for (const item of obj[typedKey] as object[]) { if (this.objectContainsTemplate(item)) { return true; } } } else { if (this.objectContainsTemplate(obj[typedKey])) { return true; } } } return false; } ```"
"2022-11-02 06:59:04.552485+00","For select frontend framework , we are getting undefined value for `get(option, props.itemKey)` and `get(props.modelValue, props.itemKey)` in all option so every option are selected <img width=""1440"" alt=""Screen Shot 2022-11-02 at 12 40 48"" src=""https://user-images.githubusercontent.com/51731962/199421277-550a466c-6c44-447d-b3bb-d4e7f45ddba8.png""> "
"2022-11-02 07:03:02.12229+00","Thanks! We will keep this into account once we move to GitBook. This is a bit of a rough draft, so it's not organized in the prettiest way and sorely lacks visuals. We'll also aim to simplify the language once the content is live to ensure our point is getting across for non-native English speakers 😄 "
"2022-11-02 07:03:48.880994+00","Changed, thanks"
"2022-11-02 06:18:01.54027+00","Both the `zoomedOutPoint` and the `point` objects are used inside the else block. Changing the `point.xPx` and `point.yPx` values in the else block will produce a different result. Would it be okay if I just spread the rest of the `point` object properties inside the `zoomedOutPoint` object like so: ``` else if (this.zoomState === 'out') { const zoomedOutPoint = { ...point, xPx: zoomedOutPointRegions[pointIndex].x + (mouseX * thumbExtractZoomedOut / thumbDisplay), yPx: zoomedOutPointRegions[pointIndex].y + (mouseY * thumbExtractZoomedOut / thumbDisplay), magnification: thumbDisplay / thumbExtractZoomedOut, }; this.points.push(zoomedOutPoint); eventTarget.insertAdjacentHTML('afterend', ( <> <div class=""bulk-measure-modal-point"" data-zoom-level=""in"" style={{ top: Math.round((zoomedOutPoint.yPx - pointRegions[pointIndex].y) * (thumbDisplay / thumbExtract)) + 'px', left: Math.round((zoomedOutPoint.xPx - pointRegions[pointIndex].x) * (thumbDisplay / thumbExtract)) + 'px', }}></div> <div class=""bulk-measure-modal-point"" data-zoom-level=""out"" style={{ top: Math.round(( point.yPx - pointRegions[pointIndex].y) * thumbDisplay / thumbExtract) + 'px', left: Math.round(( point.xPx - pointRegions[pointIndex].x) * thumbDisplay / thumbExtract) + 'px', }}></div> </> ).s); } ```"
"2022-11-02 07:09:32.426798+00","This is a very slow way of doing it, specially with all the date parsing and stuff being called there."
"2022-11-02 07:20:52.155523+00","Same as above"
"2022-11-02 07:12:52.076172+00","I've added [a follow-up ticket in Linear](https://linear.app/gitstart/issue/PD-38/improve-developer-docs) as a catch-all for improvements we want to make to docs. We can add a few things in there going forward. We can create a separate ticket for features (not sure how we organize that + coordinate it with HelloNext output yet, maybe we can discuss in the next product team meeting)"
"2022-11-02 07:20:55.43115+00","Same as above"
"2022-11-02 07:58:05.482552+00","I think we can just use the standard `updateItem({ name: 'preference_field', payload: submission })` here since we won't ever be updating the specific properties that `getUpdateMetafield` is useful for. That function was designed specifically for the nuances of the preferences select"
"2022-11-02 07:58:05.512747+00","I would still suggest that we adopt the simplified, functional version expressed here - https://github.com/orthly/Scanner/pull/1048#discussion_r1011042749 In general it's preferred to avoid explicit for loops as it's easier to make mistakes and in this case harder to read"
"2022-11-02 07:58:05.626008+00","if you move this check out to a type guard function you shouldn't have to use the `as typeof MATERIALS_WITH_THICKNESS_OPTIONS[number]` cast below. Ping me if it's unclear what this means"
"2022-11-02 07:58:06.922491+00","if you merge in the changes from the latest develop you shouldn't need to include the next button here"
"2022-11-02 07:58:09.558224+00","instead of making this a function it's likely less error prone if we adopt a map structure with the following type so that we can just get the options directly: `{ [T in MaterialsWithThicknessOptions]: BigRadioOption<string>[] }`"
"2022-11-02 07:58:09.988329+00","Better yet, we should actually be able to pull these directly from the metafield that we get with `AllItemMetafields.find(f => f.id === field_id)` and we don't need to define them at all here"
"2022-11-02 08:05:18.041937+00","```suggestion ```"
"2022-11-02 08:18:16.022489+00","Fixed! And all tests pass ❤️ "
"2022-11-02 08:28:16.911734+00","I'm not sure if it's possible for the same field to have multiple entries in the errors list? I've never seen it happen, and I can try to create a test case with that scenario that could break this. What do you think @rlopzc @iurimadeira ?"
"2022-11-02 08:38:07.882506+00","Shouldn't this be `Owner`? ```suggestion RepositoryPathPattern: ""{nameWithOwner}"", ```"
"2022-11-02 08:38:13.670779+00","That's wrong, right? It just puts the pattern in the name. Is that what you wanted to test?"
"2022-11-02 08:39:40.112505+00","That is a good point; I confirmed that both return the same amount of data. I'll fix the docs, and I agree that `auditId` is more idiomatic than `sampling immunity token`; the latter makes the search de facto depending on the side effect."
"2022-11-02 08:39:51.261862+00","Weird that the template isn't been populated here. For example, the other tests don't do this: https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/internal/repos/testdata/golden/GithubSource_makeRepo_path-pattern"
"2022-11-02 08:40:16.068453+00","same as the other file, it is fine to overwrite err. You may in fact want to handle coming across an err as a function argument. From reading the code, I'd recommend just logging and skipping. (the err in WalkDir comes from failing to stat something, eg permission error)"
"2022-11-02 08:40:16.100954+00","log error as well"
"2022-11-02 08:40:16.250259+00","last statement in function, no point using defer"
"2022-11-02 08:40:17.090429+00","over writing err is fine here. additiionally you need to return innerErrr if this fails, not the err param."
"2022-11-02 08:40:17.280033+00","this should be err"
"2022-11-02 08:41:03.350026+00","doh - thanks. Will fix"
"2022-11-02 08:44:32.187554+00","Fixed"
"2022-11-02 08:51:08.242473+00","Thanks for the observation"
"2022-11-02 09:10:26.628253+00","right - I'll take a look at them. Thanks for flagging it @bobheadxi "
"2022-11-02 09:56:33.766777+00","Why the use of `any` type?"
"2022-11-02 10:57:21.652072+00","I think this looks a bit off with the icon just dangling in a separate line: <img width=""713"" alt=""screenshot_2022-11-02_11 56 22@2x"" src=""https://user-images.githubusercontent.com/1185253/199472405-4c582b74-9b6b-4d5f-b00e-e948fc0e20b1.png""> I played around a bit with the code and arrived at this: <img width=""713"" alt=""screenshot_2022-11-02_11 55 20@2x"" src=""https://user-images.githubusercontent.com/1185253/199472451-d21046d0-06ef-4d41-b5dd-9da08262da16.png""> I think that's better. WDYT? Here's the diff for how to get there: ```diff diff --git a/client/web/src/site-admin/WebhookNode.module.scss b/client/web/src/site-admin/WebhookNode.module.scss index 1233407166..17b5a37a22 100644 --- a/client/web/src/site-admin/WebhookNode.module.scss +++ b/client/web/src/site-admin/WebhookNode.module.scss @@ -3,6 +3,7 @@ // Make it full width in the current row. grid-column: 1 / -1; border-top: 1px solid var(--border-color-2); - padding-bottom: 0.3rem; + margin-top: 0.5rem; + padding-bottom: 0.5rem; } } diff --git a/client/web/src/site-admin/WebhookNode.tsx b/client/web/src/site-admin/WebhookNode.tsx index 068332471c..67f580e8d2 100644 --- a/client/web/src/site-admin/WebhookNode.tsx +++ b/client/web/src/site-admin/WebhookNode.tsx @@ -2,7 +2,7 @@ import React from 'react' import { mdiCog, mdiDelete } from '@mdi/js' -import { Button, H3, Icon, Text, Tooltip } from '@sourcegraph/wildcard' +import { Button, H3, Icon, Tooltip } from '@sourcegraph/wildcard' import { defaultExternalServices } from '../components/externalServices/externalServices' import { WebhookFields } from '../graphql-operations' @@ -19,34 +19,23 @@ export const WebhookNode: React.FunctionComponent<React.PropsWithChildren<Webhoo <> <span className={styles.nodeSeparator} /> <div className=""pl-1""> - <H3 className=""pr-2"">{node.codeHostURN}</H3> - <Text className=""mb-0 text-muted""> - <small> - <Icon as={IconComponent} aria-label=""Code host logo"" className=""mr-2"" /> - </small> - </Text> + <H3 className=""pr-2""> + {' '} + <Icon inline={true} as={IconComponent} aria-label=""Code host logo"" className=""mr-2"" /> + {node.codeHostURN} + </H3> </div> <div className=""d-flex flex-shrink-0 ml-3""> <div> <Tooltip content=""Edit webhook""> - <Button - aria-label=""Edit"" - className=""test-edit-webhook"" - variant=""secondary"" - size=""sm"" - > + <Button aria-label=""Edit"" className=""test-edit-webhook"" variant=""secondary"" size=""sm""> <Icon aria-hidden={true} svgPath={mdiCog} /> Edit </Button> </Tooltip> </div> <div className=""ml-1""> <Tooltip content=""Delete code host connection""> - <Button - aria-label=""Delete"" - className=""test-delete-webhook"" - variant=""danger"" - size=""sm"" - > + <Button aria-label=""Delete"" className=""test-delete-webhook"" variant=""danger"" size=""sm""> <Icon aria-hidden={true} svgPath={mdiDelete} /> </Button> </Tooltip> ``` "
"2022-11-02 08:55:11.719464+00","@IceCreamYou based on your points above, would we be expecting any changes to the ticket scope?"
"2022-11-02 09:07:23.869568+00","@rwagatenga When we are Implementing the pagination, we need the Total based on the Pipeline/Query, if I use `$count` on the same `pipeline` on a single `EnvelopeService.getEnvelopeActivities({});` I won't get the exact total number because I'm applying `{ $skip: skipPage }, { $limit: limit }` in the same pipeline"
"2022-11-02 09:13:18.1033+00","Please get rid of this(it is hacky code), this is an interface to a `FetchResponse` and it clearly does not have this property."
"2022-11-02 09:13:19.170117+00","`this.request` will make the actual request using `getBackendSrv().fetch()`, note that `fetch` takes an optional type parameter `fetch<T>` that specifies the type of data the response will contain. We expect the response to be of type `FetchElasticResponse` hence we use `fetch<FetchElasticResponse>`. fetch will return an Observable(rxjs) of type `Observable<FetchResponse<FetchElasticResponse>>`, we transform this observable using `pipe` and `map` to a new type `Observable<FetchElasticResponse>`"
"2022-11-02 09:15:04.63206+00","should we bail out here? it would mean that the hostname doesn't match below and it would remove repos if the DB is down for example "
"2022-11-02 09:48:59.227038+00","Yes we get warning in console. "
"2022-11-02 09:56:31.119115+00","```suggestion @spec get_total_time_spent_in_minutes_query(pos_integer()) :: Ecto.Queryable.t() ```"
"2022-11-02 09:56:31.166699+00","```suggestion ) :: pos_integer() ```"
"2022-11-02 09:56:31.316844+00","```suggestion @spec team_lead(pos_integer()) :: Ecto.Query.t() ```"
"2022-11-02 09:56:31.825352+00","```suggestion @spec possible_assignees(pos_integer()) :: [GitstartEngine.Accounts.User.t()] ```"
"2022-11-02 09:56:32.162264+00","```suggestion @spec client_manager(pos_integer()) :: Ecto.Query.t() ```"
"2022-11-02 09:56:32.174298+00","```suggestion @spec repository_owner(pos_integer()) :: Ecto.Query.t() ```"
"2022-11-02 09:56:32.526334+00","```suggestion @spec get_total_time_spent_in_minutes(Task.t()) :: pos_integer() ```"
"2022-11-02 09:56:32.762907+00","I don't think we return error here ```suggestion @spec bootstrap_new_task_attrs(map()) :: {:ok, map()} ```"
"2022-11-02 09:56:33.063748+00","```suggestion @spec list_tasks(map(), pos_integer(), Keyword.t()) :: Ecto.Queryable.t() ```"
"2022-11-02 09:56:33.976491+00","```suggestion @spec team_member(pos_integer()) :: Ecto.Query.t() ```"
"2022-11-02 09:56:35.95342+00","```suggestion @spec instance_manager(pos_integer()) :: Ecto.Query.t() ```"
"2022-11-02 10:10:36.341273+00","1. fix the typo here, should be componentWillUnmount 2. can't seem to find where this function is been used in the code "
"2022-11-02 10:11:01.991833+00","```suggestion async componentWillUnmount() { ```"
"2022-11-02 10:16:19.008869+00","Is that the correct error message? The comment says we're waiting for Perforce to be added as authz provider. I know this sounds nitpicky, but these errors are crucial when debugging why a test fails or is flaky"
"2022-11-02 10:16:19.028371+00","Nitpick, but I do think multi-line strings with funny intendation are uglier than a single line: ```suggestion const query = `query { authzProviders }` ```"
"2022-11-02 10:16:19.103336+00","> This new gql api is basically the equivalent of the repo-updater debug endpoint that you posted, just for the frontend. Would it make sense then to tag this query as ""for internal use only"", like [some of the other queries we have](https://sourcegraph.sourcegraph.com/search?q=file%3Agraphql%24+internal&groupBy=repo)?"
"2022-11-02 10:16:19.897717+00","Is that correct here or should you `return gqltestutil.ErrContinueRetry`? Also, does this need a error message too? (`t.Fatal(""failed to fetch authzProviders"", err)`)"
"2022-11-02 10:17:18.665305+00","You could also pull `backend.NewRepos` out of the loop, right?"
"2022-11-02 15:13:41.499541+00","We don't need this I believe, ObjectId already exists in the imports"
"2022-11-02 10:24:04.231649+00","I am not sure if these should take a separate file since it carries no props or states. "
"2022-11-02 10:25:52.999796+00","This needs to be generated based on operating system."
"2022-11-02 10:31:47.06016+00","? ```suggestion subHeading=""Reach out at feedback.gitstart.com"" ```"
"2022-11-02 10:32:08.782487+00","```suggestion ```"
"2022-11-02 10:36:56.184537+00","Thanks for catching the typo @hakeem-gitstart "
"2022-11-02 10:37:01.915956+00","```suggestion 1. Based on your intuition, experience, and judgment, reference the rubrics and apply the 3 checklists to rate the levels of 3 determinants. ```"
"2022-11-02 10:37:02.601881+00","""Can't run the project without reading the documentation"" I'm not sure if this is necessarily a bad thing... Usually reading documentation is a must :) "
"2022-11-02 10:37:02.651067+00","I wouldn't say ""because we do not know where things are"" , because no one ""knows"" it when they first start. I think it's more about how well organized the codebase and easy to find things"
"2022-11-02 10:38:00.454022+00","Should this part not happen before the `err := client.ScheduleUserPermissionsSync(userID)` line? Or does it not matter here? Feels weird that we're only confirming the authz provider after the user permissions have been synced."
"2022-11-02 10:40:23.935354+00","If you do not use `break` in the switch statement, it will automagically fall through, so this will be shorter, since both statements are the same: ```suggestion case 'openidconnect': case 'saml': ```"
"2022-11-02 10:40:24.041634+00","Love this ❤️ "
"2022-11-02 10:53:09.195442+00","What if there is more than one provider of the same type? What is returned in that case? E.g. if we have 2 github oauth providers configured, what is the output of this query? `['github']` or `['github', 'github']`? This is a configuration that is used sometimes (even in our Cloud Managed Instances, but as far as I know we have no tests for that..."
"2022-11-02 10:53:09.374305+00","Should we instead use exponential backoff strategy? The current [`Retry` implementation](https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/internal/gqltestutil/helper.go?L32) retries every 100ms, which is not ideal. Not sure how it would impact the scope of this PR, but that might be a better strategy for retries like this."
"2022-11-02 10:53:09.632472+00","I would like to see a unit test for this resolver, as it's a new functionality added and by convention we usually test every resolver / exposed graphql entity."
"2022-11-02 10:54:22.604991+00","Ah, you're right. Yes, that is a good suggestion. 👍"
"2022-11-02 10:55:32.682593+00","@hmncube Changing this to be `private focusListener: Function` would require it to have an initialiser or to be assigned in the constructor, However, making it to be optional like `private focusListener?: Function;` would result to a ts error in `componentWillUnmount`  leaving it to be of type any is the best solution I can think of , kindly let make know if you have a better solution "
"2022-11-02 10:57:27.775824+00","nice. will do"
"2022-11-02 10:57:36.670694+00","You have a single element here, you don't need to wrap it in a fragment (which you'd need if you want to have multiple elements here): ```suggestion <ButtonLink className=""test-create-webhook"" variant=""primary""> <Icon aria-hidden={true} svgPath={mdiPlus} /> Add webhook </ButtonLink> ```"
"2022-11-02 10:57:38.656733+00","I don't think you need `useCallback` at all here. You can just pass `queryWebhooks` to the component."
"2022-11-02 10:57:38.947683+00","Any specific reason why you went with `FilteredConnection`? Since we do not have filters you could probably use `useConnection`. ""Officially"" `FilteredConnection` is deprecated. See, as an example, [this function here and how it's used](https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/client/web/src/enterprise/batches/settings/backend.ts?L107-132&subtree=true). Or [this one here](https://sourcegraph.sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/client/web/src/repo/stats/RepositoryStatsContributorsPage.tsx?L205&subtree=true). Totally get if `FilteredConnection` is easier to use though."
"2022-11-02 10:59:48.583172+00","That's wrong, needs to say ""webhook"""
"2022-11-02 11:02:44.999207+00","What I described above is the intended original scope of this story, although the ticket description did not describe it sufficiently clearly. Whether it changes the scope depends on what you interpreted the original scope to be I guess, but if we had been clear about what was needed from the beginning, I do not think the effort for the intended scope would have been significantly larger than what is contemplated so far in this PR. With that said, please ask questions if anything is unclear."
"2022-11-02 11:23:34.462619+00","It seems to work: ``` iex(8)> %Ecto.Changeset{} |> Ecto.Changeset.add_error(:description, ""Description cannot be nil"") |> Ecto.Changeset.add_error(:description, ""Description cannot be something"") #Ecto.Changeset< action: nil, changes: %{}, errors: [ description: {""Description cannot be something"", []}, description: {""Description cannot be nil"", []} ], data: nil, valid?: false > ```"
"2022-11-02 11:37:27.480117+00","@MatheusBeniniF is this a required change?"
"2022-11-02 11:46:45.616452+00","Yes – what's our pattern for this?"
"2022-11-02 11:55:11.975631+00","Alright, please can you update the ticket description with the clearly expected requirements so we can be sure of the acceptance criteria? @IceCreamYou "
"2022-11-02 11:58:14.558798+00","Added this to help debugging"
"2022-11-02 12:04:14.607684+00","I took https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/client/web/src/enterprise/batches/BatchSpecsPage.tsx?L98&subtree=true as an example, it was pretty easy to use, actually. I can change it to `useConnection` as a next iteration (so that I don't use deprecated stuff) if it is fine."
"2022-11-02 12:04:27.978157+00","Thanks, will fix that!"
"2022-11-02 12:03:53.836489+00","role here is an atom with the following values `[:admin, :user, :internal]` So we can add a type spec in the `ClientUser` model as follows: `@type roles :: :admin | :user | :internal` Then we can say `ClientUser.roles()` "
"2022-11-02 12:05:00.651422+00","not really, will delete"
"2022-11-02 12:05:41.616277+00","that's so much better, thanks!"
"2022-11-02 12:22:53.022197+00","```suggestion const publicEventTypes = eventTypes?.filter((evt) => !evt.hidden); ```"
"2022-11-02 12:22:54.037464+00","```suggestion {!isEmbed && !!publicEventTypes?.length && ( ```"
"2022-11-02 12:52:25.279221+00","it is not, probably this change appeared in a merge with main"
"2022-11-02 13:26:43.496942+00","Probably the directory itself can be added as well? ```suggestion canReadAll: []string{""dir/file.java"", ""dir/""}, ```"
"2022-11-02 13:38:33.781116+00","I believe this represents all roles, lets use `Object.keys(EnvelopeRecipientRoleEnum)`"
"2022-11-02 13:38:33.831592+00","The errorr enum does not match the error message ```suggestion throw new NotFoundError(ErrorEnums.ENVELOPE_RECIPIENT_NOT_FOUND, 'Envelope recipient not found'); ```"
"2022-11-02 13:38:33.819929+00","Organize imports alphabetically i.e. from A-Z"
"2022-11-02 13:38:35.611416+00","Should have an await Add `.lean()` as well"
"2022-11-02 13:38:35.609438+00","If this represents all roles use `Object.keys()`"
"2022-11-02 15:38:47.350227+00","Move to correct section"
"2022-11-02 13:38:35.67029+00","return directly"
"2022-11-02 13:38:35.715772+00","@usmailaabdoul , use clients suggestion above ```suggestion return [ ...recipientsWithoutKyc, ...recipientsWithKyc ] ```"
"2022-11-02 13:38:37.631979+00","Same here"
"2022-11-02 14:13:12.41745+00","remove this and stop adding them"
"2022-11-02 13:38:37.178863+00","Nuke this validation, not sure why we are adding this"
"2022-11-02 13:38:37.615911+00","Should have an await, and space before this return ```suggestion return await EnvelopeRecipient.findOneAndUpdate( ```"
"2022-11-02 13:42:26.273804+00","Is this not a recursive call, or is there work outstanding here?"
"2022-11-02 13:44:29.780496+00","```suggestion return s.store.ProcessStaleSourcedCommits(ctx, minimumTimeSinceLastCheck, commitResolverBatchSize, commitResolverMaximumCommitLag, shouldDelete) ``` WOW good catch"
"2022-11-02 13:50:10.337174+00","@sheldon-welinga this is required to validate the field the user is trying to update not all fields should be updated"
"2022-11-02 13:57:46.429098+00","@sheldon-welinga we can't return and await at thesame time"
"2022-11-02 14:08:57.214497+00","`debugger`! "
"2022-11-02 14:09:09.605927+00","```suggestion logger.Error(""Invalid UPDATE_CHECK_BASE_URL. Using default url"", log.String(""UPDATE_CHECK_BASE_URL"", base), log.String(""defaultURL"", defaultUpdateCheckBaseURL)) ```"
"2022-11-02 14:09:16.85827+00","```suggestion Setting the `UPDATE_CHECK_BASE_URL` to the value provided by Sourcegraph support on the `frontend` application manifest will ensure that ```"
"2022-11-02 14:12:54.370336+00","remove this"
"2022-11-02 14:22:37.878774+00","I think we are destructuring what we need to update and creating a new object out of it, no need for this"
"2022-11-02 14:25:12.54653+00","It's fine to be nitpicky! I appreciate it 🙏 This is not super polished since I wanted to get some feedback on whether everyone was okay with this approach before I spent too much time on it. "
"2022-11-02 14:27:19.876611+00","@charlottemeng isn't part of the audit to check for .YML and looker uses? I'm wondering if this should be T4 (unsupported) until we determine otherwise. The logic (but not this view) is being used, but you could also check for looker views, and then if those are being used in the content checker"
"2022-11-02 14:27:38.962506+00","but we need to throw an error right?"
"2022-11-02 14:28:42.726315+00","Honestly this is only being used for this test, to check the list of authz providers that the frontend is using. I'll mark the query as internal as @mrnugget suggested to clarify that. If we need to provide more details about the providers in the list (i.e. the url, etc) we can add that if and when we need it. "
"2022-11-02 14:29:25.254392+00","V good point, I'll check if it's in Looker and demote to T4 when I confirm it's not being used?"
"2022-11-02 14:33:07.239126+00","Ok, just return directly then"
"2022-11-02 14:33:25.99379+00","So, that permissions sync will be using a different list of authz providers (in theory the same, just initialized/kept up to date in a different place in the code). I haven't run into that causing any flakiness in the tests. Wrt the backoff strategy, I was just using the pattern from the other gql tests. I'm not sure if there are any problems or flakiness that would arise if we switched to exponential backoff, but it's maybe worth exploring at some point."
"2022-11-02 14:34:40.446854+00","I found your bug, wrap it in a try-catch, its the reason for the complain"
"2022-11-02 14:56:50.09878+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-02 15:13:41.970433+00","Revert this line, this file should only deal with EnvelopDocument and not EnvelopeDocumentVersion"
"2022-11-02 14:34:47.145927+00","@usmailaabdoul "
"2022-11-02 14:34:55.998953+00","I don't think we want to continue retrying if there's an error fetching the authz providers. But you're right, we should wrap the error for more context."
"2022-11-02 14:41:12.935248+00","You can reference below  "
"2022-11-02 14:48:22.871412+00","mmmmm I'm wondering about this one. In Glob terms, you can technically specify something like `/**/**/**/*.java` and it would still match Java files at the root. However, just trimming once would fail to catch that case. But, in terms of Perforce rules, I'm not sure if Perforce allows a rule like `//depot/main/.../.../.../*.java` or whatever. If it does, then those would be edge cases we can't catch. If it does not, then maybe we don't have to care? Even though it's technically still wrong. What we can do to get around this is to do the trimming in a loop until all the double stars are gone?"
"2022-11-02 14:50:40.122937+00","I was thinking about this (generally I 1000% agree) but I wasn't sure what I'd be testing for, exactly. It's basically just returning a list and there's really no functionality within this function itself since it's basically just a wrapper around `authz.GetProviders()`. But I'm never gonna say no to adding more tests, so I'll go ahead and add one 😂 😅 "
"2022-11-02 14:53:47.322512+00","You can just validate the fields that need to be updated, we do nothing otherwise I guess, Just like how we are doing it on create. Tried checking the codebase, there is no validation for unwanted fields in any method I have seen, unless you have one"
"2022-11-02 14:53:54.439362+00","want to go ahead and commit this?"
"2022-11-02 14:56:49.182173+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ORDER BY order_tasks.task_created_at) AS previous_task_type ``` "
"2022-11-02 14:56:49.515539+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion WHERE COALESCE(previous_task_flow_order, 99) >= task_flow_order ``` "
"2022-11-02 14:56:49.564495+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-02 14:56:51.48742+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-02 14:56:49.589101+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ORDER BY order_tasks.task_created_at) AS previous_task_flow_order ``` "
"2022-11-02 14:56:51.405109+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , SUM( (COALESCE(order_tasks.task_closeout_event__designreview_rejected::INT, 1) = 0)::INT ) AS reviews__design_review_approvals ``` "
"2022-11-02 14:56:49.79205+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , order_tasks.task_created_at , NULL) ) IGNORE NULLS OVER ( ``` "
"2022-11-02 14:56:51.130769+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion AND COALESCE( internaldesign__task_closeout_reason, 'force a failure for nulls' ) = 'Completed' AS is_final_delivered_design ``` "
"2022-11-02 14:56:51.407415+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion order_tasks.order_id ASC , flows.flow_sequence_number ASC ``` "
"2022-11-02 14:56:50.358772+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion /* description flow_sequence_number = A sequence number that shows which attempt or ""flow"" design tasks belong to. ``` "
"2022-11-02 14:56:50.379181+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion /* if it's either of these fields, then we cast as a bool */ {% if field in ['is_active_task', 'task_assigner__is_autoassign'] %} )[0]::INT AS designreview__{{ field | replace(""__"", ""_"") }} {% else %} /* otherwise we cast as a varchar */ )[0]::VARCHAR AS designreview__{{ field | replace(""__"", ""_"") }} {% endif %} ``` "
"2022-11-02 14:56:50.497343+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-02 14:56:50.688245+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion flows.flow_start ``` "
"2022-11-02 14:56:51.306229+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ORDER BY order_tasks.task_created_at) AS next_design_prep_created_at ``` "
"2022-11-02 14:56:52.044636+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , CASE WHEN COUNT_IF( order_tasks.task_type = 'InternalDesign' ) > 0 /* we need to make sure there was an internal design for this flow */ THEN MIN( IFF( order_tasks.task_type IN ('LabAcceptOrder', 'AcknowledgeDelivery') OR ( order_tasks.task_type = 'DesignReview' AND COALESCE( order_tasks.task_closeout_event__designreview_rejected::INT, 1 ) = 0 ) , order_tasks.task_created_at, NULL ) ) END AS design_delivery_confirmed_at ``` "
"2022-11-02 14:56:52.315255+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion coalesce to an impossible number (only 1&2 are possible) so it returns true because first task has no previous resulting in a null and then where clause excludes it ``` "
"2022-11-02 16:13:04.173282+00","no i think we actually want to make them set it now since this will eventually be mapped to the staff member, and that requires a role"
"2022-11-02 14:56:52.432817+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion WHEN order_tasks.task_type = 'InternalDesign' THEN 2 END AS task_flow_order ``` "
"2022-11-02 14:56:52.648453+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion /* description is_new_design_prep = DesignPreps are attributed to all internal design attempts until there is a new one. To avoid double counting design prep units, use this flag to filter the count for only the first time the design prep was used */ ``` "
"2022-11-02 14:56:53.353582+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ``` "
"2022-11-02 14:55:50.032473+00","@raj360 @elikeyz Please take a look at the implementation of keyboard accessibility on `EmojiMenu`, perhaps there might be some further improvements to be made. I have also added a new demo video on the PR description to test the behavior of the `EmojiMenu` please check it out. CC: @lazymia "
"2022-11-02 14:59:06.909394+00","ok then"
"2022-11-02 15:03:20.639081+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion WHERE field = 'Assigned_Pod__c' ``` "
"2022-11-02 15:04:28.589221+00","Yeah, good point. That part of the change was a bit of a quick hack so not surprised I missed something there :) "
"2022-11-02 15:13:39.882262+00","Revert this file/ Ensure you have the latest changes"
"2022-11-02 15:13:40.124269+00","We need to add a supertest in test/routes file for the envelopes i.e. `envelopes.tests.js`"
"2022-11-02 15:13:40.290695+00","Revert"
"2022-11-02 15:13:40.380295+00","Your pipeline is vague if you are writing a filter here, please check this"
"2022-11-02 15:13:41.230797+00","Revert this file to main/merge from main"
"2022-11-02 15:13:42.179954+00","Only check if no permission, Users with Manage can also read envelope documents as they have all permissions"
"2022-11-02 15:13:42.472185+00","Nuke this, this file should not have any change I believe. Use Unauthorized operation, It already exists"
"2022-11-02 15:13:42.957413+00","Nuke ```suggestion ```"
"2022-11-02 15:08:47.435802+00","~~do you need to do a similar check here? wouldn't this get triggered twice then?~~ i am an idiot 🤦 "
"2022-11-02 15:38:40.892821+00","Organize imports and also sort from A-Z"
"2022-11-02 15:38:41.558485+00","Sort enum imports here from A-Z"
"2022-11-02 16:26:40.64683+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , COALESCE(fcpid.fc_pid, bizible_session.visitor_id) AS full_contact_id ``` "
"2022-11-02 15:13:43.138701+00","This function should be done in`EnvelopeDocumentVersionService` not this"
"2022-11-02 15:13:43.803124+00","Follow the convention ```suggestion GET_ENVELOPES_DOCUMENTS: 'envelope.documents.get', ```"
"2022-11-02 15:13:43.943412+00","Use better names, write in full the keyword envelope"
"2022-11-02 15:13:44.753127+00","Add other metadata here e.g. envelopeId, statuses, withLatestVersion e.t.c"
"2022-11-02 15:13:45.17373+00","We should not have any filter/map, All filters should be done in the aggregate query"
"2022-11-02 15:13:47.357165+00","Use sentence case ```suggestion throw new NotFoundError(ErrorEnums.ENVELOPE_DOCUMENT_NOT_FOUND, 'Envelope document not found'); ```"
"2022-11-02 15:24:09.155926+00","I just checked and Perforce *does* allow you to save rules like `.../.../*.java`"
"2022-11-02 15:25:22.132335+00","Hmm I took it from [this file](https://sourcegraph.sourcegraph.com/search?q=context:global+documentationUrlPrefix&patternType=standard), but I'll remove both instances of it if it's not needed then"
"2022-11-02 15:32:15.289706+00","Your call in the end, not blocking here. But then again: why do it ""wrong"" when we know we need to do it ""right"" immediately after? It'll never be easier to use the non-deprecated solution than now :)"
"2022-11-02 15:38:40.523631+00","This imports should come first"
"2022-11-02 15:38:40.746324+00","Wrap in try-catch"
"2022-11-02 15:38:41.384248+00","We are not using this, delete it ```suggestion ```"
"2022-11-02 15:38:42.322041+00","Wrap in try-catch"
"2022-11-02 15:04:24.841486+00","Next steps: - [x] Test this - [x] Un-export the three methods we use internally - [x] Inline for bulk updates, set a txn, etc. for more meaningful semantics"
"2022-11-02 15:38:41.729747+00","Also add the role, capacity, color and used to the metadata"
"2022-11-02 15:38:42.527757+00","Sort and organize imports"
"2022-11-02 15:38:42.815242+00","We don't have anything a EnvelopeModel, Its just Envelope, Revert this change"
"2022-11-02 15:38:43.781504+00","Expect specific parts of the `body.data` and not body. Also we should not have an expect like typeof, that is wrong. Target specific parts, is even better to say expect it to be defined We can also have an expect length if its an array e.t.c, but never expect with typeof"
"2022-11-02 15:38:44.690827+00","Also expect envelopeId to match the query id"
"2022-11-02 15:38:44.741357+00","Nuke comments ```suggestion ```"
"2022-11-02 15:38:44.872694+00","Remove this space"
"2022-11-02 15:38:44.983352+00","Use async, remove done"
"2022-11-02 15:38:45.238609+00","```suggestion const StatusEnums = require('../../imports/api/enums/statusEnums ```"
"2022-11-02 15:38:45.847509+00","Don't forget the space after each category of imports. The above import should come second as its a model"
"2022-11-02 15:38:46.348445+00","Nuke the space"
"2022-11-02 15:38:46.619794+00","Sort imports A-Z"
"2022-11-02 15:38:47.759109+00","generally, organize imports and sort them A-Z"
"2022-11-02 15:38:46.711396+00","Avoid repetition of code, Have a top describe and later child describe inside"
"2022-11-02 15:38:52.622952+00","Nuke space"
"2022-11-02 15:44:21.34128+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , flows.flow_sequence_number ASC ``` "
"2022-11-02 15:50:23.651068+00","Yes good call, adjusted in [b35babe](https://github.com/sourcegraph/sourcegraph/pull/43766/commits/b35babef92e2976a26db4b8772b56ff53ba8c39a). Since we can't do conditional hooks, I moved the logic up to the `useQueryExamples` hook & exit functions & return the static examples for dotcom. Let me know if you see any issues here! I didn't see any server call's running from that hook with the adjusted logic"
"2022-11-02 15:53:11.355989+00","`updatedField!` isn't an actual runtime check like the pre-existing logic, so would end up loosening the safety of the current checks."
"2022-11-02 15:54:32.650468+00","Also our lint rules don't like it, either."
"2022-11-02 15:56:10.602512+00","Merge latest changes, this should not be nuked I believe"
"2022-11-02 15:56:10.889768+00","This check should still exists, please revert"
"2022-11-02 15:56:11.046837+00","Start with should and add space above each `it()"
"2022-11-02 15:56:11.344258+00","Start with should"
"2022-11-02 15:56:11.383826+00","Start with `should` ```suggestion it('should filter for uniqueNames is true', async () => { ```"
"2022-11-02 15:56:11.479082+00","Check should still exist"
"2022-11-02 15:56:12.182404+00","Avoid unnecessary changes"
"2022-11-02 15:56:12.414217+00","Nuke limit, no section mentions that"
"2022-11-02 15:56:14.66401+00","Revert"
"2022-11-02 15:56:13.104031+00","Also add check for length of array"
"2022-11-02 15:56:14.32825+00","Not enough checks, Target specific values, if result is an array, expect length to be a specific value e.t.c"
"2022-11-02 15:56:15.221898+00","Also check length of array"
"2022-11-02 16:09:58.672208+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion SELECT * , LOWER( REPLACE( REPLACE( REPLACE(REPLACE(REPLACE(REPLACE(refab_reason_category, ' ', '_'), '(', ''), ')', ''), '/', '_') , '-' , '_' ) , '''' , '' ) ) AS refab_reason_category_cleaned FROM lab_order_reason_vm_enriched ``` "
"2022-11-02 16:10:35.509302+00","can we call this previous value instead of old value?"
"2022-11-02 16:11:56.200629+00","super minor, but can we capitalized IS NULL?"
"2022-11-02 16:12:00.922491+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion SELECT * , LOWER( REPLACE( REPLACE( REPLACE(REPLACE(REPLACE(REPLACE(refab_reason_category, ' ', '_'), '(', ''), ')', ''), '/', '_') , '-' , '_' ) , '\'' , '' ) ) AS refab_reason_category_cleaned FROM lab_order_reason_vm_enriched ``` "
"2022-11-02 16:12:12.585327+00","`caseNotes` shouldn't be optional. If you don't pass something in for `caseNotes` then this method doesn't do anything."
"2022-11-02 16:12:12.682469+00","Fix this comment, I'm guessing you mean to talk about the caseNotes param"
"2022-11-02 16:12:12.785473+00","Alternatively, you can remove this parameter, and instead return the string that you build at the end. Leave it up to the caller to add the caseNote string to an array."
"2022-11-02 16:12:13.731748+00","NIT: I'd rather see `caseNotes` set here. ``` caseNotes.push(buildImplantPartsCaseNotes(item)); return this.buildImplantProduct(item); ``` See my suggestion on `buildImplantPartsCaseNotes` about removing the second parameter."
"2022-11-02 16:12:14.036741+00","go home sqlfluff"
"2022-11-02 16:13:03.742481+00","let's actually make this logic something like `name.split(' ').slice(1).join(' ')`, i.e. first name should be the first word and the last name is everything else in case someone has one of those multi word last names loll"
"2022-11-02 16:13:04.061546+00","ahhh icic, update looks good, tyty!"
"2022-11-02 16:14:44.859645+00","leftover comment?"
"2022-11-02 16:20:13.711584+00","why is this change being made? This is the naming that was requested from the PLs during the original implementation and it makes no sense to create a breaking graphql change for the sake of a rename"
"2022-11-02 16:21:17.017915+00","Good catch! I was able to remove the entire caching infrastructure, which is a nice cleanup"
"2022-11-02 16:25:11.812476+00","agree with sql fluff- let's make this a coalesce"
"2022-11-02 16:26:16.532476+00","I believe we don't want to `--wait` on execute, assuming this means wait for the execution to complete"
"2022-11-02 16:26:39.702961+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion AND bizible_session.ip_address = fcpid.context_ip AND DATE_TRUNC('minute', bizible_session.event_date) = DATE_TRUNC('minute', fcpid.timestamp) AND COALESCE(bizible_session.referrer_page, 'NA') = COALESCE(fcpid.context_page_referrer, 'NA') ``` "
"2022-11-02 16:26:39.785841+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion LEFT OUTER JOIN fcpid ``` "
"2022-11-02 16:26:39.813708+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion SELECT * FROM {{ source('segment_marketing_website', 'fcpid') }} ``` "
"2022-11-02 16:26:53.331785+00","need to `waitForCloudRunJob` on execute here too"
"2022-11-02 16:29:00.333519+00","Instead of truncating, could we look where the difference between bizible_session.event_date and fcpid.timestamp is less than a minute? to take into account the edge case you mentioned in standup"
"2022-11-02 16:37:41.412494+00","The ProductLine definitions provided by Ops: - https://www.notion.so/orthly/Product-Line-Implementation-88c577ad632a423fbd2b92f962efa356#3880f1ad15864000b41d851901843442 - https://www.notion.so/orthly/Product-Line-Implementation-88c577ad632a423fbd2b92f962efa356#9573ca0c9a0d4f43b573fdb90fd75788 - https://www.notion.so/orthly/Product-Line-Implementation-88c577ad632a423fbd2b92f962efa356#0add70ba8fc246779b481becf6ad225f"
"2022-11-02 16:38:23.80476+00","@brianna-kincaid done :)"
"2022-11-02 16:38:27.827615+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion AND bizible_session.ip_address = fcpid.context_ip AND COALESCE(bizible_session.referrer_page, 'NA') = COALESCE(fcpid.context_page_referrer, 'NA') AND bizible_session.event_date BETWEEN DATEADD( 'second', -60, fcpid.timestamp ) AND DATEADD('second', 60, fcpid.timestamp) ``` "
"2022-11-02 16:38:51.385676+00","thank you!"
"2022-11-02 16:39:49.071122+00","is the `<= 25` correct here?"
"2022-11-02 16:43:17.955556+00","we have https://github.com/immunefi-team/bugs/blob/898de871c73626a21baca291cbcdfdfa5ce4d1b1/components/FeatureControl.tsx to render components by feature flags"
"2022-11-02 16:46:14.332561+00","maybe a comments will help understand this changes faster"
"2022-11-02 16:51:21.527543+00","I'll add a comment for readability, the math is the same and this converges to your solution when rest = 0.5 `0.5 * (sortedConfidence[base] + sortedCandidates[base + 1])` `sortedConfidence[base] + .5 * (sortedConfidence[base + 1] - sortedCandidates[base])`"
"2022-11-02 16:52:56.401864+00","```suggestion // Here we linearly interpolate between the discrete values // found at index base and base + 1 const base = Math.floor(pos); ```"
"2022-11-02 16:53:51.371259+00","can we check that the user has 0 paid reports here `expect(user.totalPaidReports).toBe(0);` "
"2022-11-02 16:55:46.654299+00","not fan of snapshots but, can we just validate presence of things here, os should we test the design too?"
"2022-11-02 17:34:05.032486+00","Yeah me too, but last time we talked about this we agreed to use a combination of component existence and component snapshots tests. However, I believe some cases it will be difficult because a component can be affected by many feature flags, so not all the time is going to be possible to do snapshot testing."
"2022-11-02 17:47:06.577764+00","The handling of this is definitely quite bad. We can add a fixture to make this less bad in the consumer tests. The reason I didn't include that right now is there is a built in baseURL fixture that I wasn't able to figure out how to properly override. The two solutions I can imagine are to just make a different fixture for the url, or look more deeply into how to override the base one. That still leaves open how to do this more nicely in utility functions like this one, though."
"2022-11-02 18:55:34.403339+00","It will work but I thought it looked funky with the design (the added title) & it wasn't outlined in the design spec for this use. If we do use it it'd create an extra white space between the title/queries when not showing. What do you think?"
"2022-11-02 16:56:26.352567+00","is this safe? are we going to have timeouts in stg envs when the network is slow? "
"2022-11-02 16:58:12.225382+00","can we put the url `http://localhost` on a shared constant or function that can automatically now what is the host url, this will help when we start setting up the ci"
"2022-11-02 16:58:53.941355+00","is this correct? "
"2022-11-02 17:00:11.162095+00","same, lets use a constant for host"
"2022-11-02 17:00:34.832053+00","we also dont have he port here as we have it in the previous commit"
"2022-11-02 17:00:53.309901+00","@jonathan-yee I combined the calls with `Promise.all` in a new method `loadAllMeasurementsData()`. In the new method, there is also a logic added that applies to both data stream and physical measurements if the name matches. Can you please confirm if the logic is what we are looking for? The idea is to combine both data streams and physical measurements data as one. Questions: Shall we add another type rather than combining them with physicalMeasurements type? Shall we add another flag to distinguish between data streams and physical measurements? For example: `type: 'physical' | data-stream` So this way, the metrics-card can distinguish between them. "
"2022-11-02 17:01:31.710496+00","💌 "
"2022-11-02 17:18:18.321439+00","I would suggest we stick with the current names for these in order to eliminate the need for migration. the labels match what Ops is expecting, so having the underlying values differ doesn't seem to be an issue to me: ```suggestion Aligner = 'Aligner', HighComplexityCrownOrBridge = 'HighComplexityCrownOrBridge', Denture = 'Denture', Implant = 'Implant', Other = 'Other', PartialDenture = 'PartialDenture', Removable = 'Removable', SimpleCrownOrBridge = 'SimpleCrownOrBridge', Sleep = 'Sleep', ImplantSurgery = 'ImplantSurgery' ```"
"2022-11-02 17:19:29.235076+00","Yeah, according to the espec it is."
"2022-11-02 17:27:53.26637+00","Yes, definitely all network requests can be slow or fail sometimes. In this case, the wait is to prevent taking a screenshot when not all icons have been fully loaded."
"2022-11-02 17:28:11.801127+00","I have not looked as to why we would need another method to wrap these two calls, so there may be a need for it. However, the idea I had in mind for this comment was more along the lines of something like this: ```ts const [ metricsData, physicalMeasurements ] = await Promise.all([ this.loadMetricsData(), this.loadPhysicalMeasurements(), ]); const { dataTypeStats, metrics, stationStats, topIssues, totalMetrics } = metricsData; ```"
"2022-11-02 17:29:45.583882+00","This parse int could result in NaN, should we handle this?"
"2022-11-02 17:31:55.256447+00","The measurement name can be an empty string (though I do have a thought that maybe we shouldn't show those on the Metrics page), but an Automeasure monitor cannot (and should not) be created for a measurement with an empty name string. Therefore, it should never be the case that an Automeasure monitor should come back with an empty string for a name."
"2022-11-02 17:38:23.964797+00","Yeah this is definitely noise. I don't have an opinion about how to handle this."
"2022-11-02 17:39:54.638901+00","Yes, only necessary to run on the client."
"2022-11-03 11:59:18.7783+00","Good callout! For this PR I think it's fine to be dynamic (check if we need to do any work within `cleanup`). Once we have https://github.com/sourcegraph/customer/issues/1427 implemented, then the presence of the env var can be used as an indicator/toggle. WDYT?"
"2022-11-02 17:37:26.654803+00","I think you're right that checking the URL here isn't necessary if Abort Errors are handled earlier up the stack. "
"2022-11-02 17:45:52.324048+00","@jonathan-yee I combined the calls to apply the logic to filter out the measurements with the same name. This is not what we are looking for? "
"2022-11-02 17:47:03.950944+00","Sounds good. I change it to return a string."
"2022-11-02 17:47:12.624275+00","Good catch. Thanks."
"2022-11-02 17:48:22.923227+00","This wrapping method is to get this logic. ""if physical measurements and Data streams metrics have the same name, pick the one with more measurements "" Perhaps, we were looking for more simplified ways to apply this?"
"2022-11-02 17:49:51.71658+00","🤔 , I don't believe this can add any value to the test, because the user is created every time and the default value for `totalPaidReports` is `0`. If for some reason the initial `totalPaidReports` is not `0` then the rest of the tests would fail because we are checking whitehat level in an incremental fashion."
"2022-11-02 21:22:00.671896+00","Just a heads up that this endpoint could fail since the `createExchangeRate` function could throw an error. The database operations will be reverted since they are running inside an interactive transaction, and the API will respond with a 500 error."
"2022-11-02 17:53:30.400325+00","I want this function `buildImplantPartsCaseNotes()` to be be called by `buildImplantProduct()`, so that it preserves the hierarchical flow: build order => build details based on sku => build details based on item unit."
"2022-11-02 18:01:21.511374+00","`NaN` is a falsey value, so it would fall back to the default value."
"2022-11-02 18:11:50.077225+00","Nice catch."
"2022-11-02 18:12:37.244617+00","Any thoughts on the new implementation @trevorImmunefi? ``` Number.parseInt(process.env.WHITEHAT_LEADERBOARD_RESULTS_PER_PAGE ?? """", 10) || 20; ```"
"2022-11-02 18:13:07.171149+00","e20636e"
"2022-11-02 19:18:42.573398+00","I see. Since we want to get the last index of something, and `findLast` doesn't seem to be available in the version of Node that we're using, I went with `reverse()` followed by `find` to get the last, presumably most recently selected material thickness value."
"2022-11-02 19:21:20.195551+00","what does 2618 means? "
"2022-11-02 18:14:12.636132+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion TIMESTAMPDIFF(SECONDS, created_at, last_done_at) >= 10 AND message_count__in > 0 AND message_count__out = 0 AND first_message__channel = 'chat' AND NOT participants__is_bpo ``` "
"2022-11-02 18:18:12.474097+00","12c764e"
"2022-11-02 18:20:45.336565+00","Ok got it, I will take a look at the logic when I review it again. I'm not sure if it makes sense to add a new type yet or not without looking in detail, but if it is going to be used in multiple places (i.e. the controller and the model), it probably makes sense to do so for better maintainability. As for adding a flag to determine the difference it possible makes sense. Also, in the meantime, I still see a number of code formatting issues while quickly skimming through the code. Keep in mind, it is better to break lines of codes at opening/closing brackets so it makes more sense. For example: The tabbing and line break make it potentially difficult to quickly understand that the method return type is defined as the Promise object and the opening bracket below is opening the method definition. ```ts loadAllMeasurementsData(): Promise<{ allMeasurements: MetricsModel.PhysicalMeasurements, dataTypeStats: Array<APIListMetricsDataTypeStats>, metrics: Array<APIMetricsListMetricData>, stationStats: Array<APIListMetricsStationStats>, totalMetrics: number, topIssues: Array<APIMetricsListTopIssue>, }> { ``` Simply by moving the `Promise` to the same line, it is much easier to quickly understand, I have a method that returns a Promise. The Promise-ed return consists of an object of some fields, and here is the method definition. ```ts loadAllMeasurementsData(): Promise<{ allMeasurements: MetricsModel.PhysicalMeasurements, dataTypeStats: Array<APIListMetricsDataTypeStats>, metrics: Array<APIMetricsListMetricData>, stationStats: Array<APIListMetricsStationStats>, totalMetrics: number, topIssues: Array<APIMetricsListTopIssue>, }> { ``` "
"2022-11-02 22:05:05.525057+00","Yeah, I was skeptical of that so I'm going to just change it [here](https://github.com/sourcegraph/sourcegraph/pull/43816/commits/35886151abd447c1b21181b0da45e782f7c92c58)"
"2022-11-02 18:26:40.201956+00","```suggestion // Rewrite error if it was a local git error (non-fatal) ```"
"2022-11-02 18:29:02.862674+00","I believe you are checking on a specific commit, sorry about that but we kind of messed up with the commit history, the latest version of this function looks like this:  "
"2022-11-02 18:34:17.207331+00","deps sir"
"2022-11-02 18:35:08.563284+00","F"
"2022-11-02 18:36:41.429653+00","fixed"
"2022-11-02 18:39:38.000081+00","we had bug that in order to submit you had to press the button twice. this was due the fact that when an input from orthly/QuickForm was focused, onBlur it was preventing other events to trigger. onMouseUp got triggered before onBlur from input and fixes the issue"
"2022-11-02 18:43:04.130223+00","so any empty string observed in some measurements is potentially a bug then. Here is a screenshot of an example from a manual measurements data.  "
"2022-11-02 22:23:16.589159+00","@coury-clark is there any reason why we mark this as a Maybe type? I mean why is this not like ```graphql incompleteDatapoints: [IncompleteDatapointAlert!]! ```"
"2022-11-02 18:51:37.37528+00","It was a bit hard for me to read the inline parametrized type. To improve readability, I suggest extracting into a named type the parametrized type on `axios.get<T>()`. ```ts type TokenMarketChartRange = { prices: [number, number][]; market_caps: [number, number][]; total_volumes: [number, number][]; }; // ... const response = await client.get<TokenMarketChartRange>(`/coins/${coingeckoId}/market_chart/range`, { params: { vs_currency: ""USD"", from: fromUnixTimestamp, to: toUnixTimestamp, }, }); ```"
"2022-11-02 18:51:47.85157+00","Sorry, I mean specifically changing the `updatedField as MomentInput` to `updatedField!` I know the lint rules don't block the type cast, but the level of risk of a type cast is greater than of a non-null assertion, and I think it better communicates your intent here. You're really trying to go from `MomentInput | null` to `MomentInput`."
"2022-11-02 18:52:40.328046+00","🤦🏻♀️ Good catch, thanks! Fixed it [d9d2c33](https://github.com/sourcegraph/sourcegraph/pull/43766/commits/d9d2c33f5911fbc8a5c29837882db4ca99d09ad6)"
"2022-11-02 18:55:51.579788+00","0298cf9 makes it so that `getOptionsFor` is still a function, instead of a map, but it does use `AllItemMetafields.find(f => f.id === field_id)`, now, as you suggested."
"2022-11-02 18:56:24.870859+00","There might be a chance that `await getCoinPrice({ coingeckoId, from, to });` raises an error. i.e. a network error. If that happens, it seems that we are prepared to handle errors raised from the `getCoinPriceAt`, since we are explicitly throwing an error when the attempts are exhausted. This is not a change request, but I just wanted to point out that additional errors might be thrown on this function. "
"2022-11-02 19:01:48.766257+00","why are these so indented 💀 "
"2022-11-02 22:29:24.530742+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion FROM is_refab_flag WHERE is_refab = FALSE ``` "
"2022-11-02 19:06:13.931939+00","I believe 94c62ec does this."
"2022-11-02 19:06:22.27883+00","rage"
"2022-11-02 19:06:57.147552+00","wait thought you were talking about sqlfluff"
"2022-11-02 19:07:11.336998+00","they're indented bc it looks better that way :("
"2022-11-02 23:12:44.907447+00","Just adding `lang:go` explicitly to these existing test so we can isolate the diagnostics being tested."
"2022-11-02 19:08:52.865973+00","I suggest not making this error name dynamic, because Sentry won't be able to stack them. This might cause them to pass unnoticed. My suggestion would be to pick a fixed error name: ```ts throw new Error(""Unable to get coin price from CoinGecko""); ``` Or even better, create a custom error ```ts class CoinGeckoUnableToGetCoinPriceError extends Error { readonly coingeckoId: string; readonly at: Date; constructor({ coingeckoId, at }: { coingeckoId: string; at: Date }) { super(""Unable to get coin price from CoinGecko""); this.coingeckoId = coingeckoId; this.at = at; } } ``` We could send the custom error properties to Sentry as metadata with [`errorLogger`](https://github.com/immunefi-team/bugs/blob/WHL-limit-results/lib/errorLogger.ts)."
"2022-11-02 19:09:48.997739+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , BOOLOR_AGG(COALESCE(message_details__is_dialpad_missed_call, FALSE)) AS has_dialpad_missed_call , ARRAY_AGG( message_details__dialpad_time_to_connect_in_seconds ) WITHIN GROUP (ORDER BY message_created_at ASC, message_details__direction = 'in' DESC)[0]::numeric AS dialpad_time_to_connect_in_seconds , ARRAY_AGG( message_details__call_duration_minutes ) WITHIN GROUP (ORDER BY message_created_at ASC, message_details__direction = 'out' DESC)[0]::numeric AS call_duration_minutes ``` "
"2022-11-02 19:39:41.982864+00","`--` wouldn't be special cased if there were no allowed arguments for a command."
"2022-11-02 19:09:51.865494+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , is_conversation_created_during_biz_hrs AND ( (has_dialpad_missed_call AND COALESCE(call_duration_minutes, 0)) <= 0.1667 OR ( TIMESTAMPDIFF(SECONDS, created_at, last_done_at) >= 10 AND message_count__in > 0 AND message_count__out = 0 AND NOT participants__is_bpo AND first_message__channel = 'chat' ) ``` "
"2022-11-02 19:11:25.390535+00","."
"2022-11-02 19:11:29.158238+00","."
"2022-11-02 19:18:46.122844+00","74b8b7e"
"2022-11-02 19:24:54.484125+00","Nitpick: Extra line?"
"2022-11-02 19:28:28.010044+00","This is a fixed amount of gas that is required so that multisig+native currency transfer can work. See https://help.gnosis-safe.io/en/articles/5249851-why-can-t-i-transfer-eth-from-a-contract-into-a-safe"
"2022-11-02 19:28:36.723214+00","**Are we planning to store different types of exchange rates?** I'm asking this because the `Simple` prefix on this table took my attention. If not, maybe it's worth renaming the table name to `ExchangeRate` or `TokenExchangeRate`?"
"2022-11-02 19:36:15.374283+00","- Is a `PaymentReceiptToken` instance valid without a `SimpleExchangeRate`? - Do we have plans to associate the `SimpleExchangeRate` to other tables? If both answers are no, maybe we would like to reconsider the schema, storing the `SimpleExchangeRate` data in the `SimpleExchangeRate` table. "
"2022-11-02 19:38:29.644232+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , is_conversation_created_during_biz_hrs AND ( (has_dialpad_missed_call AND COALESCE(call_duration_minutes, 0) <= 0.1667) OR ( TIMESTAMPDIFF(SECONDS, created_at, last_done_at) >= 10 AND message_count__in > 0 AND message_count__out = 0 AND NOT participants__is_bpo AND first_message__channel = 'chat' ) ``` "
"2022-11-02 19:40:47.126516+00","Just a heads up that this migration will fail if the `PaymentReceiptToken` table is not empty."
"2022-11-03 12:01:27.067201+00","It's unused?"
"2022-11-02 20:01:42.130762+00","I suggest not making this error name dynamic, because Sentry won't be able to stack them. This might cause them to pass unnoticed. My suggestion would be to pick a fixed error name or even better, create a custom error. If you choose to create a custom error, it makes it easier to send metadata to Sentry with [`errorLogger`](https://github.com/immunefi-team/bugs/blob/WHL-limit-results/lib/errorLogger.ts). "
"2022-11-02 20:06:56.622488+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , IFF( account_history_account_id IS NULL , 1 , ROW_NUMBER() OVER ( PARTITION BY account_history_account_id ORDER BY account_history.created_at) ) AS assignment_number , LEAD( account_history.created_at, 1 ) OVER ( PARTITION BY account_history_account_id ORDER BY account_history.created_at) AS next_pod_change_date ``` "
"2022-11-02 20:07:56.108175+00","```suggestion if (this.focusListener !== undefined) { ```"
"2022-11-02 20:15:38.877384+00","changed it :)"
"2022-11-02 20:15:43.326789+00","yes"
"2022-11-02 20:40:37.555483+00","eek. can we use `manufacturer_sla.manufacturer_committed_ship_date` instead? ""ship by date"" is a poorly named field that really means ""estimated ship date"". mfg committed ship date, on the other hand, is what we hold labs to. at the point of integration, they should be the same (unless the lab has requested delay prior to integration, if that's even possible), but I think it would be best for the sake of future developers to be distinctly clear here on what date we're using. just a recommendation."
"2022-11-02 20:49:43.030128+00","Ok"
"2022-11-02 21:08:16.799286+00","I don't _think_ we'll use this anywhere else. The point of this dim_cx_user table is to take the place of any base user tables."
"2022-11-02 21:08:53.881985+00","Yes"
"2022-11-02 21:22:47.892928+00","If it's not in the design let's skip it for now. "
"2022-11-02 21:24:32.34875+00","done"
"2022-11-02 21:24:54.980629+00","Added some comments"
"2022-11-02 21:24:58.145288+00","Shouldn't this condition be the other way around? Show title on sourcegraph.com and show interactive tips on enterprise instances?"
"2022-11-02 21:29:48.840091+00","Yes! My bad, left over from dev-ing. Fixed now :)"
"2022-11-02 21:40:08.442492+00","```suggestion for { ```"
"2022-11-02 21:40:08.595391+00","this is a float I can never remember if this is going to be an issue or not."
"2022-11-02 22:05:37.98911+00","Linter yelled at me too, should be fixed "
"2022-11-02 22:13:53.386756+00","after talking to stakeholder, I linked as of date to training completed date (which is what they need to track conversion)"
"2022-11-02 22:20:22.305416+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion SELECT * FROM {{ ref('lead_source_mapping') }} ``` "
"2022-11-02 22:20:22.328003+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion ) ``` "
"2022-11-02 22:20:22.461697+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion LEFT OUTER JOIN lead_mapping ON opportunity.lead_source = lead_mapping.lead_source ``` "
"2022-11-02 22:20:22.509314+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion UNION ``` "
"2022-11-02 22:20:23.281274+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion LEFT OUTER JOIN opportunity_stages ON opportunity.opportunity_id = opportunity_stages.opportunity_id ``` "
"2022-11-02 22:20:23.391281+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion SELECT * FROM {{ ref('stg_salesforce__opportunity_history_xf') }} ``` "
"2022-11-02 22:20:25.289587+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion (SELECT DISTINCT o.stage_name , os.sort_order FROM {{ source('salesforce', 'opportunity') }} AS o INNER JOIN {{ source('salesforce', 'opportunity_stage') }} AS os ON os.api_name = o.stage_name WHERE coalesce(os.is_active, false) != false AND coalesce(o.is_deleted, false) = false AND coalesce(os._fivetran_deleted, false) != true ORDER BY os.sort_order ASC) ``` "
"2022-11-02 22:35:09.932477+00","This munging also has the side effect of setting milliseconds to zero like the previous code did."
"2022-11-02 22:36:45.087764+00","Correct. This is not hit an API endpoint from automated tests, but better than nothing. I would like to explore soon a library called [**nock**](https://github.com/nock/nock) that allows mocking HTTP interactions."
"2022-11-02 22:42:18.280747+00","I'm following the single expectation per test style, where each test should make only one assertion. Maintaining one expectation per test helps you on finding possible errors, allowing you to go directly to the failing test, and make the code more readable. Multiple expectations in the same test are a signal that you may be specifying multiple behaviors. Source: https://www.betterspecs.org/#single"
"2022-11-02 22:45:53.744367+00","Each `describe` statement is isolating a precondition: - A report with a null PoC - A report with a blank PoC - A report with a PoC So, each describe section can be extended with more expectations if needed."
"2022-11-02 22:47:32.776116+00","Could you provide an example of how to achieve your suggestion?"
"2022-11-03 12:02:06.557233+00","It's duplicated in line 23"
"2022-11-02 22:55:28.911769+00","is this the amount in cents? could add a comment to clarify if so"
"2022-11-03 00:11:04.450385+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , COALESCE( COUNT( DISTINCT IFF(status = 'added', filename, NULL) ), 0 ) AS count_distinct_files_added ``` "
"2022-11-03 02:33:32.637315+00","see if you can replace all the string formatting/parsing objects with [object parsing](https://momentjs.com/docs/#/parsing/object/) and [dumping](https://momentjs.com/docs/#/displaying/as-object/). this code is run on every single event reduction of every single lab order on every single new lab order event dispatch. it's in a very very hot path of code, and the additional string parsing/exporting is likely eerily expensive (I once profiled a reduction and was disturbed by how much time was spent in moment.js). this hopefully won't be an issue once we can use snapshot-as-the-source-of-truth, but we're not there yet and I suspect the object method is both easy and more efficient."
"2022-11-03 02:46:43.852469+00","ty!!"
"2022-11-03 02:54:43.652087+00","Engineering-wise... are we going to do feature branches for each project from now on? And in the feature step, all PRs would be merged to the feature branch, and in the release step that feature branch gets merged into staging and then production?"
"2022-11-03 02:54:43.719249+00","Is there going to be a different way, or are we abolishing the practice completely when it comes to sprint planning?"
"2022-11-03 03:21:17.447726+00","To make it clear from the variable name, the difference from `isOpen`. ```suggestion const isOpenDebounced = useDebounce(isOpen, 100) ```"
"2022-11-03 03:21:17.697743+00","At first glance, this name might be confusing. I assumed this enum includes potential reasons for opening a tooltip, but it has also reasons for closing it. Maybe `TooltipVisibilityChangeReason` or `TooltipOpenChangeReason` would be more aligned with the implementation."
"2022-11-03 03:21:17.986901+00","```suggestion ```"
"2022-11-03 03:54:59.015103+00","from what I can tell, attributes get truncated quite short in Chronosphere. I wouldn't even bother with this."
"2022-11-03 03:59:42.195678+00","I'm kinda reaching the point where I'd rather see the trace context injected in the proxy to info/debug/error, etc, rather than in the constructor. having to `new OrthlyLogger` all over the place is not ideal to look at, to share as best practice, etc."
"2022-11-03 04:01:34.389793+00","We actually control the truncation behavior using this [environment variable](https://github.com/orthly/flux/blob/88d34f64506845e6edf1e03f0702f7c540a29377/apps/staging/web-general/patch-env-labs-server.yaml#L26-L27) (currently limited to 200 chars). I like to include span attributes wherever practical because it allows us to perform structured searches against traces (e.g. in Chronosphere Trace Explorer we can search for `event.data.is_training_order = false AND span.duration > 1 sec`). "
"2022-11-03 04:09:27.096644+00","I completely agree, I wrote up that work in a new ticket: [EPDPLT-845](https://meetdandy.atlassian.net/browse/EPDPLT-845)."
"2022-11-03 04:22:13.388499+00","nit: this should probably be top-level, before the switch"
"2022-11-03 04:29:00.572482+00","last thing: can we get some whitespace up in this function? 😂 it has become unreadable. blank lines between each ""intent"" would make for massively improved readability."
"2022-11-03 04:38:32.66055+00","ahhh ok, I see what's going on. we flatten anything past the first layer of variables in GQL request logs, that's why I was seeing so much truncation: <img width=""336"" alt=""image"" src=""https://user-images.githubusercontent.com/88063894/199648584-8c8066cc-d809-470b-b402-49e19124c89a.png""> "
"2022-11-03 04:55:25.776332+00","@sheldon-welinga I`m not sure why it gets changed I believe I don't remove this part. "
"2022-11-03 04:55:46.113414+00","@sheldon-welinga same here I`m not sure why it gets changed I believe I don't remove this part. "
"2022-11-03 08:06:35.677414+00","`type` here is an atom, (avoid using `any` type) with the following possible values `[:spec, :code, :review, :qa, :learning, :challenge, :admin, :retool, :external]` You can create a type spec in the Task mode as follows: `@type task_type :: :spec, | :code, | :review| :qa | :learning | :challenge | :admin | :retool | :external` then reference it here as `Task.task_type()`"
"2022-11-03 04:56:18.876041+00","@sheldon-welinga same here I`m not sure why it gets changed I believe I don't remove this part. "
"2022-11-02 05:10:21.83457+00","."
"2022-11-03 05:31:58.560742+00","I would prefer if we write the list typespecs like this: ```suggestion @spec list_blockers :: [Blocker.t()] ```"
"2022-11-03 05:32:00.444014+00","We should also add that the function can't return: ```suggestion @spec get_blocker!(pos_integer()) :: Blocker.t() | no_return() ```"
"2022-11-03 05:37:37.587126+00","According to the rest of the doc, **the growth team** handovers the responsibility to derive lessons from users and find out how they perform. It adds a lot more responsibility to the growth team rather than just spreading the word and marketing. Any idea how it would be to iterate on projects depending on the insights from the growth team? Another project?"
"2022-11-03 08:06:35.761516+00","Why explicitly define their path here? Import the if required and use something like `Task.t() or User.t()` here"
"2022-11-03 12:02:26.409078+00","Sounds good, can you leave a TODO referencing that issue here?"
"2022-11-03 06:00:54.653454+00","I know but we need this coz in the aggregate query if we mention to limitation we have call it with some number value. here I have this query in controller. ``` const uniqueNameKyc = await KycIdentity.aggregate([ { $match: conditions, }, { $group: { _id: uniqueNames ? { userId: '$userId', principalName: '$principalName' } : '$_id', userId: { $first: '$userId' }, status: { $first: '$status' }, group: { $first: '$group' }, docType: { $first: '$docType' }, kycStatus: { $first: '$kycStatus' }, expiryDate: { $first: '$expiryDate' }, submittedAt: { $first: '$submittedAt' }, }, }, { $skip: skipPage, }, { $limit: limit, }, { $sort: sorted, }, ]); ```"
"2022-11-03 06:39:40.708149+00","```suggestion const eventTypesWithoutHiddenProperty = eventTypes?.filter((evt) => !evt.hidden); ```"
"2022-11-03 06:39:40.595055+00","Any reason for naming this array variable `eventTypesWithoutHidden`?"
"2022-11-03 06:45:45.60046+00","@gGh00sTt I suggested `publicEventTypes` because events that are not hidden are public events. Please rename the variable name to `publicEventTypes` cc: @anjola-adeuyi "
"2022-11-03 07:22:00.502509+00","@frankMagoba I think doing `return response.data || null` will be better."
"2022-11-03 07:22:00.710283+00","Same here also, `response.data || null`"
"2022-11-03 07:22:40.369623+00","Please let’s do the same for the remaining other file changes also."
"2022-11-03 07:27:59.59822+00","uh"
"2022-11-03 07:27:59.630717+00","I think some of this can be done more simply I was planning on doing some refactoring to this function anyways so I may handle this"
"2022-11-03 07:27:59.683424+00","can we use `undefined` instead of unset to not set any property?"
"2022-11-03 07:35:43.246472+00","your postgres skills are unmatched. Casually thinking to add this clause in is very nice."
"2022-11-03 07:41:54.242525+00","This was the initial approach but @ishmam-mahmud suggested against it. Moreover we use `list(type)` across the code base for type spec. For consistency I suggest we keep with it. "
"2022-11-03 07:45:53.069856+00","For consistency ```suggestion @spec list_clients :: list(Client.t()) ```"
"2022-11-03 07:56:40.810879+00","```suggestion return sqlf.Sprintf(""(%s)"", sqlf.Join(conditions, ""\nOR\n"")) ``` nit"
"2022-11-03 08:06:32.949777+00","Let's use this for consistency ```suggestion @spec list_tasks :: list(Task.t()) ```"
"2022-11-03 08:06:33.213841+00","```suggestion @spec get_task(pos_integer()) :: Task.t() | nil ```"
"2022-11-03 08:06:33.35914+00","Same here"
"2022-11-03 08:06:33.682273+00","```suggestion @spec filter_tasks_list(map()) :: list(Task.t()) ```"
"2022-11-03 08:06:33.953083+00","Same here"
"2022-11-03 08:06:33.965408+00","```suggestion @spec update_statuses_many(Ecto.Multi.t(), list({Task.t(), map()})) :: Ecto.Multi.t() ```"
"2022-11-03 08:06:34.710132+00","Can we restrict `status` to the following atom type following the earlier example `available, backlog, parked, in_progress, client_review, internal_review, needs_changes, finished, cancelled, errored`"
"2022-11-03 08:08:09.838312+00","we probably will have a ""strongly suggested"" to rescope and reevaluate whenever possible. but no strict sprint planning meetings "
"2022-11-03 08:16:53.600583+00","I like this nit 😁 addressed in https://github.com/sourcegraph/sourcegraph/pull/43645/commits/158dd474600dc99e2aecc9a92b3a2c454b1126b2"
"2022-11-03 08:18:37.709503+00","That's one for @macocha and for the engineering team to figure out. It's not something we would prescribe at product framework level. "
"2022-11-03 08:24:36.923997+00","""Step owner"" means the owner for this step, the owner of marketing? Perhaps define step owner earlier in the doc, along with other roles expected to have in a typical project (e.g. a project for delivering a feature). "
"2022-11-03 08:35:18.746269+00","Use same message as enum ```suggestion throw new NotFoundError(ErrorEnums.ENVELOPE_DOCUMENT_NOT_FOUND, 'Envelope document not found'); } ```"
"2022-11-03 08:35:18.88302+00","Revert this file as we don;t have any changes"
"2022-11-03 08:35:19.002472+00","We should only check if no permission as manage access means you can also read"
"2022-11-03 08:35:19.641082+00","Should be ```suggestion static async getEnvelopeDocumentVersionsByDocumentId(documentId) { ```"
"2022-11-03 08:35:20.002493+00","Avoid keyword successfully ```suggestion it('should return envelope document versions', async () => { ```"
"2022-11-03 08:35:20.100177+00","Add envelopeId as well in find query"
"2022-11-03 08:35:20.937321+00","check the sorting, should be A-Z"
"2022-11-03 08:35:21.832505+00","Revert"
"2022-11-03 08:35:21.427118+00","use `envelopeDocumentVersions`"
"2022-11-03 08:35:21.855205+00","```suggestion const { ObjectId } = require('mongoose').Types; ```"
"2022-11-03 08:35:22.64787+00","Check the message, should match enum"
"2022-11-03 08:35:22.751798+00","You should use the path ```suggestion describe('GET /envelopes/:envelopeId/documents/:documentId/versions', () => { ```"
"2022-11-03 08:35:23.010093+00","Any reason for change in this file?, we can revert it"
"2022-11-03 08:35:23.634345+00","use async operations, we don't need `done` in the tests. Check previous tests in this file"
"2022-11-03 08:35:25.430733+00","Revert this file"
"2022-11-03 08:36:28.539928+00","This table explains each step very well, I would say including this in the slides might have helped yesterday's presentation a lot. In terms of organizing this doc, putting this table after the diagram might be better, especially for others who did not join the presentation. "
"2022-11-03 08:41:13.517459+00","@Mjanuary same here use import order"
"2022-11-03 08:41:12.868546+00","@Mjanuary what if there is no envelopeActivities returned? can you please return something"
"2022-11-03 08:41:13.035712+00","@Mjanuary can we use it here instead in controller ```suggestion check('withProfile').optional().isBoolean().default(false), ```"
"2022-11-03 08:41:13.232872+00","@Mjanuary once you finish your changes plz remember to change this line ```suggestion const Database = require('@bluemeg/database').default; ```"
"2022-11-03 08:41:13.738052+00","@Mjanuary order imports by Ascending order as client suggested"
"2022-11-03 08:41:13.913268+00","@Mjanuary same here order import"
"2022-11-03 08:41:14.00495+00","@Mjanuary same here"
"2022-11-03 08:41:14.758324+00","@Mjanuary same here"
"2022-11-03 08:41:16.97247+00","@Mjanuary follow the order ASC"
"2022-11-03 09:00:14.257151+00","Move this functionality to envelopeController If you need to know which controller to use check the route i.e. `/envelopes/***`"
"2022-11-03 09:01:23.422927+00","error: `spec for undefined function update_ticket/1` the function spec should accept 2 parameters, not 1 `@spec update_ticket(Ticket.t(), map()) :: {:ok, Ticket.t()} | {:error, Ecto.Changeset.t()}` is more correct"
"2022-11-03 09:06:29.096825+00","It was inside EnvelopeController but @Chiazokam suggested to move it into a separate controller file"
"2022-11-03 12:05:51.392098+00","Why not run this in `worker` like a job? That way you can allowlist/denylist it via env vars."
"2022-11-03 09:15:01.233037+00","I _think_ you could just use `_tokens` to find the first pattern, i.e. you don't necessarily have to add `patterns` below, but I don't have strong feelings about this."
"2022-11-03 09:54:07.281993+00","Realised what's going on - it _does_ log if the insert fails, but that type of logging isn't printed to screen during unit test runs (at least in the context I was running the tests). https://github.com/sourcegraph/sourcegraph/blob/will/auditlog/security-events/access-token-deleted/internal/database/security_event_logs.go#L144"
"2022-11-03 09:55:07.462553+00","Not sure if there's another approach here rather than typecasting to the same type as the one in the function definition"
"2022-11-03 10:26:35.23551+00","Why are we deleting this?"
"2022-11-03 10:28:20.372677+00","As you can see it's duplicated from line 23"
"2022-11-03 10:28:48.915257+00","I chose to add it to this PR for simplicity, rather than create a new PR"
"2022-11-03 10:36:23.962192+00","@sheldon-welinga Done!"
"2022-11-03 10:40:41.239501+00","```suggestion viewerSubject: SettingsSubject ``` Let's import `SettingsSubject` from `@sourcegraph/shared/src/settings/settings` WDYT?"
"2022-11-03 10:49:18.198167+00","Same here"
"2022-11-03 10:49:18.469847+00","Is this supposed to be a string?"
"2022-11-03 12:06:08.203553+00","But If i change it now, I won't be able to test because this [PR](https://github.com/GitStartHQ/client-bluemeg-console-api/pull/14#:~:text=PR%20for%20Database%20Service) is not yet merged"
"2022-11-03 12:06:37.416953+00","You could add it to these jobs and get all the goodies that come with it: https://github.com/sourcegraph/sourcegraph/blob/29e831e7c6220c46e42afb60ca014f20e7688bca/enterprise/cmd/worker/main.go#L43-L71 And we're also thinking about building a dashboard for these kind of workers"
"2022-11-03 10:57:54.513007+00","If any SQL guru has a better query, please suggest it!"
"2022-11-03 11:07:55.355238+00","Okay"
"2022-11-03 11:12:32.106651+00","It's really nice that all of this is properly typed now!"
"2022-11-03 11:12:32.252069+00","What does `EDT` refer to?"
"2022-11-03 11:12:32.828718+00","Why is this necessary now? Maybe add a comment?"
"2022-11-03 11:12:33.351267+00","How does this work if the git integration is uninstalled (as mentioned in your PR description)? Would this file throw when it tires to load? 🤔 "
"2022-11-03 11:32:38.233588+00","Is not this should be like this `this.props.navigation.removeListener(""focus"", this.focusListener);` to remove listener? <img width=""999"" alt=""Screenshot 2022-11-03 at 4 29 07 PM"" src=""https://user-images.githubusercontent.com/69838896/199709766-2ecea261-fe54-4d46-b4c5-4a10b2545052.png""> "
"2022-11-03 12:09:46.112486+00","@anjola-adeuyi , I renamed the variable as `publicEventTypes` as suggested by Nitesh. I thought it made more sense since the variable includes the list of all the events which are public"
"2022-11-03 12:11:38.763806+00","You can keep it just `onNewBlock`. The `: onNewBlock` part is not needed if you're not renaming it."
"2022-11-03 12:11:38.778891+00","You can just do `return this.blockOrder.indexOf(id)` to get the index."
"2022-11-03 12:11:38.835341+00","I'd still put a small bottom margin on the header. Otherwise, the header and the file content look squished together. Something like `0.25rem`. Same for the symbol block header."
"2022-11-03 12:13:27.170987+00","Why `array_agg`? You can just `SELECT id` and then `basestore.ScanInts`, right?"
"2022-11-03 12:13:29.066981+00","I think this query can be heavily simplified, no? Instead of having 2 subselects, you can just join the tables? Example: ```sql SELECT users.id FROM users JOIN user_external_accounts ON user_external_accounts.user_id = users.id WHERE user_external_accounts.service_type = 'foobar' AND users.created_at <= (now() - '15 days ago'::interval) GROUP BY users.id HAVING COUNT(*) = 1; ```"
"2022-11-03 12:25:16.669046+00","Would you prefer we use a table element and refactor the function to maintain the proper interaction? @jonboiser "
"2022-11-03 12:33:07.383504+00","Ignore"
"2022-11-03 12:34:41.588949+00","Trials by fire 🔥 "
"2022-11-03 13:37:04.864557+00","Thanks for the review "
"2022-11-03 13:39:43.549419+00",">You can just `SELECT id` and then `basestore.ScanInts`, right? I can, but why is it better? 🤔 "
"2022-11-03 13:41:19.122501+00","will send it now and let you refine in your follow-up"
"2022-11-03 14:10:28.962495+00","We also need a `max` agg on `inspections.timestamp` to populate `lastSeen`. Also, I added a note to WEB-2210 that we will have to add the `isWithinLimits` property to `bodyAsImageFeature` like we have for external measurements. Once we have that, we can add an agg to count `failingMeasurements` like `failing: { term: { 'inspections.measurements.bodyAsImageFeature.isWithinLimits': false } }`"
"2022-11-03 13:47:41.469033+00","I think the semantics changed with your example, it gives false positives when the user has one external account with `'foobar'` but also has external accounts other than `'foobar'`. 🤔 We want to only list users IFF the user has a single external account with the `service_type = ""sourcegraph-operator""` currently with these subselects."
"2022-11-03 14:00:33.104914+00","@bobheadxi I know this was solved before in https://github.com/sourcegraph/sourcegraph/pull/41957/files, but I dont know how to make it work here"
"2022-11-03 14:10:25.985443+00","```suggestion exclude: ['Measurement Sandbox', ''], size: 10_000, ```"
"2022-11-03 14:10:26.735497+00","1. Use `filter` instead of `must`. (I added a slide to the training deck about this.) 2. Not all ImageFeatureMeasurements are physical measurements that can be displayed on the Metrics page, so we need to add a `terms` filter on `inspections.measurements.bodyAsImageFeature.featureType`. (This can replace the `exists` filter since `inspections.measurements.bodyAsImageFeature` must exist in order for its `featureType` to match.) - The supported types are currently: `DISTANCE`, `ANGLE`, `DIAMETER`, `PERPENDICULAR`. (Only `PERPENDICULAR` currently supports Auto Measure, but we can still display metric cards for the other types.) - `POLYGON` and `CONCENTRICITY` are both physical measurement types we will probably support one day, but we don't have a UI for drawing/displaying them yet. - `RECTANGLE`, `CIRCLE`, and `SCRIBBLE` are drawings on top of photos, not physical measurements, like the red & blue drawings that make up this lil guy someone drew in the Rylo Playground project. "
"2022-11-03 14:10:28.992191+00","```suggestion const hasLimit = manualMeasurements.find((manual) => { // TODO: Change data type to physical measurement once the backend supports that return manual.measurementName === limit.measurementName && getLimitsMeasurementType(limit) === APIListMetricsDataType.NUMBER; }); if (hasLimit) { hasLimit.limits = limit; } ```"
"2022-11-03 14:10:26.767008+00","```suggestion const hasAuto = manualMeasurements.find((manual) => { return manual.measurementName === monitor.name && manual.measurementType === monitor.measurementType; }); if (hasAuto) { hasAuto.monitor = monitor; } ``` In addition to these changes, this requirement in the story description seems to be missed: > Auto measure monitors with no measurements should still be displayed or at least, AMMs with no measurements are not currently returned from this function."
"2022-11-03 14:10:27.325332+00","Should we just pass `metricFilters` directly to make things easier if/when we add more filters in the future?"
"2022-11-03 14:10:28.037534+00","You can save a whole level of indentation throughout this function if you write this as: ```suggestion const response = await Promise.all([ this.loadMetricsData(), this.loadPhysicalMeasurements(), ]); ```"
"2022-11-03 14:10:28.232477+00","`allMeasurements` has the type `PhysicalMeasurements` but it does not contain just physical measurements. It seems like the `metrics` property should have the value `allMeasurements` and the `physicalMeasurements` (or some mapping of them) should be added to the return object in place of `allMeasurements`."
"2022-11-03 14:10:28.802696+00","Everything else in this query is also required to get the histogram. Instead of duplicating it all below in a separate query, potentially missing some of the filters etc. and requiring a second ElasticSearch request to be made, we can just add an aggregation here. Also, we need this to be an `extended_stats` agg instead of just `stats` in order to get the standard deviation: ```suggestion meas_stats: { extended_stats: { field: 'inspections.measurements.bodyAsImageFeature.realValue', }, }, histogram: { histogram: { field: 'inspections.measurements.bodyAsImageFeature.realValue', interval: bucketSize, min_doc_count: 0, }, }, ```"
"2022-11-03 14:10:30.474331+00","This should be the same: ```suggestion else { ```"
"2022-11-03 14:10:30.639738+00","`measurementsMap` is not a map so `measurementsMap[nameKey]` will always be `undefined` unless `nameKey` is the name of an array property."
"2022-11-03 14:10:31.954831+00","Shouldn't this be the type? ```suggestion export type PhysicalMeasurementData = APIMetricsListMetricData & { stationNames: Array<string>, measurementType: SearchMeasurementImageFeatureType, monitor?: APIAutomeasureMonitor, stats: RelationshipsModel.MeasurementStats, }; ``` Also, I don't think it applies here, but if you need all properties in a type to be optional, just wrap it in `Partial<>` e.g. `Partial<{ a: 'type' }>` is the same as `{ a?: 'type' }`."
"2022-11-03 14:10:31.967995+00","For future reference, if you are constructing an object and giving it a value whose variable name is the same as the property name, you can simplify: ```suggestion allMeasurements, dataTypeStats, metrics, stationStats, totalMetrics, topIssues, ``` But in this case you could instead do something like this: ```suggestion ...response[0], allMeasurements, ```"
"2022-11-03 14:10:31.997608+00","Although we have this pattern in older code, it's preferable to write it like this: ```suggestion error: Utils.errorAnalyticsPayload(error), ``` This helps make it more clear in Amplitude that e.g. the `name` property is in fact the `error.name` and not, say, the name of the current user."
"2022-11-03 14:10:32.755696+00","Why add a separate level of filtering here instead of combining this with the previous measurement-level filters?"
"2022-11-03 14:10:32.950903+00","Why bother declaring this here when it's just going to be overwritten below?"
"2022-11-03 14:10:33.886591+00","```suggestion physicalMeasurements: Array<MetricsModel.PhysicalMeasurementData> = []; ```"
"2022-11-03 14:10:34.958351+00","Isn't `measurementsMap` a `MetricsModel.PhysicalMeasurements`? So, not a Map? Also some awkward indentation going on here. Suggestion: ```suggestion .reduce(( measurementMetrics: MetricsModel.PhysicalMeasurements, { key: typeKey, filtered: { by_measurement_name } }: any ) => { by_measurement_name.buckets.forEach(( { doc_count, key: nameKey, meas_stats, station_names }: any ) => { ```"
"2022-11-03 14:10:35.552079+00","I believe this requirement from the story is being overlooked: > All manual measurements with > 1 measurement will be shown In other words, a metric with no monitor and only one measurement should not be shown."
"2022-11-03 14:10:35.847269+00","```suggestion failingMeasurements: 0, ```"
"2022-11-03 14:21:42.347086+00","@BikashSah999 have we explore the possibility of testing this?"
"2022-11-03 14:10:36.422343+00","```suggestion monitor: undefined, ``` or just omit the property."
"2022-11-03 14:10:38.591847+00","""Measurement Sandbox"" is not a feature type. I think there are a few measurements from the earliest days of the measurement tool ~6 years ago that have it as an intent name. (In fact it's excluded as an intent name below.) So this line can be removed."
"2022-11-03 14:10:39.397013+00","The station name buckets are ordered by frequency so the most-used station name is just `station_names.by_station_name.buckets[0].key`."
"2022-11-03 14:10:39.543417+00","When you disable an eslint rule you also need to re-enable it. Generally it's easier to wrap the whole function body. You can search for `eslint-disable max-len` in the code to find other examples of its usage, but basically it'll look like this: ```ts function buildSomeESQuery() { /* eslint-disable max-len */ return { size: 0, aggs: { ... }, }; /* eslint-enable max-len */ } ```"
"2022-11-03 14:10:40.617982+00","Simpler? ```suggestion loadAllMeasurementsData(): Promise<APIListMetricsResponse & { allMeasurements: MetricsModel.PhysicalMeasurements, }> { ```"
"2022-11-03 14:12:37.341288+00","Event Dispatch Thread. I've added the resolution of this abbreviation everywhere."
"2022-11-03 14:13:25.058549+00","I've now added reasoning everywhere (about 10 locations) where we do thread switches. Thanks!"
"2022-11-03 15:28:24.235375+00","Let's use `SettingsSubjectCommonFields` here, it's an alias of `Pick<GQL.ISettingsSubject, 'id' | 'viewerCanAdminister'>`"
"2022-11-03 14:20:14.431782+00","Done... @jonboiser please jump in if needed, it's unlikely I will see updates quickly if clarification is needed."
"2022-11-03 14:29:45.834185+00","We need to check that the order has not already been designed or is in fabrication. order.design is not null order.status == 'New' (not in ('Delivered', 'Fabrication', 'NeedsRefabrication', 'Cancelled', 'NeedsReview', 'OnHold', 'Shipped', 'New') And perhaps that the active task has not been started or assigned?  "
"2022-11-03 14:29:46.460611+00","I like that we assign control vs experiment after all other criteria have been checked. For the most like vs like comparison. "
"2022-11-03 14:29:58.572501+00"," "
"2022-11-03 14:36:36.009099+00","Great question! I've tested it, it works; I think the IDE loads optional dependencies dynamically under the hood. However, I was seeing some error messages in the console, so to make it slightly nicer for the user, I've added a proper check for the class existence, and in case of failure, I'm showing a helpful error message now."
"2022-11-03 14:37:41.799847+00","🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️ It is done. 🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️🏳️"
"2022-11-03 15:02:20.77395+00","new functionality here: we are iterating through the executions here and this list is going to grow so this could be very inefficient someday, do we care? this could all be going away very soon "
"2022-11-03 15:03:52.626507+00","Because it's a database and a database client/driver that are built on the concept of returning rows 😄 Why aggregate the rows in a different data structure before returning and scanning them? If you return the rows instead of aggregating, then potentially they can be streamed."
"2022-11-03 15:06:04.492205+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , is_conversation_created_during_biz_hrs AND ( ( has_dialpad_missed_call AND COALESCE(call_duration_minutes, 0) <= 0.1667) OR ( TIMESTAMPDIFF(SECONDS, created_at, last_done_at) >= 10 AND message_count__in > 0 AND message_count__out = 0 AND NOT COALESCE(participants__is_bpo, FALSE) AND first_message__channel = 'chat' ) ``` "
"2022-11-03 15:06:37.207326+00","Naive question, how will these flags propagate to background jobs?"
"2022-11-03 15:08:38.642672+00","Can you try changing this to use the `regex` processor thingamajig: ```suggestion shared.CodeIntelligence.NewAutoindexingSummaryGroup(""${source:regex}""), ``` there's another query that does this so I think the dashboard should work, and I confirmed the replacement works correctly in this case"
"2022-11-03 15:11:06.699436+00","I think you need to give them an `id` so they're not treated as the same node by `useConnection`. ```suggestion id: `webhook-${urn}`, ``` That fixes the list for me."
"2022-11-03 15:12:32.386493+00","Agree that SQL should only be concerned with these things if no other way is available. This will also for example affect the query insights because the returned row count will always be 1 and not the actual count."
"2022-11-03 15:16:09.036063+00","that's absolutely it, thank you! will fix it and then merge the PR. Thanks for your review!"
"2022-11-03 16:48:00.04657+00","I'm pretty sure objects don't ensure order of keys but practically that's usually how it works"
"2022-11-03 15:22:49.699972+00","Look good to you? [sourcegraph/sourcegraph@`be3d6e3` (#43865)](https://github.com/sourcegraph/sourcegraph/pull/43865/commits/be3d6e389fa862be769b43308c053a9422d8cfe5)"
"2022-11-03 15:24:11.08986+00","IMO we can go with `QueryFieldPolicy` ```tsx import { QueryFieldPolicy } from '@sourcegraph/shared/src/graphql-operations' export const QUERIES_TO_PERSIST: (keyof QueryFieldPolicy)[] = [ 'viewerSettings', 'extensionRegistry', 'temporarySettings', ] ```"
"2022-11-03 15:24:11.197526+00","Let's use `SearchPatternType` from `@sourcegraph/search` and `Scalars` from `../graphql-operations` (prefer use types from internal `graphql-operations` of package"
"2022-11-03 15:25:18.656258+00","```suggestion // Target condition: repository is resolvable but the commit is not; was probably ```"
"2022-11-03 15:27:53.643657+00","Fair enough!"
"2022-11-03 15:36:50.418552+00","@AJAkimana please confirm that we still need these castings?"
"2022-11-03 15:31:14.912395+00","`_.omit` isn't type-safe, so if we change this property name in the future this will break. generally a good idea to avoid it ```ts // this still type checks for some reason, no idea why const updateUserCommand = _.omit(createUserCommand, ['whatever']); ``` I'd vote that it's safer to just strictly type the update command: ```suggestion const updateUserCommand: UpdateUserCommand = { user_id, first_name: createUserCommand.first_name, // ... etc } ```"
"2022-11-03 15:32:59.981761+00","has_dialpad_missed_call should stand alone- as long as it's a voice chat, the time does matter, as per jeremy's requested logic.  "
"2022-11-03 15:37:18.712472+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion , is_conversation_created_during_biz_hrs AND ( has_dialpad_missed_call OR ( TIMESTAMPDIFF(SECONDS, created_at, last_done_at) >= 10 AND message_count__in > 0 AND message_count__out = 0 AND NOT COALESCE(participants__is_bpo, FALSE) AND first_message__channel = 'chat' ``` "
"2022-11-03 15:39:10.21985+00","should we be returning the running total here and counting that in the caller?"
"2022-11-03 15:38:06.906171+00","Same here, please remove `eslint-disable-next-line @typescript-eslint/consistent-type-assertions` in case we don't need to cast"
"2022-11-03 15:39:36.058057+00","oops nvm, just discovered the transaction above"
"2022-11-03 15:52:00.022489+00","Done."
"2022-11-03 15:56:10.382485+00","is the `agg.state` updated from the dispatch? the previous code looked at the result of `dispatchEvent`"
"2022-11-03 16:03:49.156878+00","it is - `applyEvent` updates `agg.state`"
"2022-11-03 16:29:19.786194+00","Same here"
"2022-11-03 16:29:56.295121+00","Use same standard as above fields"
"2022-11-03 16:30:56.702481+00","Nuke, applies to any field which is not required"
"2022-11-03 16:32:25.798129+00","@olafurpg Would appreciate your 👀 on this list. This makes all `Identifier` occurrences interactive except for `IdentifierKeyword`, `IdentifierOperator`, `IdentifierNull`."
"2022-11-03 16:35:53.939884+00","why would we not want this to fail if the `gcloud` CLI fails (exits with code != 0)?"
"2022-11-03 16:39:20.641686+00","this `finally` doesn't appear to be doing anything ```suggestion InfraLogger.info(`Updating ${jobName} in ${project}.`); await InfraTaskUtils.runCommand(command.join(' ')); ```"
"2022-11-03 16:39:27.454302+00","we don't want to just break -- the deployment would look like a success and we'd never see this error ```suggestion throw new Error('Something went wrong. Could not find the execution ID.'); ```"
"2022-11-03 16:40:57.378269+00","why not just do ```typescript const logger = new OrthlyLogger('eventsourced:dispatch-event'); ``` at file level (or have `this.logger` as an instance variable)"
"2022-11-03 16:42:11.765694+00","I am confused as to what's happening here. You're setting a function to run every 60 seconds then immediately canceling it, effectively creating a no-op. fyi the reason for the `.` every 60 seconds is to prevent CircleCI from timing out due to no output."
"2022-11-03 16:45:40.641961+00","@johnmastro because the trace & span IDs are injected from async context by the otel library in the `OrthlyLogger` constructor right now. EPDPLT-845 will change that, fortunately."
"2022-11-03 16:45:44.38395+00","lol thank you"
"2022-11-03 16:47:02.331691+00","Did you mean to remove the property `required: false,`?"
"2022-11-03 16:48:20.618764+00","you can actually access private functions in tests if you use the following form: `OrderProductLineCalculator['getCrownItemProductLine'](...)`"
"2022-11-03 16:48:28.111052+00","i even googled it... losing my touch"
"2022-11-03 16:49:10.06593+00","oh no way... TIL"
"2022-11-03 16:50:07.899001+00","i have a test on it, based on [this](https://dev.to/frehner/the-order-of-js-object-keys-458d) it does. we do this in the task sequences code as well"
"2022-11-03 16:57:59.134965+00","Update docstring: `Alert Delay` -> `Bucket Count`"
"2022-11-03 16:58:01.3625+00","Update docstring: `Alert Delay` -> `Bucket Count`"
"2022-11-03 17:06:27.360608+00","considering this is an externally controlled entity, please only log the fields you care about -- this payload could be ridiculously large, or could leak data that shouldn't be in logs."
"2022-11-03 17:07:03.639305+00","Should we label doctorId so we know what the guid is? Like: `Not sending sms to doctorid: ${doctor.id} ....`?"
"2022-11-03 17:06:27.366619+00","don't include unique IDs in the message itself - that's what the extra payload is for. it's easier to locate & easier to aggregate log searches when the message is consistent."
"2022-11-03 17:08:14.482476+00","can we separate out logs for doctors that don't have configs set vs. where sms is false or something? "
"2022-11-03 16:57:59.227676+00","I don't think we check in changes to this file - looks like it gets handled by dependabot? (not 100% sure how it works :))"
"2022-11-03 18:05:49.376196+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion WHERE new_session = 1 ``` "
"2022-11-03 17:11:44.713818+00","@unknwon @bobheadxi @ryanslade Tagging y’all as you randomly appear in git blame for the file 😅 - do y’all think it is safe to construct the `actor.Actor` here? Normally, OAuth code executes _before_ the next middleware puts the actor into the context (in fact, it’ll overwrite this one). I needed it here so that actor information appears in the audit log, but if you think it’s too risky or messes up with something, we can drop it and infer the data from the `SecurityEvent` if needed."
"2022-11-03 17:12:16.602483+00","Note that we don't want the entire URL as it contains sensitive OAuth query parameters "
"2022-11-03 17:16:18.295845+00","Let's also make sure to add test cases in `project-settings.test.ts` that use these helpers! (see 'Update alert delay' and 'Update alert delay invalid' test cases)"
"2022-11-03 17:22:58.545446+00","I think we should call this `ProjectSettingsAlertBucketCountField` for consistency with other Alert-related fields."
"2022-11-03 17:30:20.801575+00","If you're worried about this influencing downstream code then you can create a temporary context, e.g. ```suggestion logCtx := actor.WithActor(ctx, actr) ``` And use `logCtx` in the subsequent call"
"2022-11-03 17:31:08.642479+00","I think as-is this is fine however"
"2022-11-03 17:38:45.311041+00","This line is what's causing the failing unit tests. We now return a 500 if we don't find a handler for the code host kind/event type. I changed this for ease of testing/debugging since it made it easier to see which handlers were/were not initialized. I'd like some feedback on whether we should return a 200 (even if we don't find a handler and do nothing with the webhook) or return an error. If we decide this is the correct approach I'll fix the tests."
"2022-11-03 17:44:48.872992+00","To achieve the ""faded gray"" look on the icons, let's use a CSS filter instead. This gets something close to the result you want, but you might need to change the `opacity` to get it exact ```suggestion margin-right: 5px; filter: grayscale(100%) opacity(0.7); ```"
"2022-11-03 17:56:14.733636+00","We shouldn't be hitting retainer at all here, since these are just the CloudRun job worker containers. So the intended consequence is for it to fail if for whatever reason this container was exposed to the web."
"2022-11-03 17:44:48.954624+00","You can delete this as well as the new CSS classes `svg-fill-missing-value`, `svg-stroke-missing-value`, and the new `$color-missing-value` variable, if you use the CSS suggestion above. ```suggestion ```"
"2022-11-03 17:44:49.005803+00","```suggestion measurementUnit = featureType === APIImageFeatureMeasurementType.ANGLE ? '°' : 'mm'; ```"
"2022-11-03 17:44:49.832671+00","Prefer use of the `APIImageFeatureMeasurementType` enum over the string literal ```suggestion let measurementIcon = featureType === APIImageFeatureMeasurementType.RECTANGLE ```"
"2022-11-03 17:44:49.95413+00","I think this needs to be called again if the user provides a name to the measurement. Currently, the measurement's name remains ""Measurement Sandbox"" even after I save a name."
"2022-11-03 17:51:50.267583+00","are you sure this will work? retainer uses private/public keys. I feel like you're likely to have a key decoding error with this."
"2022-11-03 17:53:49.482334+00","Nitpick: Imho these comments (old and new) don't add a whole lot of value so we could simply drop them if you agree. Applies to line 60 as well."
"2022-11-03 17:53:49.480591+00","Nitpick: I'd suggest just copying the same description we used on a Metric's search handler, i.e. > Handler for updating the page when search (unit) filters have been updated."
"2022-11-03 17:53:51.136033+00","Nitpick: I'd suggest using the same handler name we used on Metric's, i.e. `searchUpdatedHandler`"
"2022-11-03 18:05:49.398171+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion AND bizible_session.ip_address = fcpid.context_ip AND COALESCE(bizible_session.referrer_page, 'NA') = COALESCE(fcpid.context_page_referrer, 'NA') AND COALESCE(bizible_session.landing_page_raw, 'NA') = COALESCE(fcpid.context_page_url, 'NA') AND bizible_session.event_date BETWEEN DATEADD( 'second', -60, fcpid.timestamp ) AND DATEADD('second', 60, fcpid.timestamp) ``` "
"2022-11-03 18:05:50.234144+00","**[sqlfluff-fix]** <sub>reported by [reviewdog](https://github.com/reviewdog/reviewdog) :dog:</sub><br> ```suggestion SELECT id , fc_pid , user_id , anonymous_id , timestamp , context_library_name , context_library_version , context_locale , context_ip , context_page_title , context_page_referrer , context_page_search , context_page_url , context_page_path , context_campaign_name , context_campaign_source , context_campaign_medium , context_campaign_term , context_campaign_content /* session information */ , LAG( timestamp ) OVER ( PARTITION BY context_page_title, context_page_referrer, context_ip, context_page_url ORDER BY timestamp ASC ) AS previous_fcpid , DATEDIFF('ms', previous_fcpid, timestamp) / 1000 AS inactivity_sec , IFF(inactivity_sec < 60, 0, 1) AS new_session FROM source ``` "
"2022-11-03 18:38:44.552222+00","Isaac's suggestion to exclude empty string from Intent.raw.name should take care of this issue. "
"2022-11-03 18:56:49.516617+00","I thought when I merged in master it got the version from master's copy of package-lock. I'll check on that"
"2022-11-03 19:02:17.205964+00","No, that is not necessary, and I will follow up on this later :+1:"
"2022-11-03 19:03:28.55113+00","This doesn't look right; if you read the comment on line 3727 it says: > If the perpendicular point sits in a place where a should be extended, extend a. Which means in this line what we want to do is to re-define the point `a` to the value of `pp` but instead we're redefining the point `pp` to it's own value? 🤔 "
"2022-11-03 19:03:28.945465+00","This should set the attributes x1/y1 for the line elements at 2 and 3 based on the x/y values of c. Similar to what we're currently doing in pointB."
"2022-11-03 19:03:29.578535+00","Please add the missing trailing comma and fix indentation below."
"2022-11-03 19:03:30.081413+00","This should be something like the following instead: ```ts this.perpendicular.pointB = { xPx: mouseX, yPx: mouseY, zPx: 0 }; ```"
"2022-11-03 19:03:29.594336+00","Same thing as above, but with regards to re-defining the point `b`."
"2022-11-03 19:03:29.704844+00","As initially spec'ed I'd expect all four points (a, b, c, and pp) to have similar signatures; why is that not the case? ```ts set pointA(a: Point); set pointB(b: Point); set pointC(c: Point); set pointPP(pp: Point); ``` This should set the attributes x1/y1 for the line elements at 0 and 1 based on the x/y values of a. Similar to what we're currently doing in `pointB`. "
"2022-11-03 19:03:30.950509+00","Based on one of the comments above this should not be needed."
"2022-11-03 19:03:31.062509+00","This should set the attributes x2/y2 for the line elements at 2 and 3 based on the x/y values of pp. Similar to what we're currently doing in pointB."
"2022-11-03 19:04:25.262479+00","Per Nic's comment, revert this change, so the user's directions are more clear. ```suggestion <h4>Click the thumbnail to select a point</h4> ```"
"2022-11-03 19:05:08.749918+00","so all i did was refactor this out into a function since it was used in a few different scopes and i was going to use it again in a new one. i can break it back out if you'd like "
"2022-11-03 19:11:36.262468+00","Thanks!"
"2022-11-03 19:30:35.343733+00","Yeah, noticed that, I just decided to follow previous conventions"
"2022-11-03 19:31:25.242517+00","We don't"
"2022-11-03 19:51:40.172495+00","👑 "
"2022-11-03 19:52:23.286616+00","I'd really prefer a separate PR for something like this which is completely unrelated"
"2022-11-03 19:58:57.683233+00","I will avoid throwing these in with it in future PRs, sorry bout that"
"2022-11-03 20:25:12.398133+00","considering removing this and just making `handleRepositoryMatcherBatch` a basic function @efritz thoughts"
"2022-11-03 20:25:57.762475+00","No issues on my end."
"2022-11-03 20:33:47.998318+00","I ran a benchmark on this just in case, since I've been surprised by what is / isn't faster on modern hardware before. Turns out you're right, though: the using object parsing & dumping is about twice as fast as the string implementation: <img width=""702"" alt=""Screen Shot 2022-11-03 at 1 31 50 PM"" src=""https://user-images.githubusercontent.com/57967008/199828350-b231f0d0-927b-4e4e-a2a6-391b8013a13f.png""> I'll swap it over to the faster one."
"2022-11-03 23:27:16.929965+00","changing these utility functions to accept `LabOrderDTO` rather than `LabOrderAggregateRoot` wasn't strictly necessary, but i think it makes more sense given that they all just want to look at the dto state"
"2022-11-03 20:34:29.07996+00","Logically, these feel like tabs to me. They should probably be implemented [using the `<Tabs>` component](https://storybook.sgdev.org/?path=/story/wildcard-tabs--tabs-story) so they are accessible. We can style them to not look like tabs if we want. The current implementation is not accessible to keyboard or screen reader users because it's not clear what these toggles, and we're not using interactive components (adding onclick to a `<p>`). Also, I don't think it's a good idea to change the order depending on which one is selected, as this can be confusing, especially to keyboard or screen reader users. cc @almeidapaulooliveira "
"2022-11-03 20:41:07.301331+00","@jonboiser this has been reverted"
"2022-11-03 20:51:28.526242+00","I'm mostly annoyed I have to do either-- iirc the target version of typescript doesn't need the typecast or assertion. Don't have a strong preference either way, so I'll make the swap over."
"2022-11-03 21:37:28.629225+00","Ahh, totally agree. Tabs makes more sense here. Thanks @limitedmage . Back to WIP for now"