Remove JeffNet

The time has come. If we start back in Louisiana, we aren't likely to use JeffNet specifically. If we really
do need, I can ressurect it from the Git history, with whatever changes are needed.

Fix #228.

Author: BryceStevenWilley

TODO.md

@@ -20,7 +20,7 @@ Full auto integration test:
   * from an npm container
     * wait til DA is up
     * add the EFSP server API key (maybe hard coded from the user_transaction.sql) to DA config
-    * install & playground install IL, Jeffnet & EFSPIntegration
+    * install & playground install IL & EFSPIntegration
     * run feature files for all 3 packages
 
 5/16/22:

docs/README.md

@@ -82,8 +82,6 @@ efile proxy:
   api key: abc123 
   # This can stay the same
   url: http://efspjava:9000/
-  # If using JeffNet, you can copy the JeffNet API Key here
-  jeffnet api token: abc123
 ```
 
 ## Running locally without Docker

docs/architecture.md

@@ -37,9 +37,9 @@ Java organizes its code by folders, called packages. It's encouraged to put your
 * `ecfcodes` extends `db`, and contains code related to the `tyler_efm_codes` database (see [tyler_codes.md](tyler_codes.md) for more info).
 * `model` contains internal business representations of objects like Addresses.
 * `server` contains code related to running the HTTP / REST server.
-    * `server.ecf4` contains all of the code used to file into ECF 4 courts. The `jeffnet` subpackage does the same for the Jefferson Parish court in Louisiana.
+    * `server.ecf4` contains all of the code used to file into ECF 4 courts. 
     * `server.services` contains all of the Jakarta API for RESTful Web Services (JAX-RS) code that provides our external facing REST API, and utility files that are JAX-RS and REST specific.
-    * `server.setup` contains specific `jeffnet` vs `tyler` implemetations of common interfaces.
+    * `server.setup` contains specific `tyler` implemetations of common interfaces.
 * `stdlib` contains code that really should be in the standard lib (i.e. no business logic, and only depends on `java`/`javax`/logging classes).
 * `tyler` contains code specific to Tyler Technologies' implementations of ECF 4 and ECF 5.
 * `utils` contains various helper functions and classes.
@@ -72,7 +72,7 @@ There are two distinct databases that we use; both are in Postgres. They are `ty
 It is the more widely used of the databases. There is a Quartz job (setup in `ecf4.TylerModuleSetup.java`) that runs around 2 AM every night, pulling new codes from the courts and updating the databases and their indices. More details about the structures of the codes can be found in [tyler_codes.md](tyler_codes.md).
 
 `user_transactions` is everything else. As of writing, it has 4 tables: `at_rest_keys`, `message_settings`, `schema_version`, and `submitted_filings`.
-* `at_rest_keys` is the authorization database for server API keys. It contains the name and id of the server, whether it has access to tyler and Jeffnet functionalities, and when it was created.
+* `at_rest_keys` is the authorization database for server API keys. It contains the name and id of the server, whether it has access to tyler, and when it was created.
   It also contains a SHA-256 hash of the API key, keeping the real key secure from leaks, and letting us confirm servers' API keys
 * `message_settings` contains default email settings for a particular server. It lets you set the email subject line and template and for the confirmation and accept/reject email.
   NOTE: this db isn't heavily used, likely because there isn't an easy API to access it, and it isn't as flexible as being able to set unique emails for each interview.

docs/config.example

@@ -1,4 +1,3 @@
 efile proxy:
   api key: abc123
-  url: http://efspjava:9000/
-  jeffnet api token: abc123 # if using JeffNet
+  url: http://efspjava:9000/

env.example

@@ -53,13 +53,6 @@ TOGA_CLIENT_KEYS=
 PATH_TO_KEYSTORE=MyOrg.pfx
 X509_PASSWORD=
 
-##### JeffNet related environment variables #####
-# The URL given by JeffNet to send filings
-JEFFERSON_ENDPOINT=https://example.com
-# The API Key that is sent with every request to the above URL.
-# NOTE: this ONLY needs to be in the Docassemble server.
-JEFFERSON_KEY=
-
 ##### Secured Files #####
 # These are secured files that are stored in encrypted cloud storage. Use this for any secured files that are not
 # baked into your Docker image. This is useful in the case of continuous deployment.

proxyserver/src/main/java/edu/suffolk/litlab/efsp/db/LoginDatabase.java

@@ -22,6 +22,8 @@
 public class LoginDatabase extends Database {
   private static Logger log = LoggerFactory.getLogger(LoginDatabase.class);
 
+  // TODO(brycew): jeffnet_enabled is deprecated and no longer used.
+  // At somepoint it can be removed from the database as well.
   private static final String atRestCreate =
       """
       CREATE TABLE at_rest_keys (
@@ -90,7 +92,7 @@ public boolean tablesExist() throws SQLException {
     }
   }
 
-  public String addNewUser(String serverName, boolean tylerEnabled, boolean jeffNetEnabled)
+  public String addNewUser(String serverName, boolean tylerEnabled)
       throws SQLException {
     if (conn == null) {
       log.error("Connection in addNewUser wasn't open yet!");
@@ -105,7 +107,8 @@ public String addNewUser(String serverName, boolean tylerEnabled, boolean jeffNe
       insertSt.setString(2, serverName);
       insertSt.setString(3, hash);
       insertSt.setBoolean(4, tylerEnabled);
-      insertSt.setBoolean(5, jeffNetEnabled);
+      // JeffNet's enabled should always be false in the Database now.
+      insertSt.setBoolean(5, false);
       insertSt.setTimestamp(6, ts);
       insertSt.executeUpdate();
     }
@@ -134,7 +137,8 @@ public Optional<AtRest> getAtRestInfo(String apiKey) {
       }
       AtRest atRest = new AtRest();
       atRest.serverId = (UUID) rs.getObject(1);
-      atRest.enabled = Map.of("tyler", rs.getBoolean(4), "jeffnet", rs.getBoolean(5));
+      // JeffNet is always true, to prevent any clients from breaking.
+      atRest.enabled = Map.of("tyler", rs.getBoolean(4), "jeffnet", true);
       atRest.serverName = rs.getString(2);
       atRest.created = rs.getTimestamp(6);
       // Assuming that we will only have the API key hash when directly given it, i.e.
@@ -178,12 +182,11 @@ public boolean updateServerName(AtRest atRest, String apiKey, String newName) {
    */
   public static void main(final String args[])
       throws SQLException, NumberFormatException, ClassNotFoundException {
-    if (args.length != 3) {
-      System.out.println("Only 3 params: server name, tyler enabled, jeffnet enabled");
+    if (args.length != 2) {
+      System.out.println("Only 2 params: server name, tyler enabled");
     }
     String serverName = args[0].strip();
     String tylerEnabled = args[1].strip();
-    String jeffnetEnabled = args[2].strip();
 
     DataSource ds =
         DatabaseCreator.makeDataSource(
@@ -197,11 +200,10 @@ public static void main(final String args[])
     try (LoginDatabase ld = new LoginDatabase(ds.getConnection())) {
       ld.setAutoCommit(true);
       boolean tylerBool = Boolean.parseBoolean(tylerEnabled);
-      boolean jeffnetBool = Boolean.parseBoolean(jeffnetEnabled);
       ld.createTablesIfAbsent();
-      String newApiKey = ld.addNewUser(serverName, tylerBool, jeffnetBool);
+      String newApiKey = ld.addNewUser(serverName, tylerBool);
       System.out.println("New Api Key for " + serverName + ": " + newApiKey);
-      System.out.println("Using tyler: " + tylerBool + " and using jeffnet: " + jeffnetBool);
+      System.out.println("Using tyler: " + tylerBool + " (not using jeffnet)");
     }
   }
 }

proxyserver/src/main/java/edu/suffolk/litlab/efsp/server/EfspServer.java

@@ -20,7 +20,6 @@
 import edu.suffolk.litlab.efsp.server.services.RootService;
 import edu.suffolk.litlab.efsp.server.setup.EfmModuleSetup;
 import edu.suffolk.litlab.efsp.server.setup.EfmRestCallbackInterface;
-import edu.suffolk.litlab.efsp.server.setup.jeffnet.JeffNetModuleSetup;
 import edu.suffolk.litlab.efsp.server.setup.tyler.TylerModuleSetup;
 import edu.suffolk.litlab.efsp.server.utils.EnumExceptionMapper;
 import edu.suffolk.litlab.efsp.server.utils.JsonExceptionMapper;
@@ -258,10 +257,9 @@ public static void main(String[] args) throws Exception {
               sender)
           .ifPresent(mod -> modules.add(mod));
     }
-    JeffNetModuleSetup.create(converterMap, userDs, sender).ifPresent(mod -> modules.add(mod));
     if (modules.isEmpty()) {
       log.error(
-          "Couldn't load enough parameters to start either the Tyler or JeffNet filer modules."
+          "Couldn't load enough parameters to start any of the Tyler filer modules."
               + "Please check your environment variables and try again.");
       throw new RuntimeException("No filer modules available");
     }

proxyserver/src/main/java/edu/suffolk/litlab/efsp/server/auth/JeffNetLogin.java

@@ -34,7 +34,6 @@ public class SecurityHub {
   private static final Logger log = LoggerFactory.getLogger(SecurityHub.class);
 
   private final List<LoginInterface> tylerLoginObjs;
-  private final LoginInterface jeffNetLoginObj;
   private final Map<String, Function<JsonNode, Optional<Map<String, String>>>> loginFunctions;
   private final Supplier<LoginDatabase> ldSupplier;
 
@@ -56,11 +55,11 @@ public SecurityHub(
               .map(j -> new TylerLogin(new TylerDomain(j, env.get())))
               .collect(Collectors.toList());
     }
-    this.jeffNetLoginObj = new JeffNetLogin();
 
-    this.loginFunctions =
-        Stream.concat(this.tylerLoginObjs.stream(), Stream.of(this.jeffNetLoginObj))
-            .collect(Collectors.toMap(lo -> lo.getLoginName(), lo -> (info) -> lo.login(info)));
+    this.loginFunctions = new HashMap<>();
+    this.loginFunctions.put("jeffnet", info -> Optional.of(Map.of("JEFFNET-TOKEN", "deprecated")));
+    this.loginFunctions.putAll(this.tylerLoginObjs.stream()
+            .collect(Collectors.toMap(lo -> lo.getLoginName(), lo -> (info) -> lo.login(info))));
   }
 
   /**