Skip to content

Commit 781d3b1

Browse files
sumoanemakimsauce
andauthored
Apply suggestions from code review
Co-authored-by: Kim (Sumo Logic) <[email protected]>
1 parent 757ff9f commit 781d3b1

File tree

3 files changed

+10
-20
lines changed

3 files changed

+10
-20
lines changed

docs/send-data/opentelemetry-collector/remote-management/source-templates/elasticsearch/index.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ import useBaseUrl from '@docusaurus/useBaseUrl';
99
import Tabs from '@theme/Tabs';
1010
import TabItem from '@theme/TabItem';
1111

12-
<head>
13-
<meta name="robots" content="noindex" />
14-
</head>
15-
16-
<p><a href="/docs/beta"><span className="beta">Beta</span></a></p>
1712

1813
<img src={useBaseUrl('img/integrations/databases/elasticsearch.png')} alt="Thumbnail icon" width="100"/> <img src={useBaseUrl('img/send-data/otel-color.svg')} alt="Thumbnail icon" width="30"/>
1914

docs/send-data/opentelemetry-collector/remote-management/source-templates/mysql/index.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@ import useBaseUrl from '@docusaurus/useBaseUrl';
99
import Tabs from '@theme/Tabs';
1010
import TabItem from '@theme/TabItem';
1111

12-
<head>
13-
<meta name="robots" content="noindex" />
14-
</head>
15-
16-
<p><a href="/docs/beta"><span className="beta">Beta</span></a></p>
1712

1813
<img src={useBaseUrl('img/integrations/databases/mysql.png')} alt="Thumbnail icon" width="100"/> <img src={useBaseUrl('img/send-data/otel-color.svg')} alt="Thumbnail icon" width="30"/>
1914

docs/send-data/opentelemetry-collector/remote-management/st-with-secrets.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,17 @@ This file is accessible to user/group created while OpenTelemetry collector is i
8080

8181
## Windows
8282

83-
1. On your windows machine, open Registry Editor.
83+
1. On your Windows machine, open the Registry Editor.
8484
2. Go to `Computer\HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\OtelcolSumo`.
85-
3. Right click on the right pane and select `New > Multi-String Value`. You need to name this as `environment`.
86-
4. Right click on newly created entity `environment` in the step above and select `modify`
87-
5. You can set the environment variable as per your needs. For example in the below screenshot we have set `TEST_VAR` env variable with value `sumoemp`:<br/><img src={useBaseUrl('img/send-data/opentelemetry-collector/set_env_varibale_windows.png')} alt="linux-install" style={{border: '1px solid gray'}} width="800"/>
85+
3. Right-click on the right pane and select **New** > **Multi-String Value**. You need to name this as `environment`.
86+
4. Right click on newly created entity `environment` in the step above and select `modify`.
87+
5. You can set the environment variable as per your needs. For example, in the below screenshot, we have set `TEST_VAR` env variable with value `sumoemp`:<br/><img src={useBaseUrl('img/send-data/opentelemetry-collector/set_env_varibale_windows.png')} alt="linux-install" style={{border: '1px solid gray'}} width="800"/>
8888
6. Click on **OK**.
89-
7. **Optional Step** Since by default the variable set as part of registry are visible to all user, you can follow the below steps to manage the ACL of the service registry and environment variable set in above steps :
90-
- Right click on OtelcolSumo service in the left pane of the registry editor and click on permissions
91-
- Go to advance section by pressing Advanced button
92-
- Since the permissions are inherited by services from its parent by default, you will need to disable inheritance in the Advanced Security Settings popup.
93-
- While disabling inheritance you will get two options to either convert inherited permission or to remove inherit permissions and create the permission list from scrath. You can choose either of the two depending on your case.
94-
- You can then edit Users from this list to ensure appropriate access of this registry and environment variable set under it.<br/><img src={useBaseUrl('img/send-data/opentelemetry-collector/ACL_windows_registry.png')} alt="linux-install" style={{border: '1px solid gray'}} width="800"/>
89+
7. (Optional step) By default, any variables stored in the registry are visible to all users. To control visibility and permissions, follow the steps below to manage the ACLs for both the service registry and the environment variables you set previously.
90+
1. Right-click on OtelcolSumo service in the left pane of the registry editor and click on permissions.
91+
1. Go to the advanced section by pressing the Advanced button.
92+
1. Since the permissions are inherited by services from its parent by default, you will need to disable inheritance in the Advanced Security Settings popup.
93+
1. When you disable inheritance, you’ll be given two options: you can either convert the existing inherited permissions, or remove them entirely and build a new permission list from scratch. Choose whichever option best fits your requirements.
94+
1. You can then edit Users from this list to ensure appropriate access of this registry and environment variable set under it.<br/><img src={useBaseUrl('img/send-data/opentelemetry-collector/ACL_windows_registry.png')} alt="linux-install" style={{border: '1px solid gray'}} width="800"/>
9595
8. Restart the windows agent using the below command:
9696
`Restart-Service -Name OtelcolSumo`

0 commit comments

Comments
 (0)