Skip to content

Commit f80542c

Browse files
committed
test new build showing the specific offending characters
1 parent 2d9c12d commit f80542c

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

.github/workflows/pr.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,16 +48,16 @@ jobs:
4848
exit 0
4949
fi
5050
# Disallowed chars: " : < > | * ?
51-
OFFENDERS="$(find "$BUILD_DIR" -type f | grep -E '[\":<>|*?]')" || true
51+
OFFENDERS="$(find "$BUILD_DIR" -type f | grep -E '[" :<>|*?]')" || true
5252
if [ -n "$OFFENDERS" ]; then
5353
echo "❌ Disallowed characters found in build artifact paths:"
5454
echo "$OFFENDERS"
55-
# Annotate each offending path; show relative path from repo root
5655
while IFS= read -r p; do
57-
# Normalize to repo-relative path
5856
rel="${p#$(pwd)/}"
5957
[ "$rel" = "$p" ] && rel="$p"
60-
echo "::error file=${rel}::Disallowed character found in build artifact path (Pantheon rejects paths containing any of: \" : < > | * ?)"
58+
# Detect and print which character(s) caused it
59+
badchars=$(echo "$rel" | grep -oE '[" :<>|*?]' | tr -d '\n')
60+
echo "::error file=${rel}::Disallowed character(s) found in build artifact path: [${badchars}] (Pantheon rejects paths containing any of: \" : < > | * ?)"
6161
done <<< "$OFFENDERS"
6262
exit 1
6363
fi
@@ -94,10 +94,11 @@ jobs:
9494
if [ -n "$BAD_LINKS" ]; then
9595
echo "❌ Disallowed characters found in Markdown/MDX link targets:"
9696
echo "$BAD_LINKS"
97-
# Emit GitHub annotations for each finding
97+
# Emit GitHub annotations for each finding (including exact bad char(s))
9898
while IFS=$'\t' read -r file line match; do
9999
[ -z "$file" ] && continue
100-
echo "::error file=${file},line=${line}::Disallowed character in Markdown link target: ${match} (Not allowed: \" : < > | * ?)"
100+
badchars=$(echo "$match" | grep -oE '[" :<>|*?]' | tr -d '\n')
101+
echo "::error file=${file},line=${line}::Disallowed character(s) in Markdown link target: [${badchars}] ${match} (Not allowed: \" : < > | * ?)"
101102
done <<< "$BAD_LINKS"
102103
exit 1
103104
fi

cid-redirects.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2945,7 +2945,7 @@
29452945
"/cid/1108": "/docs/integrations/saas-cloud/trellix-mvision-epo",
29462946
"/cid/1110": "/docs/integrations/microsoft-azure/azure-security-microsoft-defender-for-identity",
29472947
"/docs/integrations/microsoft-azure/microsoft-defender-for-identity/": "/docs/integrations/microsoft-azure/azure-security-microsoft-defender-for-identity",
2948-
"/cid/1112": "/docs/integrations/saas-cloud/carbon-black-inventory/",
2948+
"/cid/1112": "/docs/integrations/saas-cloud/carbon-black-inventory/",
29492949
"/cid/1111": "/docs/integrations/microsoft-azure/azure-open-ai",
29502950
"/Cloud_SIEM_Enterprise": "/docs/cse",
29512951
"/Cloud_SIEM_Enterprise/Administration": "/docs/cse/administration",
@@ -4521,5 +4521,6 @@
45214521
"/docs/cse/signals": "/docs/cse/records-signals-entities-insights",
45224522
"/docs/query/query-operators/aggregation-functions": "/docs/search/search-query-language/group-aggregate-operators",
45234523
"/Search/Search-Query-Language/Parse-Operators": "/docs/search/search-query-language/parse-operators",
4524-
"/docs/get-started/training-certification-faq-new": "/docs/get-started/training-certification-faq"
4524+
"/docs/get-started/training-certification-faq-new": "/docs/get-started/training-certification-faq",
4525+
"/01Start-Here/Quick-Start-Tutorials/Using-Sumo-Logic-Tutorial/Lab-1:Viewing-Data": "/docs/get-started/training-certification-faq"
45254526
}

0 commit comments

Comments
 (0)