DOCS-107 - CIS for AWS CloudQuery - onboarding improvements #4209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpipkin1
added
doc:update
Collaborator
Author
|
@ajaiswals, could you review this PR? |
Collaborator
Author
kimsauce
reviewed
Jul 1, 2024
kimsauce
reviewed
Jul 1, 2024
docs/security/cloud-infrastructure-security/cloud-infrastructure-security-for-aws.md
Outdated
Show resolved
Hide resolved
kimsauce
approved these changes
Jul 1, 2024
Collaborator
kimsauce
left a comment
kimsauce
left a comment
There was a problem hiding this comment.
Looks awesome! Had one clarifying question and then the rest are suggestions.
Co-authored-by: Kim (Sumo Logic) <[email protected]>
Collaborator
Author
|
Thanks for the review, @kimsauce. |
…re-security-for-aws.md Co-authored-by: Kim (Sumo Logic) <[email protected]>
jpipkin1
changed the title
This was referenced Aug 14, 2024
Merged
Collaborator
|
Thanks for the heads up! Do you need help with anything? Would you also have to remove static/files/c2c/cloudquery-gcp/example.json and static/files/c2c/cloudquery-gcp/example.tf? |
Collaborator
Author
|
Thanks for catching that, @kimsauce! I removed all the CloudQuery static files with commit "Remove downloadable files for CloudQuery sources". |
jpipkin1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request removes CloudQuery from the following article and refreshes the installation procedure:
https://help.sumologic.com/docs/security/cloud-infrastructure-security/cloud-infrastructure-security-for-aws/
Select the type of change
Ticket (if applicable)
DOCS-107